Reverse printing on a stack

Expand Post »

I've finished writing the program for my class and everything actually does what it's suppose to (well 99% anyway).

I'm going to add snippets of the code that should help figure out the small glitch. What's happening is I can add x amount of elements to my stack and display them, but when they are displayed they are in reverse order instead of from bottom to top (the order they were input into the stack).

C++ Syntax (Toggle Plain Text)
template<class Type>
Type mystack<Type>::top() const
{
	assert(stackTop != 0);
	return list[stackTop - 1];
}
template<class Type>
Type mystack<Type>::top() const
{
	assert(stackTop != 0);
	return list[stackTop - 1];
}

the above is the command to display the elements

C++ Syntax (Toggle Plain Text)
template<class Type>
void mystack<Type>::push(const Type& newItem)
{
	if(!isFullStack())
	{
		list[stackTop] = newItem;
		stackTop++;
	}
	else
		cout <<"Cannot add to a full stack."<<endl;
}
template<class Type>
void mystack<Type>::push(const Type& newItem)
{
	if(!isFullStack())
	{
		list[stackTop] = newItem;
		stackTop++;
	}
	else
		cout <<"Cannot add to a full stack."<<endl;
}

the above is the code to push the new element into the stack

C++ Syntax (Toggle Plain Text)
if (choice == 1)
		{
			do
			{
				cin >> num;
				intStack.push(num);
				j++;
			}
			while(j < amount);
			workStack = intStack;
		}
if (choice == 1)
		{
			do
			{
				cin >> num;
				intStack.push(num);
				j++;
			}
			while(j < amount);
			workStack = intStack;
		}

the above is the main function to call the push command. (int j is initialized to 0)

Any reason why my stack is displaying backwards??

Similar Threads

Linked List Problem in C++
Reverse Output (Stack) in C++

RayvenHawk

Reputation Points: 32

Solved Threads: 2

Junior Poster in Training

Offline

77 posts
since Aug 2008

Permalink

Aug 30th, 2008

Re: Reverse printing on a stack

Quote originally posted by RayvenHawk ...

Any reason why my stack is displaying backwards??

That's how a stack works, it's a "last-in, first-out" structure. The item at the top will always be the last item that was pushed:

C++ Syntax (Toggle Plain Text)
#include <iostream>
#include <stack>
 
int main()
{
  using namespace std;
 
  stack<int> st;
 
  for (int i = 0; i < 5; ++i)
    st.push(i);
 
  // Display backward
  while (!st.empty()) {
    cout << st.top() << '\n';
    st.pop();
  }
}
#include <iostream>
#include <stack>

int main()
{
  using namespace std;

  stack<int> st;

  for (int i = 0; i < 5; ++i)
    st.push(i);

  // Display backward
  while (!st.empty()) {
    cout << st.top() << '\n';
    st.pop();
  }
}

To get the items in the order they were pushed you need a queue:

C++ Syntax (Toggle Plain Text)
#include <iostream>
#include <queue>
 
int main()
{
  using namespace std;
 
  queue<int> q;
 
  for (int i = 0; i < 5; ++i)
    q.push(i);
 
  // Display forward
  while (!q.empty()) {
    cout << q.front() << '\n';
    q.pop();
  }
}
#include <iostream>
#include <queue>

int main()
{
  using namespace std;

  queue<int> q;

  for (int i = 0; i < 5; ++i)
    q.push(i);

  // Display forward
  while (!q.empty()) {
    cout << q.front() << '\n';
    q.pop();
  }
}

Or you can figure out a way to reverse the stack. One way is to use two stacks:

C++ Syntax (Toggle Plain Text)
#include <iostream>
#include <stack>
 
int main()
{
  using namespace std;
 
  stack<int> st;
 
  for (int i = 0; i < 5; ++i)
    st.push(i);
 
  stack<int> temp;
 
  // Display forward
  while (!st.empty()) {
    temp.push(st.top());
    st.pop();
  }
 
  while (!temp.empty()) {
    cout << temp.top() << '\n';
    temp.pop();
  }
}
#include <iostream>
#include <stack>

int main()
{
  using namespace std;

  stack<int> st;

  for (int i = 0; i < 5; ++i)
    st.push(i);

  stack<int> temp;

  // Display forward
  while (!st.empty()) {
    temp.push(st.top());
    st.pop();
  }

  while (!temp.empty()) {
    cout << temp.top() << '\n';
    temp.pop();
  }
}

Each item is popped from the reversed stack into the temporary stack. Reversing a reversed list gives you the forward list:

C++ Syntax (Toggle Plain Text)
st:
 
|4|
|3| |3|
|2| |2| |2| 
|1| |1| |1| |1|
|0| |0| |0| |0| |0|
 
temp:
 
                |0|
            |1| |1|
        |2| |2| |2|
    |3| |3| |3| |3|
|4| |4| |4| |4| |4|
st:

|4|
|3| |3|
|2| |2| |2| 
|1| |1| |1| |1|
|0| |0| |0| |0| |0|

temp:

                |0|
            |1| |1|
        |2| |2| |2|
    |3| |3| |3| |3|
|4| |4| |4| |4| |4|

Another way is to display the stack using recursion:

C++ Syntax (Toggle Plain Text)
#include <iostream>
#include <stack>
 
namespace EdRules {
  using namespace std;
 
  void DisplayForward(stack<int> st)
  {
    if (st.empty())
      return;
 
    int temp = st.top();
 
    st.pop();
    DisplayForward(st);
 
    cout << temp << '\n';
  }
}
 
int main()
{
  using namespace std;
 
  stack<int> st;
 
  for (int i = 0; i < 5; ++i)
    st.push(i);
 
  // Display forward
  EdRules::DisplayForward(st);
}
#include <iostream>
#include <stack>

namespace EdRules {
  using namespace std;

  void DisplayForward(stack<int> st)
  {
    if (st.empty())
      return;

    int temp = st.top();

    st.pop();
    DisplayForward(st);

    cout << temp << '\n';
  }
}

int main()
{
  using namespace std;

  stack<int> st;

  for (int i = 0; i < 5; ++i)
    st.push(i);

  // Display forward
  EdRules::DisplayForward(st);
}

This is exactly the same thing as using two stacks because recursion takes the place of the temporary stack.

Radical Edward

Reputation Points: 361

Solved Threads: 97

Posting Pro

Offline

526 posts
since May 2008

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: Simple Source Control

Next Thread in C++ Forum Timeline: Limited digits from atof() OR strtod()

DaniWeb Message

Cancel Changes

User Name
Password