Ad:

C++ Discussion Thread
Marked Solved
Views: 11225

Oct 5th, 2008

vector <char*>

Expand Post »

Hi, i have a problem with a vector.

I declare a vector<char*> moves; in header.

Code:

C++ Syntax (Toggle Plain Text)
void LogView::init(){
	int a = 0;
	while (LogFile.good()){
		LogFile.getline(line, 6);
		moves.push_back(line);
	cout << "vector :"<< moves[a]<< endl; // here is OK
	a++;
	}
	moves.begin();
	cout << "vektor :"<< moves[1]<< endl;  // here is NOT OK
	cout << "vektor :"<< moves[2]<< endl;  // here is NOT OK
	cout << "vektor :"<< moves[3]<< endl;  // here is NOT OK
	cout << "vektor :"<< moves.at(1)<< endl;  // here is NOT OK
	cout << "vektor :"<< moves.at(2)<< endl;  // here is NOT OK
	cout << "vektor :"<< moves.at(3)<< endl;  // here is NOT OK
	cout << "vektor :"<< moves.front()<< endl;  // here is NOT OK
	cout << "vektor :"<< moves.back()<< endl;  // here is NOT OK 
	//AN ITERATION FOR IS NOT OK TOO.
	cout << moves.size(); // IT'S OK!
	}
}
void LogView::init(){
	int a = 0;
	while (LogFile.good()){
		LogFile.getline(line, 6);
		moves.push_back(line);
	cout << "vector :"<< moves[a]<< endl; // here is OK
	a++;
	}
	moves.begin();
	cout << "vektor :"<< moves[1]<< endl;  // here is NOT OK
	cout << "vektor :"<< moves[2]<< endl;  // here is NOT OK
	cout << "vektor :"<< moves[3]<< endl;  // here is NOT OK
	cout << "vektor :"<< moves.at(1)<< endl;  // here is NOT OK
	cout << "vektor :"<< moves.at(2)<< endl;  // here is NOT OK
	cout << "vektor :"<< moves.at(3)<< endl;  // here is NOT OK
	cout << "vektor :"<< moves.front()<< endl;  // here is NOT OK
	cout << "vektor :"<< moves.back()<< endl;  // here is NOT OK 
	//AN ITERATION FOR IS NOT OK TOO.
	cout << moves.size(); // IT'S OK!
	}
}

Thank You.

Similar Threads

Errors writing a vector to a file in C++
Large Char Array in C++
How to convert a vector<int> to vector<string> in C++
C and C++ Timesaving Tips in C++
passing a vector to a function? :errors: in C++

luisvega

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

9 posts
since Oct 2008

Permalink

Oct 5th, 2008

Re: vector <char*>

How do you assing memory to each pointer?

Last edited by Sci@phy; Oct 5th, 2008 at 11:20 am.

Sci@phy

Reputation Points: 110

Solved Threads: 43

Posting Whiz in Training

Offline

279 posts
since Sep 2008

Permalink

Oct 5th, 2008

Re: vector <char*>

Hi, in header:

C++ Syntax (Toggle Plain Text)
private:
	std::ifstream LogFile;
	char line[5];
	std::vector<char*> moves;
private:
	std::ifstream LogFile;
	char line[5];
	std::vector<char*> moves;

luisvega

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

9 posts
since Oct 2008

Permalink

Oct 5th, 2008

Re: vector <char*>

When you append pointers onto a vector of char, the pointer is copied. You are expecting the data the pointer points at to be copied.

With a vector<char *> you need to explicitly copy the data as well as the pointer.

An easier way would be to use a std::vector<std::string> instead (as std::string objects copy the data implicitly).

grumpier

Reputation Points: 193

Solved Threads: 32

Posting Whiz in Training

Offline

206 posts
since Aug 2008

Permalink

Oct 5th, 2008

Re: vector <char*>

Thank You!

luisvega

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

9 posts
since Oct 2008

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: C++ Newbie

Next Thread in C++ Forum Timeline: Matrix

DaniWeb Message

Cancel Changes

User Name
Password