Ad:

C++ Discussion Thread
Marked Solved
Views: 1520

Oct 21st, 2008

C++ Array pointer problem

Expand Post »

I'm writing a program wich is using an array -> startpoint[4]
this array will be later filled by values from an other array. this is not the problem!

the problem begins here:

I have a class: computerPlayer.cpp
with a method: getStartpoint()

cpp Syntax (Toggle Plain Text)
int *startPoint[4]; // global variable
 
int* computerPlayer::getStartpoint(){
 
	int beginpunta = 25; // static value -> will be changed later
	int beginpuntb= 5;   //  static value -> will be changed later
	int beginpuntc = 50;//  static value -> will be changed later
 
        startPoint[0] = &beginpunta;     // set array[0] with the value found on adres of beginpunta
	startPoint[1] = &beginpuntb;     // set array[0] with the value found on adres of beginpuntb
	startPoint[2] = &beginpuntc;     // set array[0] with the value found on adres of beginpuntc 
 
	cout << *startPoint[0] << " Pos 0" << endl; // print out value on location startPoint[0]
	cout << *startPoint[1] << " Pos 1" << endl; // print out value on location startPoint[1]
	cout << *startPoint[2] << " Pos 2" << endl; // print out value on location startPoint[2]
 
	return *startPoint;  // give the pointer to the caller of this function
}
int *startPoint[4]; // global variable

int* computerPlayer::getStartpoint(){
	
	int beginpunta = 25; // static value -> will be changed later
	int beginpuntb= 5;   //  static value -> will be changed later
	int beginpuntc = 50;//  static value -> will be changed later

        startPoint[0] = &beginpunta;     // set array[0] with the value found on adres of beginpunta
	startPoint[1] = &beginpuntb;     // set array[0] with the value found on adres of beginpuntb
	startPoint[2] = &beginpuntc;     // set array[0] with the value found on adres of beginpuntc 

	cout << *startPoint[0] << " Pos 0" << endl; // print out value on location startPoint[0]
	cout << *startPoint[1] << " Pos 1" << endl; // print out value on location startPoint[1]
	cout << *startPoint[2] << " Pos 2" << endl; // print out value on location startPoint[2]

	return *startPoint;  // give the pointer to the caller of this function
}

the cout works properly according to aspected values:

line 1: 25 Pos 0
line 2: 5 Pos 1
line 3: 50 Pos 2

this method is called from the main method in an other file: Artificial Intelligence.cpp

with in the Artificial Intelligence.cpp:

cpp Syntax (Toggle Plain Text)
 
computerPlayer p(3,3,3); // creation of computerplayer
int *ontvangen;  // global variable ontvangen (recieved)
 
int _tmain(int argc, _TCHAR* argv[])
{
        ontvangen = p.getStartpoint(); // request the pointer
 
	cout << ontvangen[0] << " Startpunt ontvangen" << endl; // printout value of ontvangen[0]
	cout << ontvangen[1] << " Startpunt ontvangen" << endl; // printout value of ontvangen[1]
	cout << ontvangen[2] << " Startpunt ontvangen" << endl; // printout value of ontvangen[2]
 
}
computerPlayer p(3,3,3); // creation of computerplayer
int *ontvangen;  // global variable ontvangen (recieved)

int _tmain(int argc, _TCHAR* argv[])
{
        ontvangen = p.getStartpoint(); // request the pointer

	cout << ontvangen[0] << " Startpunt ontvangen" << endl; // printout value of ontvangen[0]
	cout << ontvangen[1] << " Startpunt ontvangen" << endl; // printout value of ontvangen[1]
	cout << ontvangen[2] << " Startpunt ontvangen" << endl; // printout value of ontvangen[2]

}

now the output of these are:

line 4: 25 Startpunt ontvangen
line 5: 1611638598 Startpunt ontvangen
line 6 : 1612237512 Startpunt ontvangen

my conclusion:

ontvangen[0] = 25 // like expected
ontvangen[1] = 1611638598 // not expected
ontvangen[2] = 1612237512 // not expected

why does this happen and how can i fix this ??

Thanks in advance,

Greets Ronald van Meer
Student University of applied sciences Rotterdam ( The Netherlands )

Last edited by RonaldvanMeer; Oct 21st, 2008 at 12:47 pm. Reason: adding extra info

Similar Threads

C++: compile error "subscripted value is neither array nor pointer" in C++
file pointer problem in C
Help with code in C
C++ second largest problem in C++
Problem with a snippet of code in a shell program in C

RonaldvanMeer

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

3 posts
since Oct 2008

Permalink

Oct 21st, 2008

Re: C++ Array pointer problem

Well your variables below are local to the function. So when you leave the function, they don't exist and so their addresses now probably point to garbage values.

You should copy the values over onto your start pointers array, instead of pointing it to an address of a local variable.

(Toggle Plain Text)

int beginpunta = 25; // static value -> will be changed later
int beginpuntb= 5; // static value -> will be changed later
int beginpuntc = 50;// static value -> will be changed later

Last edited by stilllearning; Oct 21st, 2008 at 1:01 pm.

stilllearning

Reputation Points: 161

Solved Threads: 43

Posting Whiz

Offline

309 posts
since Oct 2007

Permalink

Oct 21st, 2008

Re: C++ Array pointer problem

stilllearning,
thanks for your fast reply.

I have put these variables out side of the method, declaring them as global variables and that solved my problem.

thank you!

class: computerPlayer.cpp

cpp Syntax (Toggle Plain Text)
 
      int *startPoint[4]; // global variable
 
      int beginpunta = 25; // static global value -> will be changed later
      int beginpuntb= 5; // static global value -> will be changed later
      int beginpuntc = 50;// static global value -> will be changed later
 
 
      int* computerPlayer::getStartpoint(){
 
      startPoint[0] = &beginpunta; // set array[0] with the value found on adres of beginpunta
      startPoint[1] = &beginpuntb; // set array[1] with the value found on adres of beginpuntb
      startPoint[2] = &beginpuntc; // set array[2] with the value found on adres of beginpuntc
 
      cout << *startPoint[0] << " Pos 0" << endl; // print out value on location startPoint[0]
      cout << *startPoint[1] << " Pos 1" << endl; // print out value on location startPoint[1]
      cout << *startPoint[2] << " Pos 2" << endl; // print out value on location startPoint[2]
 
      return *startPoint; // give the pointer to the caller of this function
      }
      int *startPoint[4]; // global variable

      int beginpunta = 25; // static global value -> will be changed later
      int beginpuntb= 5; // static global value -> will be changed later
      int beginpuntc = 50;// static global value -> will be changed later


      int* computerPlayer::getStartpoint(){

      startPoint[0] = &beginpunta; // set array[0] with the value found on adres of beginpunta
      startPoint[1] = &beginpuntb; // set array[1] with the value found on adres of beginpuntb
      startPoint[2] = &beginpuntc; // set array[2] with the value found on adres of beginpuntc

      cout << *startPoint[0] << " Pos 0" << endl; // print out value on location startPoint[0]
      cout << *startPoint[1] << " Pos 1" << endl; // print out value on location startPoint[1]
      cout << *startPoint[2] << " Pos 2" << endl; // print out value on location startPoint[2]

      return *startPoint; // give the pointer to the caller of this function
      }

Last edited by RonaldvanMeer; Oct 21st, 2008 at 7:09 pm. Reason: Fixed the Code now it works

RonaldvanMeer

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

3 posts
since Oct 2008

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: Testing if char is a number

Next Thread in C++ Forum Timeline: MySql++ Link Errors

DaniWeb Message

Cancel Changes

User Name
Password