Ad:

C++ Discussion Thread
Unsolved
Views: 579

Nov 12th, 2008

help with C++ program

Expand Post »

hi guys
am a total noob with C++ and im trying to write a program that will take a user inputted integer and displays its divisors and then tell the user whether it is a perfect number or not.

So far I have

C++ Syntax (Toggle Plain Text)
#include <iostream>
 
using namespace std;
int main() {
 
int n;
bool devisor;
cout << "enter number";
cin >> n; 
 
for (int i = 0 ; i < n/2 ; i++ ){
	devisor = true;
	if ( n % i = 0 ){
	devisor = false;
	}
}	
if(devisor){
	cout << i << "is a devisor" << end1;
}
return 0;
}
#include <iostream>

using namespace std;
int main() {

int n;
bool devisor;
cout << "enter number";
cin >> n; 

for (int i = 0 ; i < n/2 ; i++ ){
	devisor = true;
	if ( n % i = 0 ){
	devisor = false;
	}
}	
if(devisor){
	cout << i << "is a devisor" << end1;
}
return 0;
}

any extra help will be much appreciated

Last edited by Narue; Nov 12th, 2008 at 12:58 pm. Reason: added code tags

Similar Threads

What's the HARDEST program you've written? in Computer Science
Playing .Wav/MIDI files in a Visual Basic Program in Visual Basic 4 / 5 / 6
Cool little Program to disable startup programs in Windows NT / 2000 / XP
Program is shutting down right after program is executed in C++
3d Program in Game Development

nedsnurb

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

27 posts
since Nov 2008

Permalink

Nov 12th, 2008

Re: help with C++ program

What is it that you are having problem with? Are you getting errors when you compile? Does it compile but doesn't display the correct values??

freudian_slip

Reputation Points: 11

Solved Threads: 4

Light Poster

Offline

36 posts
since Oct 2008

Permalink

Nov 12th, 2008

Re: help with C++ program

well it doesn't compile it throws out the following errors:

error C2106: '=' : left operand must be l-value
error C2065: 'i' : undeclared identifier
error C2065: 'end1' : undeclared identifier

nedsnurb

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

27 posts
since Nov 2008

Permalink

Nov 12th, 2008

Re: help with C++ program

>error C2106: '=' : left operand must be l-value
In your code you say if ( n % i = 0 ){ . C++ uses == for equality and = for assignment, so you're using the wrong operator.

>error C2065: 'i' : undeclared identifier
This is a simple one: you haven't declared the variable i anywhere, so you can't use it.

>error C2065: 'end1' : undeclared identifier
This is also simple, and probably due to poor choice of fonts in your text editor. It's endl with a lower case L, not the number 1. Think of endl as standing for "end line" and you shouldn't have this problem anymore.

Narue

Administrator

Reputation Points: 6442

Solved Threads: 1393

Bad Cop

Offline

11,807 posts
since Sep 2004

Permalink

Nov 12th, 2008

Re: help with C++ program

Taking the mod of 0 might be a problem as well, since you declare i to start at zero.

iamthwee

Featured Poster

Reputation Points: 1536

Solved Threads: 431

Posting Expert

Offline

5,865 posts
since Aug 2005

Permalink

Nov 12th, 2008

Re: help with C++ program

thanks a lot guys, now it compiles correctly however wont display the divisors??

code now looks like this

C++ Syntax (Toggle Plain Text)
#include <iostream>
 
using namespace std;
int main() {
 
int i;
int n;
bool devisor;
cout << "enter number" <<endl;
cin >> n; 
 
for (int i = 1 ; i < n/2 ; i++ ){
	devisor = true;
	if ( n % i == 0 ){
	devisor = false;
	}
}	
if(devisor){
	cout << i << "is a devisor" << endl;
}
return 0;
}
#include <iostream>

using namespace std;
int main() {

int i;
int n;
bool devisor;
cout << "enter number" <<endl;
cin >> n; 

for (int i = 1 ; i < n/2 ; i++ ){
	devisor = true;
	if ( n % i == 0 ){
	devisor = false;
	}
}	
if(devisor){
	cout << i << "is a devisor" << endl;
}
return 0;
}

i know im in the realms of retardation to you guys but help is a godsend!

Last edited by Narue; Nov 12th, 2008 at 3:21 pm. Reason: added code tags, please do it yourself next time

nedsnurb

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

27 posts
since Nov 2008

Permalink

Nov 12th, 2008

Re: help with C++ program

can you try this...

C++ Syntax (Toggle Plain Text)
if(devisor==true)
{
cout << i << "is a devisor" << endl;
}
if(devisor==true)
{
cout << i << "is a devisor" << endl;
}

AcidG3rm5

Reputation Points: 6

Solved Threads: 0

Light Poster

Offline

25 posts
since Oct 2008

Permalink

Nov 12th, 2008

Re: help with C++ program

Click to Expand / Collapse Quote originally posted by AcidG3rm5 ...

can you try this...
C++ Syntax (Toggle Plain Text)
if(devisor==true)
{
cout << i << "is a devisor" << endl;
}
if(devisor==true) { cout << i << "is a devisor" << endl; }

Yes, it's the same thing. Since if() checks if the statement is true.
When you say if(condition == false) you're asking, "if it is true that this condition is equivalent to false".

MosaicFuneral

Reputation Points: 888

Solved Threads: 114

Nearly a Posting Virtuoso

Offline

1,270 posts
since Nov 2008

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: heap creation c++

Next Thread in C++ Forum Timeline: Order of operations!

DaniWeb Message

Cancel Changes

User Name
Password