Max and Min values from a group of numbers

[yvonnemo]

Hi, I been trying this problem for 2 days and monday 31st is the due date :(
I tried to use a while loop but the numbers I get are not even close. What I did on the Enter your code is the codes below the question

//********************************************************************************************
// 
// MaxMinIntegers.cpp          
//
// Program that reads int values from a text file named "numbers01.txt"
// and writes out the largest and smallest values found. Numbers in the
// file may be separated by blanks or line breaks.
//
//********************************************************************************************

#include <fstream>
#include <iostream>
#include <cstdlib>
using namespace std;


int main() {
    // Declare input stream
    ifstream fin;
    int min, max, val;
    int isFirst = true;
    fin.open("numbers01.txt");



	// --------------------------------
	// ----- ENTER YOUR CODE HERE -----
	// --------------------------------


	// --------------------------------
	// --------- END USER CODE --------
	// --------------------------------


    fin.close();

    cout << "Largest value is " << max << ", smallest value is " << min << "\n";
}




<strong>Here is what I did</strong>
              
fin >> isFirst;
while (fin >> val)
fin >> val;
if (isFirst > val)
min = val
max = isFirst
else
max = val
min = isFirst

[jwenting]

you're going about it wrong but you probably knew that already.

Here's what to do (I leave it to you to translate that into C++):

declare variable for smallest value
declare variable for largest value
set both to first value in the file
while there's more data
    read new value
    if smaller than smallest set as smallest
    else when larger than largest set as largest
wend
close file

[yvonnemo]

Hi, thanks for helping. Here is what I tried to convert it into but it didn't quite actully work. It always make the first number it reads the max and min.. I donno why :sad:

//********************************************************************************************
// 
// MaxMinIntegers.cpp          
//
// Program that reads int values from a text file named "numbers01.txt"
// and writes out the largest and smallest values found. Numbers in the
// file may be separated by blanks or line breaks.
//
//********************************************************************************************

#include <fstream>
#include <iostream>
#include <cstdlib>
using namespace std;


int main() {
    // Declare input stream
    ifstream fin;
    int min, max, val;
    int isFirst = true;
    fin.open("numbers01.txt");

    fin >> isFirst;
    min = isFirst;
    max = isFirst;

    while (fin >> val)
    {

          fin >> val;
          if (val < min)
          val = min;
          else
          val = max;
    }
	// --------------------------------
	// ----- ENTER YOUR CODE HERE -----
	// --------------------------------


	// --------------------------------
	// --------- END USER CODE --------
	// --------------------------------


    fin.close();

    cout << "Largest value is " << max << ", smallest value is " << min << "\n";

    system("PAUSE");
}

[yvonnemo]

nm I got it working now. thanks for the help :D