Ad:

C++ Discussion Thread
Marked Solved
Views: 586

Feb 20th, 2009

Problem with Decoder

Expand Post »

Thanks in advance for your help. I am supposed to create a program that allows user input for a code. The program will then read the array and output the letter on the keyboard one character to the left of the inputted strings. I am first trying to get the top row of the keyboard to output correctly before finishing off the rest of the program, but I don't get the output I am expecting. What am I doing wrong?

C++ Syntax (Toggle Plain Text)
#include <iostream>
#include <string>
#include <cctype>
using namespace std;
 
 
int main()
{
    //define array1, 2, 3    
    char Code[] = {'q', 'w', 'e', 'r', 't', 'y', 'u', 'i', 'o', 'p'};
    char Code2[10];
    string dCode;        
 
    cout << "Enter the code you wish decoded: ";
    cin  >> dCode;
    cout << endl;
 
 
    int size;
    char Code3[size];
    size = dCode.length();
    char ans[size];        
 
    for(int i = 0; i < size; i++)
    {
      Code2[i] = dCode[i];
      for(int h = 0; h < size; h++)     
      { if (Code2[i] == Code[i])
        cout << dCode[h - 1];
 
      }
    }    
      cout << endl;  
 
 
 
    system ("pause");
    return 0;
}
#include <iostream>
#include <string>
#include <cctype>
using namespace std;


int main()
{
    //define array1, 2, 3    
    char Code[] = {'q', 'w', 'e', 'r', 't', 'y', 'u', 'i', 'o', 'p'};
    char Code2[10];
    string dCode;        
       
    cout << "Enter the code you wish decoded: ";
    cin  >> dCode;
    cout << endl;
         

    int size;
    char Code3[size];
    size = dCode.length();
    char ans[size];        
    
    for(int i = 0; i < size; i++)
    {
      Code2[i] = dCode[i];
      for(int h = 0; h < size; h++)     
      { if (Code2[i] == Code[i])
        cout << dCode[h - 1];
        
      }
    }    
      cout << endl;  
  
    
                       
    system ("pause");
    return 0;
}

Last edited by meistrizy; Feb 20th, 2009 at 5:22 pm.

Similar Threads

DVD Decoder problem, not allowing DVD playback in Windows 95 / 98 / Me
Need Help In Decoder Programming in C++
Newbie with a decoder question/problem in Windows NT / 2000 / XP
Windows 2000... dvd decoder missing??? in Windows NT / 2000 / XP
Hamming codes encoder/decoder in C or C++ in C++

meistrizy

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

33 posts
since Dec 2008

Permalink

Feb 20th, 2009

Re: Problem with Decoder

your loop is doing too much work.

C++ Syntax (Toggle Plain Text)
char codes[] = "qwertyuiop";
 
string dCode = "wtu";  // hard-code search value
 
for(int i = 0; i < dCode.size(); i++)
{
    for(int j = 0;  codes[j] != 0; j++)
    {
          if( dCode[i] == codes[j])
          {
              cout << codes[j-1];
              break;
          }
    }
}
char codes[] = "qwertyuiop";

string dCode = "wtu";  // hard-code search value

for(int i = 0; i < dCode.size(); i++)
{
    for(int j = 0;  codes[j] != 0; j++)
    {
          if( dCode[i] == codes[j])
          {
              cout << codes[j-1];
              break;
          }
    }
}

Ancient Dragon

Sponsor

Team Colleague

Featured Poster

Reputation Points: 5608

Solved Threads: 2282

Retired and Enjoying Life

Offline

21,950 posts
since Aug 2005

Permalink

Feb 21st, 2009

Re: Problem with Decoder

For some reason this is causing my program to crash. Am I missing something?

meistrizy

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

33 posts
since Dec 2008

Permalink

Feb 21st, 2009

Re: Problem with Decoder

post new code.

Ancient Dragon

Sponsor

Team Colleague

Featured Poster

Reputation Points: 5608

Solved Threads: 2282

Retired and Enjoying Life

Offline

21,950 posts
since Aug 2005

Permalink

Feb 21st, 2009

Re: Problem with Decoder

Sorry. Here it is:

C++ Syntax (Toggle Plain Text)
#include <iostream>
#include <string>
#include <cctype>
using namespace std;
 
 
int main()
{
    //define array1, 2, 3    
    char Code[] = {'q', 'w', 'e', 'r', 't', 'y', 'u', 'i', 'o', 'p'};
    char Code2[10];// = {'q', 'w', 'e', 'r', 't', 'y', 'u', 'i', 'o', 'p'};
 
    string dCode;        
 
    cout << "Enter the code you wish decoded: ";
    cin  >> dCode;
    cout << endl;
 
 
    int size;
    char Code3[size];
    size = dCode.length();
    char ans[size];        
 
    for(int i = 0; i < dCode.size(); i++)
    {
      for(int h = 0; Code[h] != 0; h++)     
      { 
        if (dCode[i] == Code[h])
        {
         cout << Code[h - 1];
         break;
        }        
      }
    }    
      cout << endl;   
 
 
    system ("pause");
    return 0;
}
#include <iostream>
#include <string>
#include <cctype>
using namespace std;


int main()
{
    //define array1, 2, 3    
    char Code[] = {'q', 'w', 'e', 'r', 't', 'y', 'u', 'i', 'o', 'p'};
    char Code2[10];// = {'q', 'w', 'e', 'r', 't', 'y', 'u', 'i', 'o', 'p'};
    
    string dCode;        
       
    cout << "Enter the code you wish decoded: ";
    cin  >> dCode;
    cout << endl;
         

    int size;
    char Code3[size];
    size = dCode.length();
    char ans[size];        
    
    for(int i = 0; i < dCode.size(); i++)
    {
      for(int h = 0; Code[h] != 0; h++)     
      { 
        if (dCode[i] == Code[h])
        {
         cout << Code[h - 1];
         break;
        }        
      }
    }    
      cout << endl;   
    
   
    system ("pause");
    return 0;
}

meistrizy

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

33 posts
since Dec 2008

Permalink

Feb 21st, 2009

Re: Problem with Decoder

When AncientDragon wrote Code[h] != 0 , his code was correct. Yours isn't. Why? AncientDragon's codes array was a string literal, which automatically has a '\0' or 0 value at the end. Your array does not. Either append a '\0' element or change your codes array to look like AncientDragon's.

Last edited by death_oclock; Feb 21st, 2009 at 7:27 pm.

death_oclock

Reputation Points: 128

Solved Threads: 43

Posting Whiz

Offline

389 posts
since Apr 2006

Permalink

Feb 25th, 2009

Re: Problem with Decoder

Thanks Ancient Dragon and Death Oclock for your help. My code works fine now. Here it is reposted for those who might have similar problems:

C++ Syntax (Toggle Plain Text)
#include <iostream>
#include <string>
#include <cctype>
using namespace std;
 
 
int main()
{
    //define array    
    char Code[] = {'q', 'w', 'e', 'r', 't', 'y', 'u', 'i', 'o', 'p',
                   'a', 's', 'd', 'f', 'g', 'h', 'j', 'k', 'l',
                   'z', 'x', 'c', 'v', 'b', 'n', 'm'}; 
 
    string dCode;        
 
    cout << "Enter the code you wish decoded: ";
    cout << endl;
    getline (cin, dCode);
 
 
    int size;
    size = dCode.length();
    char Code3[size];    
 
 
    for(int i = 0; i < size; i++)
    {         
      for(int h = 0; h < 26; h++)     
      {         
        if (dCode[i] == Code[h])
        {            
           dCode[i] = Code[h - 1];
 
        }
        else 
        {
            dCode[i] = dCode[i];            
        }        
      }
    }    
 
    cout << endl;
    cout << "The translated code from above is: ";    
    cout << endl << dCode;
    cout << endl;
    cout << endl;    
 
 
    system ("pause");
    return 0;
}
#include <iostream>
#include <string>
#include <cctype>
using namespace std;


int main()
{
    //define array    
    char Code[] = {'q', 'w', 'e', 'r', 't', 'y', 'u', 'i', 'o', 'p',
                   'a', 's', 'd', 'f', 'g', 'h', 'j', 'k', 'l',
                   'z', 'x', 'c', 'v', 'b', 'n', 'm'}; 
        
    string dCode;        
       
    cout << "Enter the code you wish decoded: ";
    cout << endl;
    getline (cin, dCode);
            

    int size;
    size = dCode.length();
    char Code3[size];    
         
    
    for(int i = 0; i < size; i++)
    {         
      for(int h = 0; h < 26; h++)     
      {         
        if (dCode[i] == Code[h])
        {            
           dCode[i] = Code[h - 1];
                    
        }
        else 
        {
            dCode[i] = dCode[i];            
        }        
      }
    }    
    
    cout << endl;
    cout << "The translated code from above is: ";    
    cout << endl << dCode;
    cout << endl;
    cout << endl;    
      
                             
    system ("pause");
    return 0;
}

Last edited by meistrizy; Feb 25th, 2009 at 6:46 am.

meistrizy

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

33 posts
since Dec 2008

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: IOStream cin causing problems

Next Thread in C++ Forum Timeline: txt reading problem

DaniWeb Message

Cancel Changes

User Name
Password