Ad:

C++ Discussion Thread
Marked Solved
Views: 774

Page 1
2
Next

You are currently viewing page 1 of this multi-page discussion thread

Feb 22nd, 2009

What is wrong?..!

Expand Post »

Hello friends.. I am an amateur programmer in TURBO C++ .. It is a very old version v3.0 ... I am beginner.. I wrote a very simple programme to find the largest ans smallest element in an array . .
The largest element finding process is working finely .. I added a watch on MAX and MIN... but out put MIN is wrong..! please help me Pros

Jeevan

C++ Syntax (Toggle Plain Text)
#include<iostream.h>
#include<conio.h>
void main()
 
 {
 clrscr();
 int a[10],n,min,max,i;
 cout<<"Enter the number of elements in the matrix \t";
 cin>>n;
 cout<<"enter the elements of the matrix \n";
 for(i=0;i<n;i++)
 cin>>a[i];
 max=min=a[0];
 
 for(i=0;i<n;i++)
 if(a[i]>max)
  max=a[i];
 if(a[i]<min)
  min=a[i];
 cout<<"Largest is "<<max<<" and Smallest is "<<min;
 getch();
#include<iostream.h>
#include<conio.h>
void main()

 {
 clrscr();
 int a[10],n,min,max,i;
 cout<<"Enter the number of elements in the matrix \t";
 cin>>n;
 cout<<"enter the elements of the matrix \n";
 for(i=0;i<n;i++)
 cin>>a[i];
 max=min=a[0];

 for(i=0;i<n;i++)
 if(a[i]>max)
  max=a[i];
 if(a[i]<min)
  min=a[i];
 cout<<"Largest is "<<max<<" and Smallest is "<<min;
 getch();

Similar Threads

My CD-RW plays but won't burn. What could be wrong?? Help Please? in Storage
Retrieve email I sent to the wrong person in Web Browsers
Ram voltage wrong?? in Motherboards, CPUs and RAM
Am I going about this the wrong way in IT Professionals' Lounge
wats wrong with imesh??? in Windows NT / 2000 / XP

jeevsmyd

Reputation Points: 8

Solved Threads: 0

Junior Poster

Offline

136 posts
since Oct 2008

Permalink

Feb 22nd, 2009

Re: What is wrong?..!

You need more { }

Salem

Team Colleague

Reputation Points: 5862

Solved Threads: 950

Posting Sage

Offline

7,164 posts
since Dec 2005

Permalink

Feb 22nd, 2009

Re: What is wrong?..!

Hey this is the new code.. Is there anything wrong with this one? I missed the ELSE and a few {}

C++ Syntax (Toggle Plain Text)
#include<iostream.h>
#include<conio.h>
void main()
 
 {
 clrscr();
 int a[10],n,min,max,i;
 cout<<"Enter the number of elements in the matrix \t";
 cin>>n;
 cout<<"enter the elements of the matrix \n";
 for(i=0;i<n;i++)
 cin>>a[i];
 max=min=a[0];
 
 for(i=0;i<n;i++)
 if(a[i]>max)
     {
 max=a[i];
      }
 else if(a[i]<min)
     {
  min=a[i];
     }
 cout<<"Largest is "<<max<<" and Smallest is "<<min;
 getch();
 }
#include<iostream.h>
#include<conio.h>
void main()

 {
 clrscr();
 int a[10],n,min,max,i;
 cout<<"Enter the number of elements in the matrix \t";
 cin>>n;
 cout<<"enter the elements of the matrix \n";
 for(i=0;i<n;i++)
 cin>>a[i];
 max=min=a[0];

 for(i=0;i<n;i++)
 if(a[i]>max)
     {
 max=a[i];
      }
 else if(a[i]<min)
     {
  min=a[i];
     }
 cout<<"Largest is "<<max<<" and Smallest is "<<min;
 getch();
 }

jeevsmyd

Reputation Points: 8

Solved Threads: 0

Junior Poster

Offline

136 posts
since Oct 2008

Permalink

Feb 22nd, 2009

Re: What is wrong?..!

And what about the for loop?

Salem

Team Colleague

Reputation Points: 5862

Solved Threads: 950

Posting Sage

Offline

7,164 posts
since Dec 2005

Permalink

Feb 22nd, 2009

Re: What is wrong?..!

hey excuse me but the above code is absolutely fine,i dont find an error it is running fine

arghasen

Reputation Points: 10

Solved Threads: 5

Light Poster

Offline

35 posts
since Nov 2008

Permalink

Feb 22nd, 2009

Re: What is wrong?..!

Yeah..There are no problems with the code.. It is working fine.. What is wrong with the for loop?

jeevsmyd

Reputation Points: 8

Solved Threads: 0

Junior Poster

Offline

136 posts
since Oct 2008

Permalink

Feb 22nd, 2009

Re: What is wrong?..!

It's missing { }

Comatose

Team Colleague

Reputation Points: 361

Solved Threads: 214

Taboo Programmer

Offline

2,413 posts
since Dec 2004

Permalink

Feb 22nd, 2009

Re: What is wrong?..!

no problem with the for loop as well

maybe sallem gave the coment as u missed the barces of the for loop in your first code

arghasen

Reputation Points: 10

Solved Threads: 5

Light Poster

Offline

35 posts
since Nov 2008

Permalink

Feb 22nd, 2009

Re: What is wrong?..!

anyways the problem is now solved so make the thread as solved

arghasen

Reputation Points: 10

Solved Threads: 5

Light Poster

Offline

35 posts
since Nov 2008

Permalink

Feb 22nd, 2009

Re: What is wrong?..!

okay buddy..

jeevsmyd

Reputation Points: 8

Solved Threads: 0

Junior Poster

Offline

136 posts
since Oct 2008

Page 1
2
Next

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: Help on fscanf

Next Thread in C++ Forum Timeline: How to use an array element in if-statement?

DaniWeb Message

Cancel Changes

User Name
Password