Ad:

C++ Discussion Thread
Marked Solved
Views: 542

Mar 18th, 2009

for loop

Expand Post »

greetings everyone,

i seem to be having an issue with a function that has a reference n a value to do a loop. the nature of the prog, is to roll a dice (n) times n then count the number of time srand rolls an even num.

for the most part i think it is working--no errors, but inside a function im calling another function n then asking it to loop. And that is where im stuck @.

C++ Syntax (Toggle Plain Text)
 
#include <cstdio>
#include <cstdlib>
#include <ctime>
#include <iostream>
using namespace std;
 
int simDiceThrow(int, int&);
int diceThrow(int&);
bool isEvenSided(int&);
 
const long MAX=6, MIN=1;
 
int main ()
{
    int diceA,
        total=0,
        totalOne=0,
        pvalue,
        maxNumber=0;
 
srand((unsigned)time(NULL));
 
 
        cout <<" Dice Counter\n\n";
 
        maxNumber = 100;
 
        simDiceThrow(maxNumber, pvalue);<div> <div class="quote"> <div class="quote_header">   Quote ...   </div> <blockquote class="quote_body"> not sure if error is here as the MaxNum should be getting passed to the loop inside the function </blockquote> </div> </div>             if (isEvenSided(pvalue) != false) {total++;}
 
        maxNumber = 1000;
 
        simDiceThrow(maxNumber, pvalue);<div> <div class="quote"> <div class="quote_header">   Quote ...   </div> <blockquote class="quote_body"> im wondering how will the if statement run if there is no loop outside?? </blockquote> </div> </div>             if (isEvenSided(pvalue) != false) {totalOne++;}
 
    cout <<"100 x dice thrown " 
         <<" " <<total <<" " <<pvalue;
 
    cout <<"\n1000 x dice thrown"
         <<" " <<totalOne <<" "  <<pvalue;
 
 
  _flushall();
    cin.get();
 
     return 0;
 
}
int diceThrow (int &diceA)
{
    return (diceA = (rand() % (MAX - MIN +1))+ MIN);
 
}
 
bool isEvenSided (int &pvalue)
{
     return ((pvalue%2)== 0);
}
 
int simDiceThrow(int maxNumber, int &diceA)
{
    int pvalue;
 
    for (int roll = 0; roll < maxNumber; roll++) {pvalue = diceThrow(diceA);}
    return pvalue;
}
#include <cstdio>
#include <cstdlib>
#include <ctime>
#include <iostream>
using namespace std;

int simDiceThrow(int, int&);
int diceThrow(int&);
bool isEvenSided(int&);

const long MAX=6, MIN=1;

int main ()
{
    int diceA,
        total=0,
        totalOne=0,
        pvalue,
        maxNumber=0;

srand((unsigned)time(NULL));
            
    
        cout <<" Dice Counter\n\n";
    
        maxNumber = 100;
          
        simDiceThrow(maxNumber, pvalue);<div> <div class="quote"> <div class="quote_header">   Quote ...   </div> <blockquote class="quote_body"> not sure if error is here as the MaxNum should be getting passed to the loop inside the function </blockquote> </div> </div>             if (isEvenSided(pvalue) != false) {total++;}
         
        maxNumber = 1000;
         
        simDiceThrow(maxNumber, pvalue);<div> <div class="quote"> <div class="quote_header">   Quote ...   </div> <blockquote class="quote_body"> im wondering how will the if statement run if there is no loop outside?? </blockquote> </div> </div>             if (isEvenSided(pvalue) != false) {totalOne++;}
           
    cout <<"100 x dice thrown " 
         <<" " <<total <<" " <<pvalue;
         
    cout <<"\n1000 x dice thrown"
         <<" " <<totalOne <<" "  <<pvalue;
         
         
  _flushall();
    cin.get();
  
     return 0;
         
}
int diceThrow (int &diceA)
{
    return (diceA = (rand() % (MAX - MIN +1))+ MIN);
    
}

bool isEvenSided (int &pvalue)
{
     return ((pvalue%2)== 0);
}

int simDiceThrow(int maxNumber, int &diceA)
{
    int pvalue;
    
    for (int roll = 0; roll < maxNumber; roll++) {pvalue = diceThrow(diceA);}
    return pvalue;
}

any suggestions are greatly appreciated.

Similar Threads

Help with gui loop. in C
Loop...without the loop in Java

fx7202

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

3 posts
since Mar 2009

Permalink

Mar 19th, 2009

Re: for loop

C++ Syntax (Toggle Plain Text)
 if (isEvenSided(pvalue) != false) {total++;}
 if (isEvenSided(pvalue) != false) {total++;}

How can you compute the total outside the loop ? you should
pass the total also as a reference. And inside the function you
can make it to zero first and add it if even.

First draw a structure chart. Then you can clearly model this.

Last edited by NicAx64; Mar 19th, 2009 at 2:01 am.

NicAx64

Reputation Points: 86

Solved Threads: 43

Posting Pro

Offline

532 posts
since Mar 2009

Permalink

Mar 19th, 2009

Re: for loop

alright so after getting some dinner, i decided to redo the whole thing. from the drawing board i came up with the following code, but something is fishie about the count. it runs the loop for the srand and from what i can tell moves the counter but the count is not always right.

C++ Syntax (Toggle Plain Text)
#include <cstdio>
#include <cstdlib>
#include <ctime>
#include <iostream>
#include <iomanip>
using namespace std;
 
int simDiceThrow(int, int&);
int diceThrow();
bool isEvenSided(int&);
 
int main ()
{
    int total=0,
        totalOne=0,
        maxNumber;
 
srand((unsigned)time(NULL));
 
 
        cout <<" Dice Counter\n\n";
 
        maxNumber = 3;
        simDiceThrow(maxNumber, total);
 
        cout <<"total even for 100: " <<total <<endl;  
 
        maxNumber = 5;
        simDiceThrow(maxNumber, totalOne);
 
        cout <<"total even for 1000: " <<totalOne <<endl;
 
 
    cin.get();
    cin.get();
 
     return 0;
 
}
int diceThrow ()
{
     int diceA = (rand()% 6+ 1);
     return diceA; 
}
 
bool isEvenSided (int &pvalue)
{
     return (pvalue %2 == 0);
}
 
int simDiceThrow(int maxNumber, int &total)
{
    int pvalue;
 
    for (int roll = 1; roll <= maxNumber; roll++) 
    {
        cout <<setw(5) <<diceThrow() <<endl;
 
    pvalue=diceThrow();
 
    if (isEvenSided(pvalue)) {total++;}
 
    }
}
#include <cstdio>
#include <cstdlib>
#include <ctime>
#include <iostream>
#include <iomanip>
using namespace std;

int simDiceThrow(int, int&);
int diceThrow();
bool isEvenSided(int&);

int main ()
{
    int total=0,
        totalOne=0,
        maxNumber;

srand((unsigned)time(NULL));
            
    
        cout <<" Dice Counter\n\n";
    
        maxNumber = 3;
        simDiceThrow(maxNumber, total);
        
        cout <<"total even for 100: " <<total <<endl;  
             
        maxNumber = 5;
        simDiceThrow(maxNumber, totalOne);
                  
        cout <<"total even for 1000: " <<totalOne <<endl;
             
            
    cin.get();
    cin.get();
  
     return 0;
         
}
int diceThrow ()
{
     int diceA = (rand()% 6+ 1);
     return diceA; 
}

bool isEvenSided (int &pvalue)
{
     return (pvalue %2 == 0);
}

int simDiceThrow(int maxNumber, int &total)
{
    int pvalue;
    
    for (int roll = 1; roll <= maxNumber; roll++) 
    {
        cout <<setw(5) <<diceThrow() <<endl;
    
    pvalue=diceThrow();
    
    if (isEvenSided(pvalue)) {total++;}
           
    }
}

that produces some like this:

Quote ...

Dice Counter

1
3
2
total even for 3: 1 //this one is correct
6
5
4
4
3
total even for 5: 4 //this one isnt, i am thinking something a zero but dont know where to eliminate such prob

fx7202

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

3 posts
since Mar 2009

Permalink

Mar 19th, 2009

Re: for loop

In your simDiceThrow() loop you output the dice values, but then calculate the number of even values by throwing the dice again. So the number of even values has no relation to the numbers previously output. The logic you actually need is to throw the dice n times, remembering each value thrown. Calculate the number of even values, then output the number set and total.

MrSpigot

Reputation Points: 76

Solved Threads: 40

Junior Poster

Offline

156 posts
since Mar 2009

Permalink

Mar 19th, 2009

Re: for loop

good you have taken some courage .
if you still can't underestand why look at this code and
think why ?

C++ Syntax (Toggle Plain Text)
int simDiceThrow(int maxNumber, int &total)
{
    int pvalue;
 
    for (int roll = 1; roll <= maxNumber; roll++) 
    {
        //cout <<setw(5) <<diceThrow() <<endl;
 
    pvalue=diceThrow();
    cout << setw(5) << pvalue << endl ; 
 
    if (isEvenSided(pvalue)) {total++;}
 
    }
}
int simDiceThrow(int maxNumber, int &total)
{
    int pvalue;
    
    for (int roll = 1; roll <= maxNumber; roll++) 
    {
        //cout <<setw(5) <<diceThrow() <<endl;
    
    pvalue=diceThrow();
    cout << setw(5) << pvalue << endl ; 
    
    if (isEvenSided(pvalue)) {total++;}
           
    }
}

NicAx64

Reputation Points: 86

Solved Threads: 43

Posting Pro

Offline

532 posts
since Mar 2009

Permalink

Mar 19th, 2009

Re: for loop

i now see where the error what and why it was, so here is my understanding of it.

num gets generated it then gets passed over to the bool and gets counted if return is true. my first issue was that the bool was not in the loop, then after that was corrected, the value was not passed over to the bool for count. here is the updated function. works great. thank you guys for pushing.

C++ Syntax (Toggle Plain Text)
int simDiceThrow(int maxNumber, int &total)
{
    for (int roll = 1; roll <= maxNumber; roll++) 
    {
          int evalue=diceThrow();
 
          cout <<setw(2) <<evalue;
          if (roll %25 == 0) cout <<endl; //spacing
 
          if (isEvenSided(evalue)) {total++;}
    }
}
int simDiceThrow(int maxNumber, int &total)
{
    for (int roll = 1; roll <= maxNumber; roll++) 
    {
          int evalue=diceThrow();
    
          cout <<setw(2) <<evalue;
          if (roll %25 == 0) cout <<endl; //spacing
    
          if (isEvenSided(evalue)) {total++;}
    }
}

fx7202

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

3 posts
since Mar 2009

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: Array subscript error: invalid types char[int] (?)

Next Thread in C++ Forum Timeline: Dynamic Array to Static Array

DaniWeb Message

Cancel Changes

User Name
Password