Ad:

C++ Discussion Thread
Unsolved
Views: 2981

Page 1
2
Next

You are currently viewing page 1 of this multi-page discussion thread

Feb 17th, 2005

Program with many errors

Expand Post »

This is my first attempt at creating a program and I am having great problems. The program is meant to scan a file and increment a counter if specific words are found. Can anyone let me know where I'm going wrong,Thanks

#include <iostream>
#include <fstream>
#include <string>
#include <iomanip>
#include <cstdlib>
#include <conio.h>

using namespace std;

int main (void)
{
string string1;
int location;
char userName; //The students log-in name
int markCounter //Counter for adding up students mark

system("cls"); // Clear the screen

cout << "Marking Program" << endl << endl;

ifstream infile("checkUserName.txt", ios::in);

//Get students username
cout << "Enter Students Username: ";
cin >>string1;// entered username

// Check students username validity
userName.find_first_of("checkUserName.txt");

if string1 /found then
cout << "Username not found"<<;

else
ifstream infile("string1.txt", ios::in); //open students file
ifstream infile("markScheme.txt", ios::in);

while (getline(markScheme, line1)) {

if (line1.find(search) != string::npos)
++1 counter;

while (getline(markScheme, line2)) {

if (line2.find(search) != string::npos)
++1 counter;

while (getline(markScheme, line3)) {

if (line3.find(search) != string::npos)
++1 counter;

while (getline(markScheme, line4)) {

if (line4.find(search) != string::npos)
++1 counter;

while (getline(markScheme, line5)) {

if (line5.find(search) != string::npos)
++1 counter;

while (getline(markScheme, line6)) {

if (line6.find(search) != string::npos)
++1 counter;

while (getline(markScheme, line7)) {

if (line7.find(search) != string::npos)
++1 counter;

while (getline(markScheme, line8)) {

if (line8.find(search) != string::npos)
++1 counter;

while (getline(markScheme, line9)) {

if (line9.find(search) != string::npos)
++1 counter;

while (getline(markScheme, line10)) {

if (line10.find(search) != string::npos)
++1 counter;

//Display students mark
cout << "Students mark is (counter)";

}

}

Similar Threads

STOP Errors Before AND After Upgrade in Windows NT / 2000 / XP
what's the best program to keep pc without errors in Windows NT / 2000 / XP
Error in c++ program in C++

jonnie83

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

24 posts
since Feb 2005

Permalink

Feb 18th, 2005

Re: Program with many errors

Please use code tags
http://daniweb.com/techtalkforums/an...nouncementid=3

prog-bman

Reputation Points: 14

Solved Threads: 4

Junior Poster

Offline

108 posts
since Nov 2004

Permalink

Feb 18th, 2005

Re: Program with many errors

I'm not surprised you're getting errors. Aside from the odd choice of using so many loops where one will do, you fail to close most of your blocks. Compare this with what you have and do try to learn from it:

C++ Syntax (Toggle Plain Text)
#include <cstdlib>
#include <fstream>
#include <iostream>
#include <string>
 
using namespace std;
 
int main()
{
  ifstream in("somefile");
  string search;
  string line;
  int n = 0;
 
  if (!in) {
    cerr<<"Error opening file"<<endl;
    return EXIT_FAILURE;
  }
 
  cout<<"Enter a search string: ";
  if (!getline(cin, search)) {
    cerr<<"Invalid input"<<endl;
    return EXIT_FAILURE;
  }
 
  while (getline(in, line)) {
    if (line.find(search) == string::npos)
      ++n;
  }
 
  cout<< n <<" occurances of "<< search <<" were found"<<endl;
 
  return EXIT_SUCCESS;
}
#include <cstdlib>
#include <fstream>
#include <iostream>
#include <string>

using namespace std;

int main()
{
  ifstream in("somefile");
  string search;
  string line;
  int n = 0;

  if (!in) {
    cerr<<"Error opening file"<<endl;
    return EXIT_FAILURE;
  }

  cout<<"Enter a search string: ";
  if (!getline(cin, search)) {
    cerr<<"Invalid input"<<endl;
    return EXIT_FAILURE;
  }

  while (getline(in, line)) {
    if (line.find(search) == string::npos)
      ++n;
  }

  cout<< n <<" occurances of "<< search <<" were found"<<endl;

  return EXIT_SUCCESS;
}

Narue

Administrator

Reputation Points: 6442

Solved Threads: 1393

Bad Cop

Offline

11,807 posts
since Sep 2004

Permalink

Feb 21st, 2005

Re: Program with many errors

Thanks for your help, I really was stuck

jonnie83

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

24 posts
since Feb 2005

Permalink

Feb 24th, 2005

Re: Program with many errors

still having problems using the strings created in the marking scheme being searched for in the students file this is what i have got so far

#include <cstdlib>
#include <fstream>
#include <iostream>
#include <string>

using namespace std;
using std::cout;
using std::cin;
using std::ifstream;

int main()
{
string username; //Username that will be searched for

cout << "Marking Program"; //Start of program

cout << "Enter Students Username:"; //Get username off program user
cin >> username;

ifstream in("checkUserName.txt"); //Searching for students username
string search;
string line;
int n = 0;

if (!in) {
cerr<<"Username not found"<<endl; //If entered username not found display
return EXIT_FAILURE; //error message
}
else
if (in){
ifstream in(username.txt); //open students program
}

{ ifstream in("markScheme.txt"); //open the marking scheme file
if (!in){
cerr<<"Mark Scheme not found"<<endl; //If file not found display error
return EXIT_FAILURE;
}
}

if (!getline(cin, search)) {
!=++n;
}

while (getline(in, line)) {
if (line.find(search) == string::npos)
++n;
}

cout<< "students mark is"<<n<<"out of 10"<<endl;

return EXIT_SUCCESS;
}

jonnie83

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

24 posts
since Feb 2005

Permalink

Feb 24th, 2005

Re: Program with many errors

>still having problems
Can you be more specific?

Narue

Administrator

Reputation Points: 6442

Solved Threads: 1393

Bad Cop

Offline

11,807 posts
since Sep 2004

Permalink

Feb 24th, 2005

Re: Program with many errors

sorry forgot code tags

C++ Syntax (Toggle Plain Text)
#include <cstdlib>
#include <fstream>
#include <iostream>
#include <string>
 
using namespace std;
using std::cout;
using std::cin;
using std::ifstream;
 
int main()
{
	string username;						//Username that will be searched for
 
	cout << "Marking Program";				//Start of program
 
	cout << "Enter Students Username:";		//Get username off program user
	cin >> username;
 
	ifstream in("checkUserName.txt");		//Searching for students username
	string search;
	string line;
	int n = 0;
 
	if (!in) {
    cerr<<"Username not found"<<endl;		//If entered username not found display
    return EXIT_FAILURE;					//error message
	}
	else 
		if (in){
		ifstream in(username.txt);			//open students program
	}
 
 
 
 
	{ ifstream in("markScheme.txt");		//open the marking scheme file
	if (!in){
	cerr<<"Mark Scheme not found"<<endl;	//If file not found display error
	return EXIT_FAILURE;
	}
	}
 
 
 
    if (!getline(cin, search)) {
    !=++n;
  }
 
  while (getline(in, line)) {
    if (line.find(search) == string::npos)
      ++n;
  }
 
  cout<< "students mark is"<<n<<"out of 10"<<endl;
 
  return EXIT_SUCCESS;
}
#include <cstdlib>
#include <fstream>
#include <iostream>
#include <string>

using namespace std;
using std::cout;
using std::cin;
using std::ifstream;

int main()
{
	string username;						//Username that will be searched for
	
	cout << "Marking Program";				//Start of program

	cout << "Enter Students Username:";		//Get username off program user
	cin >> username;

	ifstream in("checkUserName.txt");		//Searching for students username
	string search;
	string line;
	int n = 0;

	if (!in) {
    cerr<<"Username not found"<<endl;		//If entered username not found display
    return EXIT_FAILURE;					//error message
	}
	else 
		if (in){
		ifstream in(username.txt);			//open students program
	}
	
	
	
	
	{ ifstream in("markScheme.txt");		//open the marking scheme file
	if (!in){
	cerr<<"Mark Scheme not found"<<endl;	//If file not found display error
	return EXIT_FAILURE;
	}
	}



    if (!getline(cin, search)) {
    !=++n;
  }

  while (getline(in, line)) {
    if (line.find(search) == string::npos)
      ++n;
  }

  cout<< "students mark is"<<n<<"out of 10"<<endl;

  return EXIT_SUCCESS;
}

jonnie83

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

24 posts
since Feb 2005

Permalink

Feb 24th, 2005

Re: Program with many errors

yeah what i want the program to do is use the strings i've created in the markScheme.txt to see if they are in the students file that I open. Does that make sense!

jonnie83

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

24 posts
since Feb 2005

Permalink

Feb 24th, 2005

Re: Program with many errors

It makes perfect sense. What I want to know is what the program you have is doing that fails to meet your expectations.

Narue

Administrator

Reputation Points: 6442

Solved Threads: 1393

Bad Cop

Offline

11,807 posts
since Sep 2004

Permalink

Feb 24th, 2005

Re: Program with many errors

Once a string is found (10 in total) i want it to increment the counter then output the final mark to the program user

jonnie83

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

24 posts
since Feb 2005

Page 1
2
Next

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: help with file streaming

Next Thread in C++ Forum Timeline: Help referencing variables

DaniWeb Message

Cancel Changes

User Name
Password