Ad:

C++ Discussion Thread
Unsolved
Views: 912

Apr 24th, 2009

if else statement ???? c++

Expand Post »

I`m trying to to use if statement but something going wrong.
statement must be 2 steps
IF There is still room in the array and
IF there is not an Appointmen on the same Date and Time!
Apointment will be accept......
im not getting any error or worning
but its not chaking second if statement and both else printing together

C++ Syntax (Toggle Plain Text)
void addAppointmenRecords( )
{  
	int number, i,k;
	system("cls");         //clear screen
		cout<<"\nHow many Appointmen you wish to add? ";
		cin>>number;		   //read number
		cin.get();            //read newline character left in the buffer
 
	if((number + currentSize ) <= listSize)        //There is still room in the array
	{
	  for( i = 1; i<=number; i++ )
           {
			cout<<"\nEnter Person name: ";
			getline(cin, AppointmenList[currentSize].name);
			cout<<"Enter Appointmen Descriptions: ";
			getline(cin, AppointmenList[currentSize].description);
			cout<<"Enter Appointmen date: ";
			cin>>AppointmenList[currentSize].appdate.day;
			cin>>AppointmenList[currentSize].appdate.mounth;
			cin>>AppointmenList[currentSize].appdate.year;
			cin.get();				//read a character
			cout<<"Enter Appointmen time: ";
            getline(cin, AppointmenList[currentSize].time);
			cout<<endl;
			currentSize += 1; //update CurrentSize
 
 
	for(k=0; k<currentSize; k++)  //chech if there an Appointmen on the same Date and Time!
if( AppointmenList[currentSize].appdate.day == AppointmenLis[k].appdate.day && 
AppointmenList[currentSize].appdate.mounth == AppointmenList[k].appdate.mounth && 
AppointmenList[currentSize].appdate.year == AppointmenList[k].appdate.year && 
AppointmenList[currentSize].time == AppointmenList[k].time )
			{
		        cout<<"\nGot a match\n";
				cout<<"Appointmen Date and Time already filled"<<endl;
				currentSize-=1;
	        }
			else
			{
				cout<<"Apointment accepted"<<endl;
				currentSize+=1;
			}
	  }
	}
			else
			{
				cout<<"Overflow!!!! Appointmen List is full"<<endl;
				cout<<"\nPress any key to continue"<<endl;
				cin.get();     //read a character
			}
}
void addAppointmenRecords( )
{  
	int number, i,k;
	system("cls");         //clear screen
		cout<<"\nHow many Appointmen you wish to add? ";
		cin>>number;		   //read number
		cin.get();            //read newline character left in the buffer

	if((number + currentSize ) <= listSize)        //There is still room in the array
	{
	  for( i = 1; i<=number; i++ )
           {
			cout<<"\nEnter Person name: ";
			getline(cin, AppointmenList[currentSize].name);
			cout<<"Enter Appointmen Descriptions: ";
			getline(cin, AppointmenList[currentSize].description);
			cout<<"Enter Appointmen date: ";
			cin>>AppointmenList[currentSize].appdate.day;
			cin>>AppointmenList[currentSize].appdate.mounth;
			cin>>AppointmenList[currentSize].appdate.year;
			cin.get();				//read a character
			cout<<"Enter Appointmen time: ";
            getline(cin, AppointmenList[currentSize].time);
			cout<<endl;
			currentSize += 1; //update CurrentSize
	  
			
	for(k=0; k<currentSize; k++)  //chech if there an Appointmen on the same Date and Time!
if( AppointmenList[currentSize].appdate.day == AppointmenLis[k].appdate.day && 
AppointmenList[currentSize].appdate.mounth == AppointmenList[k].appdate.mounth && 
AppointmenList[currentSize].appdate.year == AppointmenList[k].appdate.year && 
AppointmenList[currentSize].time == AppointmenList[k].time )
			{
		        cout<<"\nGot a match\n";
				cout<<"Appointmen Date and Time already filled"<<endl;
				currentSize-=1;
	        }
			else
			{
				cout<<"Apointment accepted"<<endl;
				currentSize+=1;
			}
	  }
	}
			else
			{
				cout<<"Overflow!!!! Appointmen List is full"<<endl;
				cout<<"\nPress any key to continue"<<endl;
				cin.get();     //read a character
			}
}

Similar Threads

MySQL LIKE statement in MySQL
missing return statement in Java
Switch Case Statement in Java
loop in main function to an "if" statement in C++
run sql statement in asp in ASP

pczafer

Reputation Points: 12

Solved Threads: 0

Light Poster

Offline

38 posts
since Apr 2009

Permalink

Apr 24th, 2009

Re: if else statement ???? c++

I don't get your question, can you please explain it in a way I can understand ?

By the way, If you've some additional time please format your code properly (using code tags was the first (and very good) step, formatting your code is the second one)

...

Edit:: Avoid using the system(); command (look here)...

Last edited by tux4life; Apr 24th, 2009 at 5:06 pm.

tux4life

Reputation Points: 2125

Solved Threads: 243

Postaholic

Offline

2,105 posts
since Feb 2009

Permalink

Apr 24th, 2009

Re: if else statement ???? c++

i used the tags for my codes
anyway
i was meaning i can still insert Appointmen on the same Date and Time. and printing

C++ Syntax (Toggle Plain Text)

"Apointment accepted"

and

C++ Syntax (Toggle Plain Text)

"Appointmen Date and Time already filled"

after every entry

pczafer

Reputation Points: 12

Solved Threads: 0

Light Poster

Offline

38 posts
since Apr 2009

Permalink

Apr 24th, 2009

Re: if else statement ???? c++

Please, make this terrible code refactoring as soon as possible:
1. Stop using of global variables immediately. Pass appointment list array, its capacity (max size) and a reference to the current free index as addAppointmentRecords arguments.
2. Use operator == for appdate structures instead of these awful member by member comparisons.
3. Use break statement after "already filled" message.
4. Make a proper indentation: it's impossible to read (and understand) this nightmare now...

Next time add main data structures definitions to the snippet. Use code tag with the language specifier (feel the difference):
[code=cplusplus]
source
[/code]

ArkM

Reputation Points: 1234

Solved Threads: 347

Postaholic

Offline

2,001 posts
since Jul 2008

Permalink

Apr 24th, 2009

Re: if else statement ???? c++

Wow that is just too painful to read. Curly brackets all over the place. Fix it up a bit please.

skatamatic

Reputation Points: 352

Solved Threads: 109

Master Poster

Offline

776 posts
since Nov 2007

Permalink

Apr 24th, 2009

Re: if else statement ???? c++

I think the curly brackets don't add up correctly you maybe missing some.

I would suggest indenting your code properley to make it more readable.

eg

C++ Syntax (Toggle Plain Text)
while(something)<blockquote>{</blockquote><blockquote><blockquote>if(somethingelse)</blockquote></blockquote><blockquote><blockquote><blockquote>{</blockquote></blockquote></blockquote><blockquote><blockquote><blockquote><blockquote>do something</blockquote></blockquote></blockquote></blockquote><blockquote><blockquote><blockquote>}</blockquote></blockquote></blockquote><blockquote>}</blockquote>
while(something)<blockquote>{</blockquote><blockquote><blockquote>if(somethingelse)</blockquote></blockquote><blockquote><blockquote><blockquote>{</blockquote></blockquote></blockquote><blockquote><blockquote><blockquote><blockquote>do something</blockquote></blockquote></blockquote></blockquote><blockquote><blockquote><blockquote>}</blockquote></blockquote></blockquote><blockquote>}</blockquote>

Without the extra lines in between.

Last edited by Xlphos; Apr 24th, 2009 at 8:31 pm.

Xlphos

Reputation Points: 32

Solved Threads: 116

Veteran Poster

Offline

1,073 posts
since Apr 2008

Permalink

Apr 25th, 2009

Re: if else statement ???? c++

sorry for my codes everyone im still biginer..
i used code=cplusplus
source
/code
but still looking a bit mess i hope its more readable now.

C++ Syntax (Toggle Plain Text)
void addAppointmenRecords( )
{
	system("cls");         //clear screen
	cout<<"\nHow many Appointmen you wish to add? ";
	cin>>number;		   //read number
	cin.get();            //read newline character left in the buffer
	if((number + currentSize ) <= listSize) //There is still room in the array
	{
	  for(int i = 1; i<=number; i++ )
                   {	
		cout<<"\nEnter Person name: ";
		getline(cin, AppointmenList[currentSize].name);
		cout<<"Enter Appointmen Descriptions: ";
		getline(cin, AppointmenList[currentSize].description);
		cout<<"Enter Appointmen date: ";
		cin>>AppointmenList[currentSize].appdate.day;
		cin>>AppointmenList[currentSize].appdate.mounth;
		cin>>AppointmenList[currentSize].appdate.year;
		cin.get();						//read a character
		cout<<"Enter Appointmen time: ";
                                getline(cin, AppointmenList[currentSize].time);
		cout<<endl;
		currentSize += 1; //update CurrentSize
		for(int k=0; k<currentSize; k++) //chech if there an Appointmen on the same Date and Time!
		if( AppointmenList[currentSize].appdate.day == AppointmenList[k].appdate.day && 
		AppointmenList[currentSize].appdate.mounth == AppointmenList[k].appdate.mounth && 
		AppointmenList[currentSize].appdate.year == AppointmenList[k].appdate.year && 
		AppointmenList[currentSize].time == AppointmenList[k].time )
		  {
		      cout<<"\nGot a match\n";
		      cout<<"Appointmen Date and Time already filled"<<endl;
		      currentSize-=1;
		      break;
		  }
		else
		  {
		     cout<<"Apointment accepted"<<endl;
		     currentSize+=1;
		  }
	  }
	}
		else
		   {
		      cout<<"Overflow!!!! Appointmen List is full"<<endl;
		      cout<<"\nPress any key to continue"<<endl;
		      cin.get();     //read a character
		   }
}
void addAppointmenRecords( )
{
	system("cls");         //clear screen
	cout<<"\nHow many Appointmen you wish to add? ";
	cin>>number;		   //read number
	cin.get();            //read newline character left in the buffer
	if((number + currentSize ) <= listSize) //There is still room in the array
	{
	  for(int i = 1; i<=number; i++ )
                   {	
		cout<<"\nEnter Person name: ";
		getline(cin, AppointmenList[currentSize].name);
		cout<<"Enter Appointmen Descriptions: ";
		getline(cin, AppointmenList[currentSize].description);
		cout<<"Enter Appointmen date: ";
		cin>>AppointmenList[currentSize].appdate.day;
		cin>>AppointmenList[currentSize].appdate.mounth;
		cin>>AppointmenList[currentSize].appdate.year;
		cin.get();						//read a character
		cout<<"Enter Appointmen time: ";
                                getline(cin, AppointmenList[currentSize].time);
		cout<<endl;
		currentSize += 1; //update CurrentSize
		for(int k=0; k<currentSize; k++) //chech if there an Appointmen on the same Date and Time!
		if( AppointmenList[currentSize].appdate.day == AppointmenList[k].appdate.day && 
		AppointmenList[currentSize].appdate.mounth == AppointmenList[k].appdate.mounth && 
		AppointmenList[currentSize].appdate.year == AppointmenList[k].appdate.year && 
		AppointmenList[currentSize].time == AppointmenList[k].time )
		  {
		      cout<<"\nGot a match\n";
		      cout<<"Appointmen Date and Time already filled"<<endl;
		      currentSize-=1;
		      break;
		  }
		else
		  {
		     cout<<"Apointment accepted"<<endl;
		     currentSize+=1;
		  }
	  }
	}
		else
		   {
		      cout<<"Overflow!!!! Appointmen List is full"<<endl;
		      cout<<"\nPress any key to continue"<<endl;
		      cin.get();     //read a character
		   }
}

pczafer

Reputation Points: 12

Solved Threads: 0

Light Poster

Offline

38 posts
since Apr 2009

Permalink

Apr 25th, 2009

Re: if else statement ???? c++

Have you tried putting curly brackets after the for loop on line 24?

for()

open with {

if()

open with{

do something

end if with }

end for with}

Xlphos

Reputation Points: 32

Solved Threads: 116

Veteran Poster

Offline

1,073 posts
since Apr 2008

Permalink

Apr 26th, 2009

Re: if else statement ???? c++

sorry for my codes i tryed to clean a bit more
its not checking

Quote ...

if there an Appointmen on the same Date and Time!

and printing

Quote ...

"Apointment accepted"

and

Quote ...

Got a match
Appointment Date and Time already filled

can anybody see mistakes now??????

C++ Syntax (Toggle Plain Text)
void addAppointmenRecords( )
{  
         int number, i,k;
	system("cls");       //clear screen
	cout<<"\nHow many Appointments do you wish to add? ";
	cin>>number;        //read number
	cin.get();            //read newline character left in the buffer
 
	if((number + currentSize ) <= listSize)//There is still room in the array
	 {
		for( i = 1; i<=number; i++ )
		 {
			cout<<"\nEnter Person name: ";
			getline(cin, AppointmenList[currentSize].name);
			cout<<"Enter Appointment Descriptions: ";
			getline(cin, AppointmenList[currentSize].description);
			cout<<"Enter Appointment date: ";
			cin>>AppointmenList[currentSize].appdate.day;
			cin>>AppointmenList[currentSize].appdate.mounth;
			cin>>AppointmenList[currentSize].appdate.year;
			cin.get();//read a character
			cout<<"Enter Appointment time: ";
			getline(cin, AppointmenList[currentSize].time);
			cout<<endl;
			currentSize += 1; //update CurrentSize
		     for(k=0; k<currentSize; k++)//check if there an Appointmen on the same Date and Time!
			 {
			   if(AppointmenList[currentSize].appdate.day == AppointmenList[k].appdate.day && 
			   AppointmenList[currentSize].appdate.mounth == AppointmenList[k].appdate.mounth && 
			   AppointmenList[currentSize].appdate.year == AppointmenList[k].appdate.year && 
			   AppointmenList[currentSize].time == AppointmenList[k].time )
				 {
					cout<<"\nGot a match\n";
					cout<<"Appointment Date and Time already filled"<<endl;
					currentSize-=1;
					break;
				 }
				else
				 {
					cout<<"Apointment accepted"<<endl;
					currentSize+=1;
				 }
			 }
		 }
	 }
	else
	 {
		cout<<"Overflow!!!! Appointment List is full"<<endl;
		cout<<"\nPress any key to continue"<<endl;
		cin.get();     //read a character
	 }
}
void addAppointmenRecords( )
{  
         int number, i,k;
	system("cls");       //clear screen
	cout<<"\nHow many Appointments do you wish to add? ";
	cin>>number;        //read number
	cin.get();            //read newline character left in the buffer

	if((number + currentSize ) <= listSize)//There is still room in the array
	 {
		for( i = 1; i<=number; i++ )
		 {
			cout<<"\nEnter Person name: ";
			getline(cin, AppointmenList[currentSize].name);
			cout<<"Enter Appointment Descriptions: ";
			getline(cin, AppointmenList[currentSize].description);
			cout<<"Enter Appointment date: ";
			cin>>AppointmenList[currentSize].appdate.day;
			cin>>AppointmenList[currentSize].appdate.mounth;
			cin>>AppointmenList[currentSize].appdate.year;
			cin.get();//read a character
			cout<<"Enter Appointment time: ";
			getline(cin, AppointmenList[currentSize].time);
			cout<<endl;
			currentSize += 1; //update CurrentSize
		     for(k=0; k<currentSize; k++)//check if there an Appointmen on the same Date and Time!
			 {
			   if(AppointmenList[currentSize].appdate.day == AppointmenList[k].appdate.day && 
			   AppointmenList[currentSize].appdate.mounth == AppointmenList[k].appdate.mounth && 
			   AppointmenList[currentSize].appdate.year == AppointmenList[k].appdate.year && 
			   AppointmenList[currentSize].time == AppointmenList[k].time )
				 {
					cout<<"\nGot a match\n";
					cout<<"Appointment Date and Time already filled"<<endl;
					currentSize-=1;
					break;
				 }
				else
				 {
					cout<<"Apointment accepted"<<endl;
					currentSize+=1;
				 }
			 }
		 }
	 }
	else
	 {
		cout<<"Overflow!!!! Appointment List is full"<<endl;
		cout<<"\nPress any key to continue"<<endl;
		cin.get();     //read a character
	 }
}

pczafer

Reputation Points: 12

Solved Threads: 0

Light Poster

Offline

38 posts
since Apr 2009

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: creating exe from program

Next Thread in C++ Forum Timeline: Adding Or Changing the Text Of Child Nodes in TreeView - Visual c++ 2008

DaniWeb Message

Cancel Changes

User Name
Password