Ad:

C++ Discussion Thread
Unsolved
Views: 923

Apr 24th, 2009

Using a sentinal controlled while loop

Expand Post »

I am creating a program to count the vowels and have run into a problem concerning my loop.

}#include <iostream>
#include <cmath>
#include <iomanip>

using namespace std;

bool isVowel(int num);

int main()
{
bool tof = false; //initializes tof bool to false
int vowels = 0;
char x;

cout << "Please enter a letter to see if it is a vowel" << endl << endl; // Asks the user to enter a letter

cin >> x;

tof = isVowel (x);

if (tof != 0){

}

system("PAUSE");
return 0;
}

bool isVowel(int num)

{

if ('A' == num || 'a' == num ||'E' == num || 'e' == num ||'I' == num ||'i' == num ||'O' == num || 'o' == num ||'U' == num || 'u' == num)
{
return true;

}

else return false;
}

Similar Threads

helllp with loops in C++

astonomer

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

1 posts
since Apr 2009

Permalink

Apr 24th, 2009

Re: Using a sentinal controlled while loop

We need code tags and more explanation.

nucleon

Reputation Points: 163

Solved Threads: 91

Posting Pro in Training

Offline

476 posts
since Oct 2008

Permalink

Apr 24th, 2009

Re: Using a sentinal controlled while loop

...and try to avoid comments like this

C++ Syntax (Toggle Plain Text)

a += 1; // add 1 to a

It's not old good Cobol language and your program readers are not (all) idiots (I hope

)...

ArkM

Reputation Points: 1234

Solved Threads: 347

Postaholic

Offline

2,001 posts
since Jul 2008

Permalink

Apr 24th, 2009

Re: Using a sentinal controlled while loop

I think the main problem with your loop is...you don't have a loop.

Also...when checking the value of a bool it is better practice to either compare it to a bool value or just the actual bool itself. Remember a condition (something that you supply an if statement with) IS a bool, so just the bool would suffice:

C++ Syntax (Toggle Plain Text)
if (isVowel(x))
{
    //do stuff
}
if (isVowel(x))
{
    //do stuff
}

You are also passing in a int to your function, when I'm pretty sure you meant to pass a char. Not that there's a real difference in the storage of it, there is in the functionality of it. And another tip; to avoid having to use both upper and lower case validation, you could just make use of the tolower() function:

C++ Syntax (Toggle Plain Text)
bool isVowel(char cX)
{
cX = tolower(cX);
return (cX == 'a' || cX == 'e' || cX == 'i' || cX == 'o' || cX == 'u');
}
bool isVowel(char cX)
{
cX = tolower(cX);
return (cX == 'a' || cX == 'e' || cX == 'i' || cX == 'o' || cX == 'u');
}

Last edited by skatamatic; Apr 24th, 2009 at 7:53 pm. Reason: More info added

skatamatic

Reputation Points: 352

Solved Threads: 109

Master Poster

Offline

780 posts
since Nov 2007

Permalink

Apr 24th, 2009

Re: Using a sentinal controlled while loop

Simple sentinel loop:

C++ Syntax (Toggle Plain Text)
cin >> x;
while (cin.fail() || cin.rdbuf()->in_avail() > 2)
{
    cin.ignore(cin.rdbuf()->in_avail());
    cin.clear();
    cout << "Invalid input\n";
    cin >> x;
}
cin >> x;
while (cin.fail() || cin.rdbuf()->in_avail() > 2)
{
    cin.ignore(cin.rdbuf()->in_avail());
    cin.clear();
    cout << "Invalid input\n";
    cin >> x;
}

Last edited by skatamatic; Apr 24th, 2009 at 7:57 pm.

skatamatic

Reputation Points: 352

Solved Threads: 109

Master Poster

Offline

780 posts
since Nov 2007

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: check if int is actually an int

Next Thread in C++ Forum Timeline: graphics project about drawing circle in C++

DaniWeb Message

Cancel Changes

User Name
Password