Ad:

C++ Discussion Thread
Unsolved
Views: 573

Jun 16th, 2009

Header file not loading

Expand Post »

Hi, I have another question. This one is about header files. I have a header for a player and the opponent of my battleship game. They way I have it set up, the opponent needs a player object to make a move, and vise versa. This is what i have.

Opponent Header:

C++ Syntax (Toggle Plain Text)
/* 
 * File:   opponent.h
 * Author: Neil
 *
 * Created on June 16, 2009, 4:25 PM
 */
 
#ifndef _OPPONENT_H
#define	_OPPONENT_H
 
#include "ship.h"
#include "field.h"
#include "player.h"
#include <vector>
#include <iostream>
 
class opponent {
public:
    opponent();
    opponent(const opponent& orig);
    virtual ~opponent();
 
    void placeShips();
    void makeMove(player p);
    bool takeHit(int x, int y);
    void storeShips(std::vector<Ship> ships){this->ships=ships;}
    std::vector<Ship> getShips(){return ships;}
 
private:
    std::vector<Ship> ships;
    Field shipArea;
    Field guessArea;
};
 
#endif	/* _OPPONENT_H */
/* 
 * File:   opponent.h
 * Author: Neil
 *
 * Created on June 16, 2009, 4:25 PM
 */

#ifndef _OPPONENT_H
#define	_OPPONENT_H

#include "ship.h"
#include "field.h"
#include "player.h"
#include <vector>
#include <iostream>

class opponent {
public:
    opponent();
    opponent(const opponent& orig);
    virtual ~opponent();

    void placeShips();
    void makeMove(player p);
    bool takeHit(int x, int y);
    void storeShips(std::vector<Ship> ships){this->ships=ships;}
    std::vector<Ship> getShips(){return ships;}

private:
    std::vector<Ship> ships;
    Field shipArea;
    Field guessArea;
};

#endif	/* _OPPONENT_H */

Player Header:

C++ Syntax (Toggle Plain Text)
/* 
 * File:   player.h
 * Author: Neil
 *
 * Created on June 16, 2009, 5:10 PM
 */
 
#ifndef _PLAYER_H
#define	_PLAYER_H
 
#include "opponent.h"
#include "ship.h"
#include "field.h"
#include <vector>
#include <iostream>
 
class player {
public:
    player();
    player(const player& orig);
    virtual ~player();
 
    void placeShips();
    void makeMove(opponent o);
    bool takeHit(int x, int y);
    void printFields();
    void storeShips(std::vector<Ship> ships){this->ships=ships;}
    std::vector<Ship> getShips(){return ships;}
    void updateShipField();
    void updateGuessField(int x, int y);
 
private:
    std::vector<Ship> ships;
    Field shipArea;
    Field guessArea;
};
 
#endif	/* _PLAYER_H */
/* 
 * File:   player.h
 * Author: Neil
 *
 * Created on June 16, 2009, 5:10 PM
 */

#ifndef _PLAYER_H
#define	_PLAYER_H

#include "opponent.h"
#include "ship.h"
#include "field.h"
#include <vector>
#include <iostream>

class player {
public:
    player();
    player(const player& orig);
    virtual ~player();

    void placeShips();
    void makeMove(opponent o);
    bool takeHit(int x, int y);
    void printFields();
    void storeShips(std::vector<Ship> ships){this->ships=ships;}
    std::vector<Ship> getShips(){return ships;}
    void updateShipField();
    void updateGuessField(int x, int y);

private:
    std::vector<Ship> ships;
    Field shipArea;
    Field guessArea;
};

#endif	/* _PLAYER_H */

And this is the error I'm getting:

C++ Syntax (Toggle Plain Text)
In file included from opponent.h:13,
                 from opponent.cpp:9:
player.h:24: error: `opponent' has not been declared
player.h:24: error: ISO C++ forbids declaration of `o' with no type
In file included from opponent.h:13,
                 from opponent.cpp:9:
player.h:24: error: `opponent' has not been declared
player.h:24: error: ISO C++ forbids declaration of `o' with no type

Similar Threads

llemes4011

Reputation Points: 41

Solved Threads: 13

Posting Whiz in Training

Offline

224 posts
since Aug 2008

Permalink

Jun 16th, 2009

Re: Header file not loading

First of all, get those #includes out of inside those #ifndef's

Your problem is your C file includes the opponent.h file first, which in turn includes player, before the opponent class is even defined.

As a work around include
class opponent;

Above the class player declaration.

This is typically used for cross-dependent header files!

But in implementation of classes, one should keep in mind dependendencies of classes, etc. If you need a cross-dependency, then typically your object data needs reorganization in a layering of dependencies. Like a stack of pancakes, dependencies are always upwards!

wildgoose

Reputation Points: 546

Solved Threads: 99

Practically a Posting Shark

Offline

891 posts
since Jun 2009

Permalink

Jun 16th, 2009

Re: Header file not loading

What wildgoose gives as a solution is called a "forward declaration", so you can read up about it (where what why how etc.)

And yes, Pancake stacks are most of the time FILO ones. xD

Last edited by Clockowl; Jun 16th, 2009 at 9:13 pm.

Clockowl

Reputation Points: 69

Solved Threads: 28

Posting Whiz

Offline

376 posts
since May 2008

Permalink

Jun 16th, 2009

Re: Header file not loading

Thanks for the help =] I'm still new to C++, so the header files and such still kind of confuse me, but I think im starting to get the hang of it!

llemes4011

Reputation Points: 41

Solved Threads: 13

Posting Whiz in Training

Offline

224 posts
since Aug 2008

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: Search a word, return the line

Next Thread in C++ Forum Timeline: trying to make a display function using level-order traversal

DaniWeb Message

Cancel Changes

User Name
Password