list iterator not dereferencable

Expand Post »

The following is a function that compiles just fine, but when I run it, I get a "Debug Assertion Failed" and it says "list iterator not dereferencable". As far as I can tell the error occurs at whileIter++. I've looked at examples of iterators and how they are used, and can't figure out what I'm doing wrong.

C++ Syntax (Toggle Plain Text)
CString findImage(CString fileName, list<record> csvFile)
{
	std::list<record> tmpCsvFile = csvFile;
	std::list<record>::iterator tmpIterator = tmpCsvFile.begin();
	list<record>::iterator whileIter = tmpCsvFile.begin();
fileName = fileName+".txt";
 
		while (whileIter != tmpCsvFile.end())
		{
		      whileIter++;
		if (fileName == (whileIter->fileName).c_str())
			break;
 
		}
 
return whileIter->characters.c_str();
}
CString findImage(CString fileName, list<record> csvFile)
{
	std::list<record> tmpCsvFile = csvFile;
	std::list<record>::iterator tmpIterator = tmpCsvFile.begin();
	list<record>::iterator whileIter = tmpCsvFile.begin();
fileName = fileName+".txt";
		
		while (whileIter != tmpCsvFile.end())
		{
		      whileIter++;
		if (fileName == (whileIter->fileName).c_str())
			break;
			
		}
		
return whileIter->characters.c_str();
}

Basically there is a list of records ( a struct with a few members, one of which is fileName). The function should compare the fileName in each record of the list, with the fileName that was passed as a parameter to the function in the hope of finding two that are equal.

Thanks in advance

Similar Threads

Double linked List Iterator InsertAfter Function in C++
Implementing Linked List iterator, gcc is acting wierd in C++
Use of Iterator to access/ Search STD List ..need help! in C++
Radio Button and List in JSP
Use of Iterator in Java

Natique

Reputation Points: 11

Solved Threads: 0

Light Poster

Offline

28 posts
since Feb 2008

Permalink

Sep 30th, 2009

Re: list iterator not dereferencable

Your problem is inside the while loop.

c++ Syntax (Toggle Plain Text)
		while (whileIter != tmpCsvFile.end())
		{
		      whileIter++;
		if (fileName == (whileIter->fileName).c_str())
			break;
 
		}
		while (whileIter != tmpCsvFile.end())
		{
		      whileIter++;
		if (fileName == (whileIter->fileName).c_str())
			break;
			
		}

You have advanced the iterator (possibly to the end) before you try to test the filename. Put the fileName test (with the break) before the iterator advancement.

Murtan

Reputation Points: 344

Solved Threads: 116

Practically a Master Poster

Offline

670 posts
since May 2008

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: Help With this program

Next Thread in C++ Forum Timeline: Classes and Linked Nodes

DaniWeb Message

Cancel Changes

User Name
Password