Update element in list

Expand Post »

Hey guys,

Can anyone post sample code about updating an object that is already in an std::list? I know that it sounds as a really stupid question, but obviously I'm doing something wrong.

In my code I'm going through the list with an iterator until I reach the object of interest. My intention is to replace the current node in the list with another object.

The following snippet of code demonstrates that but I'm sure that I do something wrong in the if statement.

Thanks in advance..!

c++ Syntax (Toggle Plain Text)
bool updateListElement(Object* air)
{
     list <Object>::iterator iObject;
     for (iObject= list.begin(); iObject != list.end(); ++iObject)
     {
        Object temp = *iObject;
        if (temp.getCode() == air->getCode())
        {
            temp=*air;
            return true;
        }
     }
     return false;
}
bool updateListElement(Object* air)
{
     list <Object>::iterator iObject;
     for (iObject= list.begin(); iObject != list.end(); ++iObject)
     {
        Object temp = *iObject;
        if (temp.getCode() == air->getCode())
        {
            temp=*air;
            return true;
        }
     }
     return false;
}

Similar Threads

return each element of a list in Python
How to check element of list are present in other list? in Python
link list with copy and delete elements in C++
deleting an element in a linked list in C++
Minimal element in a linked list? in Computer Science

eliza2044

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

22 posts
since May 2009

Permalink

Oct 22nd, 2009

Re: Update element in list

Close, but a temporary copy of the object is still an independent copy. C++ does not make reference copies of objects like Java or C#. To replace the object the iterator refers to, you need to assign to the dereferenced iterator. This will overwrite the object that it refers to:

C++ Syntax (Toggle Plain Text)
bool updateListElement(Object* air)
{
    std::list <Object>::iterator iObject;
     for (iObject= list.begin(); iObject != list.end(); ++iObject)
     {
        Object temp = *iObject;
        if (temp.getCode() == air->getCode())
        {
            *iObject = *air;
            return true;
        }
     }
     return false;
}
bool updateListElement(Object* air)
{
    std::list <Object>::iterator iObject;
     for (iObject= list.begin(); iObject != list.end(); ++iObject)
     {
        Object temp = *iObject;
        if (temp.getCode() == air->getCode())
        {
            *iObject = *air;
            return true;
        }
     }
     return false;
}

Tom Gunn

Reputation Points: 1446

Solved Threads: 135

Practically a Master Poster

Offline

681 posts
since Jun 2009

Permalink

Oct 22nd, 2009

Re: Update element in list

Thank you very much... I was trying to figure out what was wrong and never thought I had to do it that way!!!

Well thanks, I need to keep that in mind with C++....!!!!

eliza2044

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

22 posts
since May 2009

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: Object's value turn into -858993460?

Next Thread in C++ Forum Timeline: Sorting

DaniWeb Message

Cancel Changes

User Name
Password