Character Arrays

Expand Post »

Im trying to create a simple RLC program. Im n ot sure the best way about it, but im trying to to use to 20 character arrays. One to read in the characters to be compressed (buffer) and the other is used to as a check. Either way, the buffer[20] reads in from a file and is fine, but other array (outputs[20]) does not read anything in, so when i set the first element of outputs[0] = buffer[0], i get the first letter of buffer, followed by a gibberish, which throws off all calculations. Code is below:

C++ Syntax (Toggle Plain Text)
int Readchar(ifstream& fileread)
{
    char buffer[20];
    char temp;
    int space, count, length;
    count = 0;
    cout << fileread.peek() << endl;
    while (fileread.peek() != EOF)
    {
         fileread >> buffer;
         Checkbuffer(buffer);
         count ++;  
    }
    return 0;
}
 
 
int Checkbuffer(char buffer[])
{
    char outputs[20];
    int k, length, count, adj;
    adj = 0;
    count = 0;
    length = strlen(buffer);
    outputs[0] = buffer[0];
    cout << outputs;   
    for (k = 1; k <= length; k++)
    {
        if (buffer[k] == outputs[k-1])
        {
            outputs[k] = buffer[k];
        }
        else
        {
            Outputstring(outputs,k);
        }             
    }
    return 0;
}
int Readchar(ifstream& fileread)
{
    char buffer[20];
    char temp;
    int space, count, length;
    count = 0;
    cout << fileread.peek() << endl;
    while (fileread.peek() != EOF)
    {
         fileread >> buffer;
         Checkbuffer(buffer);
         count ++;  
    }
    return 0;
}


int Checkbuffer(char buffer[])
{
    char outputs[20];
    int k, length, count, adj;
    adj = 0;
    count = 0;
    length = strlen(buffer);
    outputs[0] = buffer[0];
    cout << outputs;   
    for (k = 1; k <= length; k++)
    {
        if (buffer[k] == outputs[k-1])
        {
            outputs[k] = buffer[k];
        }
        else
        {
            Outputstring(outputs,k);
        }             
    }
    return 0;
}

If anyone can suggest how to empty outputs[20] so it contains nothing, it would be appreciated.
Regards
Kevin

Last edited by Dave Sinkula; Dec 4th, 2005 at 2:08 pm. Reason: Added [code][/code] tags.

Similar Threads

Can arrays be sent to functions in C? in C
Problems with cin (char arrays|strings) in C++
Please help me with arrays in C++
Problem with Character Arrays in C++
Sorting character arrays! in C++

kdw3

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

15 posts
since Oct 2005

Permalink

Dec 4th, 2005

Re: Character Arrays

cout << buffer -- buffer needs to be a null-terminated character array. when you defined buffer you did not initialize it to anything, that means it contains random characters and the buffer may or may not contain a null-terminating 0. So cout just keeps displaying characters searching all memory for the first 0, which may be considerably beyond the end of the buffer.

To avoid that problem, declare buffer like this

(Toggle Plain Text)

 char buffer[20]  = 0;

That will fill the buffer with all 0s.

Ancient Dragon

Sponsor

Team Colleague

Featured Poster

Reputation Points: 5608

Solved Threads: 2282

Retired and Enjoying Life

Online

21,953 posts
since Aug 2005

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: returning a value from a header file

Next Thread in C++ Forum Timeline: Cryptology

DaniWeb Message

Cancel Changes

User Name
Password