Ad:

C++ Discussion Thread
Unsolved
Views: 2157

Page 1
2
Next

You are currently viewing page 1 of this multi-page discussion thread

Dec 22nd, 2005

File array question

Expand Post »

Hey guys,

I have the following code, but for some reason it does not work with bigger txt files is this because of the size of the array?

And if so is there a simple way to solve the problem?

Thanks in advance for any help.

C++ Syntax (Toggle Plain Text)
char ch[1000];
int v_word = 0;
int c_word = 0;
ifstream file("c:/test.txt");
 
   if (file.is_open()) 
     {
	while (file.getline(ch, 1000))
		if(strcmp(ch, "int") == 0)
		  v_word++;
 
     }
 
cout<<v_word<<endl;
cout<<c_word<<endl;
file.close();
char ch[1000];
int v_word = 0;
int c_word = 0;
ifstream file("c:/test.txt");

   if (file.is_open()) 
     {
	while (file.getline(ch, 1000))
		if(strcmp(ch, "int") == 0)
		  v_word++;
		
     }
	
cout<<v_word<<endl;
cout<<c_word<<endl;
file.close();

Similar Threads

reading txt file into array in C++
input data from a file into an Array in C
reading from file into array in C++
Help Reading Info in Text File Into an Array in C++

Jon182

Reputation Points: 10

Solved Threads: 0

Junior Poster in Training

Offline

91 posts
since Jul 2005

Permalink

Dec 22nd, 2005

Re: File array question

it should work with text files of any size. Are any lines longer than 1,000 bytes? What is the purpose of checking if one of the lines = "int" ? Is there anything else following "int" on that line?

This is a c++ program -- why don't you use std::string instead of c-style arrays?

C++ Syntax (Toggle Plain Text)
#include <string>
...
std::string line;
int v_word = 0;
int c_word = 0;
int spot;
ifstream file("c:/test.txt");
 
   if (file.is_open()) 
     {
	while (getline(fin,line) )
		if( (spot = line.find("int")) >= 0)
		  v_word++;
     }
#include <string>
...
std::string line;
int v_word = 0;
int c_word = 0;
int spot;
ifstream file("c:/test.txt");

   if (file.is_open()) 
     {
	while (getline(fin,line) )
		if( (spot = line.find("int")) >= 0)
		  v_word++;
     }

Ancient Dragon

Sponsor

Team Colleague

Featured Poster

Reputation Points: 5608

Solved Threads: 2282

Retired and Enjoying Life

Offline

21,954 posts
since Aug 2005

Permalink

Dec 22nd, 2005

Re: File array question

Hi thanks for your reply, The purpose of the int was just so i could count how many times it appears in the file it my full version also searches for other words. Could this be why it doesn't work on larger files?
I will look into strings.

Jon182

Reputation Points: 10

Solved Threads: 0

Junior Poster in Training

Offline

91 posts
since Jul 2005

Permalink

Dec 22nd, 2005

Re: File array question

what do you mean by "it doesn't work"? what doesn't work? strcmp() compares the entire line with the text you put in literals, in your example it is "int". So if the line is "int some more stuff here", then strcmp() will fail. If you only want the first three characters, the use strncmp(), or if "int" can appear anywhere in the line use strstr(). Also you have to be careful with the comparison because strstr() will also find "intabc" is the same as "abcintabc" and " int ". So if strstr() finds the text "int" the program should check for space character immediately before and after. If there is no white space before and after, then strstr() did not find a word.

Ancient Dragon

Sponsor

Team Colleague

Featured Poster

Reputation Points: 5608

Solved Threads: 2282

Retired and Enjoying Life

Offline

21,954 posts
since Aug 2005

Permalink

Dec 22nd, 2005

Re: File array question

Hi thanks for your reply. I have tried to use strstr() but I keep getting the wrong word count.

For example all the txt file contains is "hello james" and it gives the count 0 for both words.

C++ Syntax (Toggle Plain Text)
	ifstream file("c:\\test.txt");
 
	if (file.is_open()) {
		while (file.getline(ch, 10000))
		{
			if(strstr(ch, "hello") == 0)
				v_word++;
 
			if(strstr(ch, "james") == 0)
				c_word++;
		}
	}
	ifstream file("c:\\test.txt");

	if (file.is_open()) {
		while (file.getline(ch, 10000))
		{
			if(strstr(ch, "hello") == 0)
				v_word++;

			if(strstr(ch, "james") == 0)
				c_word++;
		}
	}

Jon182

Reputation Points: 10

Solved Threads: 0

Junior Poster in Training

Offline

91 posts
since Jul 2005

Permalink

Dec 22nd, 2005

Re: File array question

C++ Syntax (Toggle Plain Text)
if(strstr(ch, "hello") == 0)
if(strstr(ch, "hello") == 0)

The return value of strstr is a pointer to the match or a NULL pointer when no match was found. Here you are checking for a NULL pointer, meaning when no match was found, so you would be incrementing your counter at the wrong time.

Try this to find at least one occurence per line.

C++ Syntax (Toggle Plain Text)
if(strstr(ch, "hello") != 0)
if(strstr(ch, "hello") != 0)

Dave Sinkula

Team Colleague

Reputation Points: 2780

Solved Threads: 312

long time no c

Offline

4,790 posts
since Apr 2004

Permalink

Dec 22nd, 2005

Re: File array question

Hi Dave, Thank you for your reply.

Is what you said also true for the strcmp() function?

Thanks.

Jon182

Reputation Points: 10

Solved Threads: 0

Junior Poster in Training

Offline

91 posts
since Jul 2005

Permalink

Dec 22nd, 2005

Re: File array question

strcmp() return 0 if the comparison succeed, or non-zero if it fails.

Ancient Dragon

Sponsor

Team Colleague

Featured Poster

Reputation Points: 5608

Solved Threads: 2282

Retired and Enjoying Life

Offline

21,954 posts
since Aug 2005

Permalink

Dec 22nd, 2005

Re: File array question

That what I thought but when I was tesing it if I used the code:

C++ Syntax (Toggle Plain Text)
if(strcmp(ch, "hello") == 0)
if(strcmp(ch, "hello") == 0)

I got the wrong number of times the word occured.

but if I used the following code for strcmp()

C++ Syntax (Toggle Plain Text)
if(strcmp(ch, "hello") != 0)
if(strcmp(ch, "hello") != 0)

it works. But with strcmp() shouldn't it have worked with the first piece of code?

Jon182

Reputation Points: 10

Solved Threads: 0

Junior Poster in Training

Offline

91 posts
since Jul 2005

Permalink

Dec 22nd, 2005

Re: File array question

If the whole line is just "hello", then doing a strcmp against "hello" will be 0. Otherwise it won't be ("hello james" is not the same as "hello").

Even with strstr, you may want to move down the string after a match. Consider an input file like this:

C++ Syntax (Toggle Plain Text)

hello james hello james hello hello hello james james hello james

C++ Syntax (Toggle Plain Text)
#include <iostream>
#include <fstream>
#include <cstring>
using namespace std;
 
int main()
{
   char ch[1000];
   int v_word = 0;
   int c_word = 0;
   ifstream file("test.txt");
 
   if ( file.is_open() )
   {
      while ( file.getline(ch, 10000) )
      {
         char *match = ch;
         cout << "ch : " << ch << '\n';
         while ( (match = strstr(match, "hello")) != 0 )
         {
            cout << "<<hello>> " << match << '\n';
            v_word++;
            match += 5; /* the length of "hello" */
         }
 
         match = ch;
         while ( (match = strstr(match, "james")) != 0 )
         {
            cout << "<<james>> " << match << '\n';
            c_word++;
            match += 5; /* the length of "james" */
         }
      }
   }
 
   cout<<v_word<<endl;
   cout<<c_word<<endl;
   file.close();
   return 0;
}
 
/* my output
ch : hello james hello james hello hello hello james james hello james
<<hello>> hello james hello james hello hello hello james james hello james
<<hello>> hello james hello hello hello james james hello james
<<hello>> hello hello hello james james hello james
<<hello>> hello hello james james hello james
<<hello>> hello james james hello james
<<hello>> hello james
<<james>> james hello james hello hello hello james james hello james
<<james>> james hello hello hello james james hello james
<<james>> james james hello james
<<james>> james hello james
<<james>> james
6
5
*/
#include <iostream>
#include <fstream>
#include <cstring>
using namespace std;

int main()
{
   char ch[1000];
   int v_word = 0;
   int c_word = 0;
   ifstream file("test.txt");

   if ( file.is_open() )
   {
      while ( file.getline(ch, 10000) )
      {
         char *match = ch;
         cout << "ch : " << ch << '\n';
         while ( (match = strstr(match, "hello")) != 0 )
         {
            cout << "<<hello>> " << match << '\n';
            v_word++;
            match += 5; /* the length of "hello" */
         }

         match = ch;
         while ( (match = strstr(match, "james")) != 0 )
         {
            cout << "<<james>> " << match << '\n';
            c_word++;
            match += 5; /* the length of "james" */
         }
      }
   }

   cout<<v_word<<endl;
   cout<<c_word<<endl;
   file.close();
   return 0;
}

/* my output
ch : hello james hello james hello hello hello james james hello james
<<hello>> hello james hello james hello hello hello james james hello james
<<hello>> hello james hello hello hello james james hello james
<<hello>> hello hello hello james james hello james
<<hello>> hello hello james james hello james
<<hello>> hello james james hello james
<<hello>> hello james
<<james>> james hello james hello hello hello james james hello james
<<james>> james hello hello hello james james hello james
<<james>> james james hello james
<<james>> james hello james
<<james>> james
6
5
*/

Dave Sinkula

Team Colleague

Reputation Points: 2780

Solved Threads: 312

long time no c

Offline

4,790 posts
since Apr 2004

Page 1
2
Next

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: Win32 - Controls on main window

Next Thread in C++ Forum Timeline: vector<string> - way to find longest string?

DaniWeb Message

Cancel Changes

User Name
Password