Ad:

C++ Discussion Thread
Unsolved
Views: 3528

Mar 1st, 2006

(Noob) need some help w/ Prime Numbers

Expand Post »

I know there are tons of posts on this, I think I'm on the right track with this, but I can't quite get it to work. I can't figure out how to get the range of primes to print. I'd appreciate any input I can get, sorry about the indenting.

main() keeps doing the following, until user enters a 0 or a negative number:
• Ask user to enter a number;
• If it is positive, print all the prime numbers between 1 and it; when there’s no prime number, print “none�?; ( A prime number is a whole number that can only be divided by 1 and itself, i.e., 2, 3, 5, 7, 11, 13, 17, 23, ….)
• Print the max of these prime numbers; or print “none�? when there’s no prime.

The calling relation should be: main() calls printPrimes() and getMaxPrime();
printPrimes() and getMaxPrime() calls isPrime() .

My Code:

C++ Syntax (Toggle Plain Text)
#include <iostream>
#include <math.h>
using namespace std;
 
 
/* function isPrime (int num) finds out whether the input integer num is a prime number or not
*/
bool isPrime (int num)
{	
	for (int fac = 2; fac <= num; fac++)	
		if (num % fac == 0) return 0;
	return 1;	
}
 
 
 
 
/* function printPrimes (int num) prints all the prime numbers between 1 and num
*/
void printPrimes (int num)
{
	int number = 1;
	while(number <= num)
	{
		++number;
		if (isPrime(number))
			cout << number<<" ";
	}	
}
 
 
 
 
/* function getMaxPrime(int num) returns the greatest prime number between 1 and num. if there is no prime number between 1 and num, getMaxPrime() should return a 0.
*/
int getMaxPrime (int num)
{
	int maxCount = 0;
	for (int count = 1; count <= num; count++)
	{
		if (isPrime(count))
			maxCount = count;
	}		
	return int (maxCount);		
}
 
 
 
 
int main ()
{
	int number;
 
	do
	{
		cout 	<<endl<<endl 
				<<"Please enter a number, 0 or negative to stop :";
		cin >> number;
		if (number > 0)
		{
			cout << "All the prime numbers between 1 and "<< number<<" are: "<< endl;
			printPrimes(number);
			cout << "The max prime is :" ;
			int maxPrime = getMaxPrime(number);
			if (maxPrime==0) cout <<"none.";
			else cout << maxPrime;
		}
	} while (number>0);
	return 0;
}
#include <iostream>
#include <math.h>
using namespace std;


/* function isPrime (int num) finds out whether the input integer num is a prime number or not
*/
bool isPrime (int num)
{	
	for (int fac = 2; fac <= num; fac++)	
		if (num % fac == 0) return 0;
	return 1;	
}




/* function printPrimes (int num) prints all the prime numbers between 1 and num
*/
void printPrimes (int num)
{
	int number = 1;
	while(number <= num)
	{
		++number;
		if (isPrime(number))
			cout << number<<" ";
	}	
}




/* function getMaxPrime(int num) returns the greatest prime number between 1 and num. if there is no prime number between 1 and num, getMaxPrime() should return a 0.
*/
int getMaxPrime (int num)
{
	int maxCount = 0;
	for (int count = 1; count <= num; count++)
	{
		if (isPrime(count))
			maxCount = count;
	}		
	return int (maxCount);		
}




int main ()
{
	int number;
	
	do
	{
		cout 	<<endl<<endl 
				<<"Please enter a number, 0 or negative to stop :";
		cin >> number;
		if (number > 0)
		{
			cout << "All the prime numbers between 1 and "<< number<<" are: "<< endl;
			printPrimes(number);
			cout << "The max prime is :" ;
			int maxPrime = getMaxPrime(number);
			if (maxPrime==0) cout <<"none.";
			else cout << maxPrime;
		}
	} while (number>0);
	return 0;
}

Attached Files

lab3work.cpp (1.5 KB, 23 views)

Similar Threads

prime numbers in C++
Prime Numbers in C
prime numbers homework trouble in C++
help with array that determines prime numbers in C
prime numbers in C++

coopedw

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

3 posts
since Mar 2006

Permalink

Mar 1st, 2006

Re: (Noob) need some help w/ Prime Numbers

i'm not sure if I understood the problem but try to replace

C++ Syntax (Toggle Plain Text)
if (num % fac == 0)
if (num % fac == 0)

with

C++ Syntax (Toggle Plain Text)
if ((num % fac == 0) && (num != fac))
if ((num % fac == 0) && (num != fac))

and use this

C++ Syntax (Toggle Plain Text)
void printPrimes (int num)
{
	int number = 2;
	while(number <= num)
	{
 
		if (isPrime(number))
			cout << number<<" ";
		++number;
	}	
}
void printPrimes (int num)
{
	int number = 2;
	while(number <= num)
	{
		
		if (isPrime(number))
			cout << number<<" ";
		++number;
	}	
}

instead your printPrimes
I didn't had the time to test it

andor

Reputation Points: 251

Solved Threads: 29

Posting Whiz in Training

Offline

274 posts
since Jun 2005

Permalink

Mar 1st, 2006

Re: (Noob) need some help w/ Prime Numbers

if you want between 1 and num (num not included) than

C++ Syntax (Toggle Plain Text)
/* lab3.cpp  Working with Functions
*/
 
#include <iostream>
#include <math.h>
using namespace std;
 
 
/* function isPrime (int num) finds out whether the input integer num is a prime number or not.
	If num is a prime, return true; else return false;
   A prime number is a number whose only factors are 1 and itself.
	Note: 0 and 1 are not prime numbers. The minimal prime number is 2.
 
*/
bool isPrime (int num)
{	
	for (int fac = 2; fac <= num; fac++)	
		if ((num % fac == 0) && (num != fac))
			return 0;
	return 1;	
}
 
 
 
 
/* function printPrimes (int num) prints all the prime numbers between 1 and num
*/
void printPrimes (int num)
{
	int number = 2;
	while(number < num)
	{
 
		if (isPrime(number))
			cout << number<<" ";
		++number;
	}	
}
 
 
 
 
/* function getMaxPrime(int num) returns the greatest prime number between 1 and num.
	if there is no prime number between 1 and num, getMaxPrime() should return a 0.
*/
int getMaxPrime (int num)
{
	int maxCount = 0;
	for (int count = 1; count < num; count++)
	{
		if (isPrime(count))
			maxCount = count;
	}		
	return int (maxCount);		
}
 
 
 
 
int main ()
{
	int number;
 
	do
	{
		cout 	<<endl<<endl 
				<<"Please enter a number, 0 or negative to stop :";
		cin >> number;
		if (number > 0)
		{
			cout << "All the prime numbers between 1 and "<< number<<" are: "<< endl;
			printPrimes(number);
			cout << "The max prime is :" ;
			int maxPrime = getMaxPrime(number);
			if (maxPrime==0) cout <<"none.";
			else cout << maxPrime;
		}
	} while (number>0);
	return 0;
}
/* lab3.cpp  Working with Functions
*/

#include <iostream>
#include <math.h>
using namespace std;


/* function isPrime (int num) finds out whether the input integer num is a prime number or not.
	If num is a prime, return true; else return false;
   A prime number is a number whose only factors are 1 and itself.
	Note: 0 and 1 are not prime numbers. The minimal prime number is 2.

*/
bool isPrime (int num)
{	
	for (int fac = 2; fac <= num; fac++)	
		if ((num % fac == 0) && (num != fac))
			return 0;
	return 1;	
}




/* function printPrimes (int num) prints all the prime numbers between 1 and num
*/
void printPrimes (int num)
{
	int number = 2;
	while(number < num)
	{
		
		if (isPrime(number))
			cout << number<<" ";
		++number;
	}	
}




/* function getMaxPrime(int num) returns the greatest prime number between 1 and num.
	if there is no prime number between 1 and num, getMaxPrime() should return a 0.
*/
int getMaxPrime (int num)
{
	int maxCount = 0;
	for (int count = 1; count < num; count++)
	{
		if (isPrime(count))
			maxCount = count;
	}		
	return int (maxCount);		
}




int main ()
{
	int number;
	
	do
	{
		cout 	<<endl<<endl 
				<<"Please enter a number, 0 or negative to stop :";
		cin >> number;
		if (number > 0)
		{
			cout << "All the prime numbers between 1 and "<< number<<" are: "<< endl;
			printPrimes(number);
			cout << "The max prime is :" ;
			int maxPrime = getMaxPrime(number);
			if (maxPrime==0) cout <<"none.";
			else cout << maxPrime;
		}
	} while (number>0);
	return 0;
}

andor

Reputation Points: 251

Solved Threads: 29

Posting Whiz in Training

Offline

274 posts
since Jun 2005

Permalink

Mar 1st, 2006

Re: (Noob) need some help w/ Prime Numbers

I still can't get the printPrimes function to work. It doesn't output anything. and the getMaxPrime function returns 1. does anybody have any suggestions for this?

coopedw

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

3 posts
since Mar 2006

Permalink

Mar 2nd, 2006

Re: (Noob) need some help w/ Prime Numbers

Finally got it working. I thought I'd post the code in case someone else has the same problem

C++ Syntax (Toggle Plain Text)
#include <iostream>
 
   using namespace std;
 
 
/* function isPrime (int num) finds out whether the input integer num is a prime number or not.
	If num is a prime, return true; else return false;
   A prime number is a number whose only factors are 1 and itself.
	Note: 0 and 1 are not prime numbers. The minimal prime number is 2.
 
*/
    bool isPrime (int num)
   {
      bool primeCheck = true;   	         
      for (int fac = 2; fac < num; fac++ )//runs through factors between 2 and num
      {	
         if (num % fac == 0) //checks to see if a number is divisible
            primeCheck = false;
      }		
      return (primeCheck);	//returns true or false to calling functions printPrimes and getMaxPrime.
   }
 
/* function printPrimes (int num) prints all the prime numbers between 1 and num
*/
    void printPrimes (int num)
   {
      bool print;
      if (num <= 1)
   		cout << "none!"; // Determines if their are any primes in the range. 
 
      for (int count = 2; count <= num; count++ )
      {
         print = isPrime(count); //Creates "print" function to determine if a number is prime.
         if (print == true)
         {
            cout << count << ", "; // outputs prime number 
         }
      }	
   }
 
 
 
 
 
 
 
/* function getMaxPrime(int num) returns the greatest prime number between 1 and num.
	if there is no prime number between 1 and num, getMaxPrime() should return a 0.
*/
    int getMaxPrime (int num)
   {
      int maxPrime;
      int prime = 2;
      if (num <= 1) //sets maxPrime to "0" (none)
   	{
   		maxPrime = 0; 
   		prime = 0;
   	}
 
      do  //checks if a number is prime, sets maxPrime equal to found primes.
      {
         	bool check = isPrime(prime);
         	if (check == true)
            	maxPrime = prime; //sets maxPrime to last prime number found in range.
         	prime ++;
 
      }while (prime <= num);	
      return (maxPrime); // returns the value of maxPrime to main function		
   }
 
 
 
 
    int main ()
   {
      int number;
 
      do
      {
         cout 	<<endl<<endl 
            <<"Please enter a number, 0 or negative to stop :";
         cin >> number;
         if (number > 0)
         {
            cout << "All the prime numbers between 1 and "<< number<<" are:"<< endl;
            printPrimes(number);
            cout << endl;
            cout << "The max prime is :" ;
            int maxPrime = getMaxPrime( number );
            if (maxPrime<=1) cout <<"none.";
            else cout << maxPrime;
         }
      } while (number>0);
      return 0;
   }
#include <iostream>

   using namespace std;


/* function isPrime (int num) finds out whether the input integer num is a prime number or not.
	If num is a prime, return true; else return false;
   A prime number is a number whose only factors are 1 and itself.
	Note: 0 and 1 are not prime numbers. The minimal prime number is 2.

*/
    bool isPrime (int num)
   {
      bool primeCheck = true;   	         
      for (int fac = 2; fac < num; fac++ )//runs through factors between 2 and num
      {	
         if (num % fac == 0) //checks to see if a number is divisible
            primeCheck = false;
      }		
      return (primeCheck);	//returns true or false to calling functions printPrimes and getMaxPrime.
   }

/* function printPrimes (int num) prints all the prime numbers between 1 and num
*/
    void printPrimes (int num)
   {
      bool print;
      if (num <= 1)
   		cout << "none!"; // Determines if their are any primes in the range. 
   		
      for (int count = 2; count <= num; count++ )
      {
         print = isPrime(count); //Creates "print" function to determine if a number is prime.
         if (print == true)
         {
            cout << count << ", "; // outputs prime number 
         }
      }	
   }
				
				
				 	   		




/* function getMaxPrime(int num) returns the greatest prime number between 1 and num.
	if there is no prime number between 1 and num, getMaxPrime() should return a 0.
*/
    int getMaxPrime (int num)
   {
      int maxPrime;
      int prime = 2;
      if (num <= 1) //sets maxPrime to "0" (none)
   	{
   		maxPrime = 0; 
   		prime = 0;
   	}
   		
      do  //checks if a number is prime, sets maxPrime equal to found primes.
      {
         	bool check = isPrime(prime);
         	if (check == true)
            	maxPrime = prime; //sets maxPrime to last prime number found in range.
         	prime ++;
         
      }while (prime <= num);	
      return (maxPrime); // returns the value of maxPrime to main function		
   }




    int main ()
   {
      int number;
   
      do
      {
         cout 	<<endl<<endl 
            <<"Please enter a number, 0 or negative to stop :";
         cin >> number;
         if (number > 0)
         {
            cout << "All the prime numbers between 1 and "<< number<<" are:"<< endl;
            printPrimes(number);
            cout << endl;
            cout << "The max prime is :" ;
            int maxPrime = getMaxPrime( number );
            if (maxPrime<=1) cout <<"none.";
            else cout << maxPrime;
         }
      } while (number>0);
      return 0;
   }

coopedw

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

3 posts
since Mar 2006

Permalink

Mar 3rd, 2006

Re: (Noob) need some help w/ Prime Numbers

Do you know what is the definition of the prime number? It is a number that has no other diveders other than one and itself. You tested the number to itself (every number devides it self, doesn't it?) so that is why the function always return false.
If the number isn't prime it must have deviders to (inclusively) its square root. Think about it, and say why.

brahle

Reputation Points: 11

Solved Threads: 0

Newbie Poster

Offline

18 posts
since Mar 2006

Permalink

Mar 4th, 2006

Re: (Noob) need some help w/ Prime Numbers

If you exclude number 2, and start you for loop with 3, you need to check only odd numbers, increment you for loop by 2.

bumsfeld

Reputation Points: 404

Solved Threads: 180

Nearly a Posting Virtuoso

Offline

1,422 posts
since Jul 2005

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: Installing the SDK for VC++ 2005???

Next Thread in C++ Forum Timeline: Why program works in Dev-C++ and not in VC++ 2005?

DaniWeb Message

Cancel Changes

User Name
Password