Ad:

C++ Discussion Thread
Unsolved
Views: 58081

Page 1
2
Next

You are currently viewing page 1 of this multi-page discussion thread

Mar 23rd, 2004

Loop counting odd and even numbers

Expand Post »

i have a program that has one little glitch but i dont know how to fix it. If you can help it would be great.

C++ Syntax (Toggle Plain Text)
 
int main()
{
int a, b, c;
b=0;
c=0;
do
{
cout << "Please enter a positive integer (negative integer to stop):"<< ' ';
cin>> a;
if (a%2 == 0)
{
c++;
}
else
b++;
}
while (a>=0);
cout << "You have entered" << ' '<< b << ' ' <<"odd numbers." << endl;
cout << "And" << ' ' << c << ' ' <<"even numbers." << endl;
system("PAUSE");
return 0;
}
 
int main()
{
int a, b, c;
b=0;
c=0;
do
{
cout << "Please enter a positive integer (negative integer to stop):"<< ' ';
cin>> a;
if (a%2 == 0)
{
c++;
}
else
b++;
}
while (a>=0);
cout << "You have entered" << ' '<< b << ' ' <<"odd numbers." << endl;
cout << "And" << ' ' << c << ' ' <<"even numbers." << endl;
system("PAUSE");
return 0;
}

here is the program. the problem is if i put in these numbers 3,1037,60,-43. i get a answer of 3 odd numbers and 1 even numbers. it should say 2 odd and 1 even. the program is counting the negative number as an odd where it should just end the program.

Similar Threads

switch, and while loop outputting integer numbers and their squares in C++
odd even numbers in C++
making counter for odd numbers in C++
Adding the sum of odd numbers. Please help in Visual Basic 4 / 5 / 6
(Noob) need some help w/ Prime Numbers in C++

c++help

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

2 posts
since Mar 2004

Permalink

Mar 23rd, 2004

Re: I need some C++ help

It's a good start. Let me just tell you, the first thing I noticed was you have variables a, b, and c. But what are they? What do they represent? Variable names should always be indicative of what they do. Also, comments would help

Here is a start ...

C++ Syntax (Toggle Plain Text)
int main()
{
int input, even=0, odd=0;
do
{
cout << "Please enter a positive integer (negative integer to stop):"<< ' ';
cin>> input;
if ( (even%2 == 0) && (input >= 0) )
  even++;
else if (input >= 0)
  odd++;
}
while (input>=0);
 
cout << "You have entered" << ' '<< odd << ' ' <<"odd numbers." << endl;
cout << "And" << ' ' << even << ' ' <<"even numbers." << endl;
system("PAUSE");
return 0;
}
int main()
{
int input, even=0, odd=0;
do
{
cout << "Please enter a positive integer (negative integer to stop):"<< ' ';
cin>> input;
if ( (even%2 == 0) && (input >= 0) )
  even++;
else if (input >= 0)
  odd++;
}
while (input>=0);

cout << "You have entered" << ' '<< odd << ' ' <<"odd numbers." << endl;
cout << "And" << ' ' << even << ' ' <<"even numbers." << endl;
system("PAUSE");
return 0;
}

Note that my if statement has a conditional to make sure not to include the negative number. This is the easiest quick fix considering you're using a do while loop like this. You could also just use a nested if statement.

Another way to do it is to prompt the user to enter a first number. And then from then on use a while loop instead of a do while loop, where the prompt to enter a number is on the last line of the loop.

cscgal

Administrator

Staff Writer

Reputation Points: 1422

Solved Threads: 162

The Queen of DaniWeb

Offline

13,645 posts
since Feb 2002

Permalink

Mar 23rd, 2004

Re: I need some C++ help

thanks for the help, I really appreciate it. I have been really struggling with this language. I look forward to being a part of your community.

c++help

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

2 posts
since Mar 2004

Permalink

Mar 23rd, 2004

Re: I need some C++ help

Hey there. That's great. Welcome aboard.

cscgal

Administrator

Staff Writer

Reputation Points: 1422

Solved Threads: 162

The Queen of DaniWeb

Offline

13,645 posts
since Feb 2002

Permalink

Oct 2nd, 2010

Re: Loop counting odd and even numbers

can you help me make a code on arrays in finding even and odd numbers

avaughn

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

1 posts
since Oct 2010

Permalink

Oct 2nd, 2010

Re: Loop counting odd and even numbers

Hi avaughn, welcome to DaniWeb!

If you look at the post by cscgal above, you will see all of the elements that you need. The "if number%2 == 0" test is how to tell if a number is even or odd. Then you just have to keep track of which ones are which! Please give it a try and post some code and we can help if you get stuck.

David

daviddoria

Featured Poster

Reputation Points: 437

Solved Threads: 204

Posting Virtuoso

Offline

1,968 posts
since Feb 2008

Permalink

Oct 4th, 2010

Please help me !!

please help me how to determine odd and even number and how can i count all the odd or even numbers?

mcroneil

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

1 posts
since Oct 2010

Permalink

Oct 4th, 2010

Re: Loop counting odd and even numbers

i need some help about the bubble sort. i dont knw how to start.

rheg

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

1 posts
since Oct 2010

Permalink

Oct 4th, 2010

Re: Loop counting odd and even numbers

@mcroneil - Please show us your attempt and we can help you debug it.

@rheg - You should start a new thread when you have a new question.

daviddoria

Featured Poster

Reputation Points: 437

Solved Threads: 204

Posting Virtuoso

Offline

1,968 posts
since Feb 2008

Permalink

Oct 8th, 2010

Re: Loop counting odd and even numbers

Okay so I'm taking a computer science class and I have no idea what I'm doing! The hmwk is to design a program that iterates through integers from 1 to a value determined by user and add the odd numbers in the range and the even numbers in the range and output the sum for both. I am clueless as to how to get the program to add only the odds together and only the evens together... please help. This is what I have thus far...

#include <iostream>
using namespace std;
void main(void)
{
int number, max, increment;

cout << "Enter the max value: ";
cin >> max;
cout << "Enter the increment: ";
cin >> increment;

for(number = 1; number <= max; number = number + increment)
{
cout << number << endl;

if((number%2) == 0)
{
cout << "This number is even." << endl;
}
else if((number%2) == 1)
{
cout << "This number is odd." << endl;
}
else
{
cout << "Error." << endl;
}
}
}

clueless215

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

1 posts
since Oct 2010

Page 1
2
Next

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: MFC - Closing and Opening Dialog box

Next Thread in C++ Forum Timeline: Open a dialog box in MFC using pointer

DaniWeb Message

Cancel Changes

User Name
Password