943,862 Members | Top Members by Rank

Ad:
  • C++ Discussion Thread
  • Unsolved
  • Views: 6063
  • C++ RSS
Jun 24th, 2006
0

Dynamic Array of Structures, Loop problem!

Expand Post »
I am new to C++ and working through SAMS C++ primer. one of the excercies involves creating a dynamic array of structures to catalogue car information. I have the following code almost working and I am sure that I am missing something really simple.

The program compiles and runs as expected, however on the first run through the loop, the "make" of the car is not stored in the array. All subsequent loops capture the input and display properly.

Any help or point in the right direction would be appreciated.

thanks.


C++ Syntax (Toggle Plain Text)
  1. //c++ primer ch 5 ex 6.
  2. #include <iostream>
  3. using namespace std;
  4.  
  5. struct car {
  6.  
  7. char make[20];
  8. int year;
  9.  
  10.  
  11. };
  12. int c;
  13. int t = 1;
  14. int main() {
  15. cout <<"How many cars would you like to catalogue? ";
  16. cin >>c;
  17. cin.get();
  18.  
  19. car * catalogue = new car[c];
  20. car *ptr = &catalogue[0];
  21.  
  22. for (int i = 0;i < c; ++i)
  23. {
  24. cout <<"Car# "<<t<<":\n";
  25. cout <<"Enter make of car: ";
  26. cin.getline(ptr[i].make,20);
  27. cout <<"Enter year of car: ";
  28. cin >> ptr[i].year;
  29. cin.get();
  30. cout <<"\n";
  31. ++t;
  32. };
  33. delete [] catalogue;
  34.  
  35. cout <<"Your catalogue of cars: \n";
  36. for (int i = 0; i < c;++i)
  37. { cout <<catalogue[i].year<<" "<<catalogue[i].make<<"\n";
  38. };
  39.  
  40. }
Similar Threads
Reputation Points: 10
Solved Threads: 0
Newbie Poster
binteron is offline Offline
7 posts
since Jun 2006
Jun 24th, 2006
0

Re: Dynamic Array of Structures, Loop problem!

> car *ptr = &catalogue[0];
What does this achieve?

You can do this
cin.getline(catalogue[i].make,20);

> delete [] catalogue;
You need to do this after you've finished printing the data, not before.

> however on the first run through the loop, the "make" of the car is not stored in the array
Maybe you typed a space after the input of how many cars
So the get() only got rid of the space, not the newline which would immediately satisfy the getline.
Team Colleague
Reputation Points: 5862
Solved Threads: 950
Posting Sage
Salem is offline Offline
7,164 posts
since Dec 2005
Jun 25th, 2006
0

Re: Dynamic Array of Structures, Loop problem!

Hi Salem, Thanks for the quick reply. *ptr is something from a different book, it said pointer was best way to access dynamic arrays.

I have run the program many times and not entered a space after the number of cars, so that's a good thought, but not it. Also I had put a cin.get() after the input to see if there was something there causing the problem.
Reputation Points: 10
Solved Threads: 0
Newbie Poster
binteron is offline Offline
7 posts
since Jun 2006
Jun 25th, 2006
0

Re: Dynamic Array of Structures, Loop problem!

Well, I moved the delete [] catalogue line to the end of the program and now the thing runs perfectly.

Thanks Salem! I new it would be something simple and painfully obvious when you look at it.....duhhh.

best regards
Reputation Points: 10
Solved Threads: 0
Newbie Poster
binteron is offline Offline
7 posts
since Jun 2006
Jun 25th, 2006
0

Re: Dynamic Array of Structures, Loop problem!

> it said pointer was best way to access dynamic arrays.
It's the only way.

But both variables have the same type.
C++ Syntax (Toggle Plain Text)
  1. car * catalogue = new car[c];
  2. car *ptr = &catalogue[0];
All you've actually achieved is changing a 9-letter variable name (with some meaning) for a 3-letter variable name (with very little meaning). ptr[n] and catalogue[n] do exactly the same thing.

What you've also created is a dangling pointer problem. By having two variables pointing at the same memory you introduce the possibility of accessing ptr[n] long after you've done delete [ ] catalogue.
Team Colleague
Reputation Points: 5862
Solved Threads: 950
Posting Sage
Salem is offline Offline
7,164 posts
since Dec 2005
Jun 25th, 2006
0

Re: Dynamic Array of Structures, Loop problem!

I see, so in essence i created an extra pointer, one that wasn't needed. I had wondered about that, I must have misinterpreted the first book i read. Thanks a bunch for taking the time to clear that up form me.

Cheers Salem.
Reputation Points: 10
Solved Threads: 0
Newbie Poster
binteron is offline Offline
7 posts
since Jun 2006

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.
Message:
Previous Thread in C++ Forum Timeline: System modal dialog boxes
Next Thread in C++ Forum Timeline: Help, Won't Run





About Us | Contact Us | Advertise | Acceptable Use Policy
Forum Index | Build Custom RSS Feed


Follow us on Twitter


© 2011 DaniWeb® LLC