Ad:

C++ Discussion Thread
Marked Solved
Views: 3097

Page 1
2
Next

You are currently viewing page 1 of this multi-page discussion thread

Sep 17th, 2006

Determine if a certain ivalue is in a string

Expand Post »

Here's a really simple problem. I understand the basic search algorithms however, is there a difference when implemeting them in regards to vectors or strings? I want to determine if a certain value using a sequential search, the code would look something like this;

C++ Syntax (Toggle Plain Text)
#include <iostream> 
#include <fstream> 
#include <cstring> 
#include <vector>
using namespace std;
 
int isPresent(string value);
 
int main()//start of the main funtion
{
    string value;
    string string;
    cout <<"Enter a string";
    cin >> string;
    cout <<"Enter element to query"; 
    cin>> value;
    cout << isPresent(value); 
 
  system("PAUSE");
  return EXIT_SUCCESS;  
}
int isPresent(string value)
     {
 
     for (int i = 0; i < value.length()-1; i++)
       {
          if ( string[i] == value)
          return false;
          }
          return true;
     }
#include <iostream> 
#include <fstream> 
#include <cstring> 
#include <vector>
using namespace std;
 
int isPresent(string value);
 
int main()//start of the main funtion
{
    string value;
    string string;
    cout <<"Enter a string";
    cin >> string;
    cout <<"Enter element to query"; 
    cin>> value;
    cout << isPresent(value); 
 
  system("PAUSE");
  return EXIT_SUCCESS;  
}
int isPresent(string value)
     {
 
     for (int i = 0; i < value.length()-1; i++)
       {
          if ( string[i] == value)
          return false;
          }
          return true;
     }

however a syntax error keeps occuring, I cant seem to find the problem,
thanks for your help!

in regards to implementing this in a class, the same problem arrises;

C++ Syntax (Toggle Plain Text)
#include <vector>
#include <string>
#include <iostream>
using namespace std;
class LongString 
{
 private: 
  vector <string> contents;
 
 public:
 
  int isPresent(string value);
#include <vector>
#include <string>
#include <iostream>
using namespace std;
class LongString 
{
 private: 
  vector <string> contents;
 
 public:
 
  int isPresent(string value);

Similar Threads

Question about string pattern matching in Java

hay_man

Reputation Points: 38

Solved Threads: 0

Newbie Poster

Offline

16 posts
since Jun 2006

Permalink

Sep 17th, 2006

Re: Determine if a certain ivalue is in a string

I am not too sure of what your algorithm does but from your logic I assume that your program is to search whether the character entered is exist in the string you type.

As for your program, why don't you use character array data type ( char str[100] ) which usually representing strings in C++ or character data type ( char value ) which represent a single character. I am not sure of the use of data type string in C++ except in Java. Beside that, your "isPresent" function only accept one parameter "value". If so, you can't compare the string entered with the value entered in the if statement. The string entered is not pass in to the "isPresent" function to be compared.

Hope this will help you.

rinoa04

Reputation Points: 52

Solved Threads: 4

Junior Poster in Training

Offline

84 posts
since Sep 2006

Permalink

Sep 17th, 2006

Re: Determine if a certain ivalue is in a string

Maybe this perhaps...

C++ Syntax (Toggle Plain Text)
 
#include <iostream>
#include <string>
 
using namespace std;
void isPresent(string,string);
int main()
 
{
    string value;
    string myString;
    cout <<"Enter a string:";
    cin >> myString;
    cout <<"Enter element to query:"; 
    cin>> value;
    isPresent(value,myString); 
 
 
    cin.get();
    cin.get();
}
void isPresent(string var,string myString)
{
    string::size_type loc = myString.find( var, 0 );
   if( loc != string::npos )
     cout << "Found  at " << loc << endl;
   else
     cout << "Didn't find " << endl;
}
 
#include <iostream>
#include <string>
 
using namespace std;
void isPresent(string,string);
int main()
 
{
    string value;
    string myString;
    cout <<"Enter a string:";
    cin >> myString;
    cout <<"Enter element to query:"; 
    cin>> value;
    isPresent(value,myString); 
 
 
    cin.get();
    cin.get();
}
void isPresent(string var,string myString)
{
    string::size_type loc = myString.find( var, 0 );
   if( loc != string::npos )
     cout << "Found  at " << loc << endl;
   else
     cout << "Didn't find " << endl;
}

To handle white space consider changing the main part to...

C++ Syntax (Toggle Plain Text)
{
    string value;
    string myString;
    cout <<"Enter a string:";
    getline(cin,myString,'\n');
    cout <<"Enter element to query:"; 
    getline(cin,value,'\n');
    isPresent(value,myString); 
 
    cin.get();
 
}
{
    string value;
    string myString;
    cout <<"Enter a string:";
    getline(cin,myString,'\n');
    cout <<"Enter element to query:"; 
    getline(cin,value,'\n');
    isPresent(value,myString); 
    
    cin.get();
  
}

Last edited by iamthwee; Sep 17th, 2006 at 6:29 am. Reason: changing to handle whitespace

iamthwee

Featured Poster

Reputation Points: 1536

Solved Threads: 431

Posting Expert

Offline

5,865 posts
since Aug 2005

Permalink

Sep 17th, 2006

Re: Determine if a certain ivalue is in a string

unfortunately, passing in one parameter is a precondition given to me by my lecturer. I too was puzzled by this.

Last edited by hay_man; Sep 17th, 2006 at 8:54 am.

hay_man

Reputation Points: 38

Solved Threads: 0

Newbie Poster

Offline

16 posts
since Jun 2006

Permalink

Sep 17th, 2006

Re: Determine if a certain ivalue is in a string

Click to Expand / Collapse Quote originally posted by hay_man ...

unfortunately, passing in one parameter is a precondition given to me by my lecturer. I too was puzzled by this.

Try using an global variable instead of passing one
for example:

C++ Syntax (Toggle Plain Text)
include <iostream>;
 
using namespace std;
 
int global;
 
void show()
{
    cout << "The value is: " << global << endl;
}
 
int main()
{
    global = 10;
    show();
    global = 988;
    show()
}
include <iostream>;

using namespace std;

int global;

void show()
{
    cout << "The value is: " << global << endl;
}

int main()
{
    global = 10;
    show();
    global = 988;
    show()
}

I haven't tested this, but you should get the idea.

Anonymusius

Reputation Points: 129

Solved Threads: 11

Posting Whiz in Training

Offline

223 posts
since Aug 2006

Permalink

Sep 17th, 2006

Re: Determine if a certain ivalue is in a string

Since your requirement is using only one parameter, there is another way to solve this problem. The solution is using strcpy. The string entered can be copy to a global variable to store the content for the use in isPresent function. You can refer the coding below:

C++ Syntax (Toggle Plain Text)
#include <iostream> 
#include <cstring> 
using namespace std;
 
void isPresent(char value);
 
char str1[100]; 
 
int main()
{
    char value;
    char str[100];
    cout <<"Enter a string: ";
    cin.getline(str,100);
    strcpy(str1, str);
    cout <<"Enter element to query: "; 
    cin>> value;
    isPresent(value); 
    return 0;  
}
 
void isPresent(char value)
{ 
    for (int i = 0; i <= strlen(str1); i++)
    {
         if ( str1[i] == value )
         {
               cout << value << " is IN " << str1 << endl;
               exit(0);
         }
    }
    cout << value << " is NOT IN " << str1 << endl;
}
#include <iostream> 
#include <cstring> 
using namespace std;
 
void isPresent(char value);
 
char str1[100]; 
 
int main()
{
    char value;
    char str[100];
    cout <<"Enter a string: ";
    cin.getline(str,100);
    strcpy(str1, str);
    cout <<"Enter element to query: "; 
    cin>> value;
    isPresent(value); 
    return 0;  
}
 
void isPresent(char value)
{ 
    for (int i = 0; i <= strlen(str1); i++)
    {
         if ( str1[i] == value )
         {
               cout << value << " is IN " << str1 << endl;
               exit(0);
         }
    }
    cout << value << " is NOT IN " << str1 << endl;
}

Last edited by Salem; Sep 17th, 2006 at 12:41 pm. Reason: fix code tags

rinoa04

Reputation Points: 52

Solved Threads: 4

Junior Poster in Training

Offline

84 posts
since Sep 2006

Permalink

Sep 17th, 2006

Re: Determine if a certain ivalue is in a string

Quote originally posted by hay_man ...

unfortunately, passing in one parameter is a precondition given to me by my lecturer. I too was puzzled by this.

Why don't you explain how your class you are supposed to design works. It might explain why you teachers only expects one parameter to the function isPresent().

iamthwee

Featured Poster

Reputation Points: 1536

Solved Threads: 431

Posting Expert

Offline

5,865 posts
since Aug 2005

Permalink

Sep 17th, 2006

Re: Determine if a certain ivalue is in a string

Click to Expand / Collapse Quote originally posted by Anonymusius ...

Try using an global variable instead of passing one

Ssshhhhh...

Grunt

Reputation Points: 197

Solved Threads: 12

Junior Poster

Offline

147 posts
since Jul 2006

Permalink

Sep 17th, 2006

Re: Determine if a certain ivalue is in a string

Click to Expand / Collapse Quote originally posted by Anonymusius ...

Try using an global variable instead of passing one

Yes i completely agree with Mr. Grunt, passing global variables is not the best programming practice around. And to suggest this to someone who has just started programming is not a good thing since they dont know the side effects or bad effects associated with them.

~s.o.s~

Super Moderator

Featured Poster

Reputation Points: 3241

Solved Threads: 719

Failure as a human

Offline

8,873 posts
since Jun 2006

Permalink

Sep 17th, 2006

Re: Determine if a certain ivalue is in a string

Ha.! I remember my C++ instructor promising not to give us a bad grade on an assignment if we promised not to use global variables...lol

FC Jamison

Team Colleague

Reputation Points: 92

Solved Threads: 21

Posting Pro in Training

Offline

436 posts
since Jun 2004

Page 1
2
Next

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: Algorithm doubt

Next Thread in C++ Forum Timeline: Noob Help needed for Time problem

DaniWeb Message

Cancel Changes

User Name
Password