Adding binary values from a file

Expand Post »

Hello, I'm working o a function that takes a file with binary numbers and returns the sum of those numbers. Here's where I'm now

C++ Syntax (Toggle Plain Text)
int Sum (char *fileName)
{
char * numEnd;
long temp(0);
int result(0);
string line;
 ifstream file (fileName);
  if (file.is_open())
  {
    while (! file.eof() )
    {
      getline (file,line);
//Convert line to an long and sum up with the rest 
      temp = strtol(line, &numEnd, 2);
      result = result + temp;    
//Done
    }
// close the stream
    file.close();
  }
return result;
}
int Sum (char *fileName)
{
char * numEnd;
long temp(0);
int result(0);
string line;
 ifstream file (fileName);
  if (file.is_open())
  {
    while (! file.eof() )
    {
      getline (file,line);
//Convert line to an long and sum up with the rest 
      temp = strtol(line, &numEnd, 2);
      result = result + temp;    
//Done
    }
// close the stream
    file.close();
  }
return result;
}

and here's an error I'm getting when building it:
error C2664: 'strtol' : cannot convert parameter 1 from 'std::string' to 'const char *'

I thought strtol needed a pointer to the string, but changing line to pointer to line didn't help. Anyone can point me in a right direction?

Similar Threads

reading txt file into array in C++
Adding binary numbers in C++
Binary Search on a text file in Java
read & write Binary data in C++
spaces in binary file not showing in C++

DynamitMsk

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

14 posts
since Dec 2006

Permalink

Dec 16th, 2006

Re: Adding binary values from a file

OK, I got it. Any comments on code quality or improvements are still welcome!

C++ Syntax (Toggle Plain Text)
int Sum (char *fileName)
{
char * numEnd;
long temp(0);
int result(0);
string line;
 ifstream file (fileName);
  if (file.is_open())
  {
    while (! file.eof() )
    {
      getline (file,line);
//Convert line to an int and sum up with the rest 
      char *linePt = &line[0];
      temp = strtol(linePt, &numEnd, 2);
      result = result + temp;    
//Done
    }
// close the stream
    file.close();
  }
return result;
}
int Sum (char *fileName)
{
char * numEnd;
long temp(0);
int result(0);
string line;
 ifstream file (fileName);
  if (file.is_open())
  {
    while (! file.eof() )
    {
      getline (file,line);
//Convert line to an int and sum up with the rest 
      char *linePt = &line[0];
      temp = strtol(linePt, &numEnd, 2);
      result = result + temp;    
//Done
    }
// close the stream
    file.close();
  }
return result;
}

DynamitMsk

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

14 posts
since Dec 2006

Permalink

Dec 17th, 2006

Re: Adding binary values from a file

It's because strtol was an old C function written far before C++ strings were invented. Although C++ strings have overloaded functions to make transitions from the older-style char strings to C++ strings and vice-versa, this problem can't be as transparently solved when passing a C++ string to a function that is expecting a char string. To remedy this, C++ strings include a nifty member function called c_str() that can quickly return the char string equivalent. Thus, you could code it like this:

C++ Syntax (Toggle Plain Text)
temp = strtol(line.c_str(), &numEnd, 2);
temp = strtol(line.c_str(), &numEnd, 2);

Better yet, use the C++ streams, the modern equivalent of a lot of the old C string functions, rather than mixing C and C++.

Hope this helps

John A

Team Colleague

Reputation Points: 2240

Solved Threads: 338

Vampirical Lurker

Offline

5,055 posts
since Apr 2006

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: unknown error at run time urgent help needed

Next Thread in C++ Forum Timeline: Bowling game

DaniWeb Message

Cancel Changes

User Name
Password