If Else If Help plz

Expand Post »

Hi, im a new to C++ and i am having an issue with if else if commands. I have the code below, and i am attempting to make it so when prompted "Do you want the correct answers?" you can type yes and it will display the answers, or type no to display "have a nice day" and if neither are typed then it says "you did not enter a valid character" and thats the end of the program.

if you have any help please do leave a message, keep in mind im new to C++

Thanks
-Scott

c Syntax (Toggle Plain Text)
 
//NOT ENTIRE PROGRAM 
//Additional work
  cout << "Do you want the correct answers? (Type yes or no)\n";
 
  char x;
  cin >> x;
  //cin.ignore(50, '\n');
 
 
  float PIa=3.14159;
  float PI2a=3.14285714;
  float Ea=2.718281828459;    
  if (x == yes)
     {
         system("CLS");
         cout << "Have a nice day!\n";
         cin.ignore(50, '\n');
     }
  else if (x == no)
     {
         cout << "\"PI\" is equal to:  " << PIa << endl
              << "\"E\" is equal to:  " << Ea << endl
              << "\"22/7\" is equal to:  " << PI2a << endl;
 
     }
     else
     {
         cout << "You did not enter a valid character\n";
     }      
    system("PAUSE");
    return 0;
}
 
//NOT ENTIRE PROGRAM 
//Additional work
  cout << "Do you want the correct answers? (Type yes or no)\n";
  
  char x;
  cin >> x;
  //cin.ignore(50, '\n');
  
  
  float PIa=3.14159;
  float PI2a=3.14285714;
  float Ea=2.718281828459;    
  if (x == yes)
     {
         system("CLS");
         cout << "Have a nice day!\n";
         cin.ignore(50, '\n');
     }
  else if (x == no)
     {
         cout << "\"PI\" is equal to:  " << PIa << endl
              << "\"E\" is equal to:  " << Ea << endl
              << "\"22/7\" is equal to:  " << PI2a << endl;
              
     }
     else
     {
         cout << "You did not enter a valid character\n";
     }      
    system("PAUSE");
    return 0;
}

Similar Threads

can someone plz help me with this? in Visual Basic 4 / 5 / 6
I NEED SUPPORT **"IMPORTANT"** PLZ HELP in Windows NT / 2000 / XP
Windows media player in Windows NT / 2000 / XP
Bridge.dll...Make it go away, Plz in Viruses, Spyware and other Nasties
can sum1 look @ dis plz in Viruses, Spyware and other Nasties

killerdrummer2

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

4 posts
since Jul 2006

Permalink

Jan 12th, 2007

Re: If Else If Help plz

You have to remember that this code is only inputting one charecter:

C++ Syntax (Toggle Plain Text)
cout << "Do you want the correct answers? (Type yes or no)\n";
 
  char x;
  cin >> x;
cout << "Do you want the correct answers? (Type yes or no)\n";
  
  char x;
  cin >> x;

Because char only can hold one charecter, you'll need an array of letters to be able to hold a response that's more than one letter long. For example:

C++ Syntax (Toggle Plain Text)
char name[200]; // holds a name up to 200 charecters
char name[200]; // holds a name up to 200 charecters

Better yet, to make it more C++, use a string, which does not have to be an array, and instead dynamically allocates the memory needed.

Of course, you may have only been intending to hold one charecter, but then when I saw this, it made be think that you wanted to input more:

c Syntax (Toggle Plain Text)
  if (x == yes)
  if (x == yes)

Now you've got several things wrong with this. The most obvious mistake is that you're not using quotes around the string; thus it will confuse the compiler. Secondly, unless the variable is only 1 charecter long (see previous section), you cannot compare C-style strings with ==. If you want to compare a string, you must use strcmp(). Yet another reason to use string instead of char (strings can be compared with ==).

Lastly, this isn't entirely incorrect but...

c Syntax (Toggle Plain Text)
system("PAUSE");
system("PAUSE");

A more portable and standard method to do this is simply to use

c Syntax (Toggle Plain Text)
cin.get();
cin.get();

Hope this helps

John A

Team Colleague

Reputation Points: 2240

Solved Threads: 338

Vampirical Lurker

Offline

5,055 posts
since Apr 2006

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: problem with calendar..

Next Thread in C++ Forum Timeline: Linked Lists and Copy Constructor

DaniWeb Message

Cancel Changes

User Name
Password