Ad:

C++ Discussion Thread
Unsolved
Views: 3254

Page 1
2
Next

You are currently viewing page 1 of this multi-page discussion thread

Feb 4th, 2007

help with an assignement please

Expand Post »

C++ Syntax (Toggle Plain Text)
#include <iostream>
#include <fstream>
#include <cctype>
using std::fstream;
 
using namespace std;
 
int count[26];
int main(int argc, char *argv[])
{
  char ch;
 
  ifstream infile("c:\\a.txt") ;
  if ( !infile )
  {
        cerr << "File could not be opened" << endl;
        exit( 1 );
  }
  int i;
  for(i = 0; i <26; i++) count[ i ] = 0;
 
  while (! infile.eof())
  {
      ch = cin.get();
      if(isalpha(ch)) 
      {
          ch = toupper(ch); 
          count[ch-'A']++;
      }
  };
  for(i = 0; i <26; i++) {
    cout << (char) ('A'+ i) << ": " << count[ i ] << '\n';
  }
 
  return 0;
}
#include <iostream>
#include <fstream>
#include <cctype>
using std::fstream;

using namespace std;

int count[26];
int main(int argc, char *argv[])
{
  char ch;
  
  ifstream infile("c:\\a.txt") ;
  if ( !infile )
  {
        cerr << "File could not be opened" << endl;
        exit( 1 );
  }
  int i;
  for(i = 0; i <26; i++) count[ i ] = 0;
 
  while (! infile.eof())
  {
      ch = cin.get();
      if(isalpha(ch)) 
      {
          ch = toupper(ch); 
          count[ch-'A']++;
      }
  };
  for(i = 0; i <26; i++) {
    cout << (char) ('A'+ i) << ": " << count[ i ] << '\n';
  }

  return 0;
}

what i wanted to do with this code was input a stream of alphabetical characters and output the amount of each alphabetical letter. for ex. if the text said aaabbccccc.....yyzzzz i want to output
a:3
b:2
c:5 etc etc

but even this compiles alrigght and file was opened all i get is a blank screen. i'm really stumped and since i'm such a newbie i really don't know what im doing wrong. ang suggestions or comments will be useful.

Similar Threads

(C++) Writing a Copy Constructor?!? in C++
Linkedlist Troubles...plz Help in Java
Please I Need U Again in C++
How to write a *WORKING* reservation system for public computers in C
Forum lurkers, introduce yourself ... !! in Community Introductions

loslos

Reputation Points: 21

Solved Threads: 0

Newbie Poster

Offline

4 posts
since Feb 2007

Permalink

Feb 4th, 2007

Re: help with an assignement please

>> ch = cin.get();
you should use infine, not cin

C++ Syntax (Toggle Plain Text)
      ch = infile.get();
      ch = infile.get();

And thanks for taking the time to read the board's rules to use code tags correctly. Not many first-time posters do that.

Ancient Dragon

Sponsor

Team Colleague

Featured Poster

Reputation Points: 5608

Solved Threads: 2282

Retired and Enjoying Life

Offline

21,953 posts
since Aug 2005

Permalink

Feb 4th, 2007

Re: help with an assignement please

Off topic, but in the spirit of trying not to learn bad habits, and trying to avoid bugs that can be difficult to find when trying to determine why you don't get the results you expect on trial runs with known input as you test your code, the following

C++ Syntax (Toggle Plain Text)
while (! infile.eof())
  {
      ch = cin.get();
while (! infile.eof())
  {
      ch = cin.get();

could be changed to

while(infile >> ch)

You should avoid using the return value of eof() as the controlling condition for a loop. There are two reasons I know of to want to do this.

First, using the return value of eof() to terminate the loop is likely to cause a double counting of the last char in the file. If that char is a newline, then the double count will go unnoticed in your current code. But if the file terminates with an alphabetical char, it may, or may not, be counted twice. Inmy experience, trying to figure out why the code works appropriately sometimes and not others is probably the hardest bug to find.

Second, using the return value of the input statement to control the loop allows the loop to terminate appropriately, whether it terminates becuase it read the entire file, or whether it terminates because of some other cause. The loop might not terminate appropriately if the control condition is only whether the EOF marker was found but the linput stream fails for some other reason.

Last edited by Lerner; Feb 4th, 2007 at 11:12 am.

Lerner

Reputation Points: 718

Solved Threads: 373

Nearly a Posting Maven

Offline

2,253 posts
since Jul 2005

Permalink

Feb 4th, 2007

Re: help with an assignement please

Click to Expand / Collapse Quote originally posted by Lerner ...

You should avoid using the return value of eof() as the controlling condition for a loop. There are two reasons I know of to want to do this.

First, using the return value of eof() to terminate the loop is likely to cause a double counting of the last char in the file. If that char is a newline, then the double count will go unnoticed in your current code. But if the file terminates with an alphabetical char, it may, or may not, be counted twice. Inmy experience, trying to figure out why the code works appropriately sometimes and not others is probably the hardest bug to find.

That would be feof( ) you are talking about which returns zero only *after* the end of file is reached and not *when* the end of file is reached. eof( ) is actually good and returns a boolean value when the end of file is reached.

~s.o.s~

Super Moderator

Featured Poster

Reputation Points: 3233

Solved Threads: 719

Failure as a human

Offline

8,872 posts
since Jun 2006

Permalink

Feb 4th, 2007

Re: help with an assignement please

Click to Expand / Collapse Quote originally posted by ~s.o.s~ ...

That would be feof( ) you are talking about which returns zero only *after* the end of file is reached and not *when* the end of file is reached. eof( ) is actually good and returns a boolean value when the end of file is reached.

I don't get it.

eof() returns true if the eofbit is set, but the eofbit doesn't get set until you hit end of file while reading. Unless you test for end of file after the read, the order is wrong and you'll loop one too many times. Here's an example that shows the problem.

C++ Syntax (Toggle Plain Text)
#include <fstream>
#include <iostream>
#include <string>
 
 
int main()
{
  using namespace std;
 
  // Build a test file
  {
    ofstream os( "test.txt" );
 
    os << "12345";
  }
 
  // Test the test file :)
  ifstream is( "test.txt" );
  int loopCount = 0;
  char ch;
 
  while ( !is.eof() ) {
    ++loopCount;
    is.get( ch );
    cout << ch << '\n';
  }
 
  cout << "Loop count: " << loopCount << '\n';
 
  return 0;
}
#include <fstream>
#include <iostream>
#include <string>


int main()
{
  using namespace std;

  // Build a test file
  {
    ofstream os( "test.txt" );

    os << "12345";
  }

  // Test the test file :)
  ifstream is( "test.txt" );
  int loopCount = 0;
  char ch;

  while ( !is.eof() ) {
    ++loopCount;
    is.get( ch );
    cout << ch << '\n';
  }

  cout << "Loop count: " << loopCount << '\n';

  return 0;
}

eof() and feof() have the same problem because they work the same way.

Ravalon

Reputation Points: 84

Solved Threads: 15

Posting Whiz in Training

Offline

209 posts
since Dec 2006

Permalink

Feb 4th, 2007

Re: help with an assignement please

Click to Expand / Collapse Quote originally posted by ~s.o.s~ ...

That would be feof( ) you are talking about which returns zero only *after* the end of file is reached and not *when* the end of file is reached. eof( ) is actually good and returns a boolean value when the end of file is reached.

No I believe eof has similar problems when the file contains extra newlines.

Like lerner and ravalon said best to avoid it altogether, especially in c++. I'm surprised your little google groups didn't tell you that sos. Ha ha.

Last edited by iamthwee; Feb 4th, 2007 at 1:22 pm.

iamthwee

Featured Poster

Reputation Points: 1536

Solved Threads: 431

Posting Expert

Offline

5,865 posts
since Aug 2005

Permalink

Feb 4th, 2007

Re: help with an assignement please

Click to Expand / Collapse Quote originally posted by Ravalon ...

I don't get it. eof() returns true if the eofbit is set, but the eofbit doesn't get set until you hit end of file while reading. Unless you test for end of file after the read, the order is wrong and you'll loop one too many times.

My bad, I should have been more explicit. Yes, I agree, feof( ) and eof( ) are not that great when compared to checking the stream state while reading files. But for small fixes I normally use:

C++ Syntax (Toggle Plain Text)
#include <fstream>
#include <iostream>
#include <string>
 
int main()
{
  using namespace std;
 
  // Build a test file
  {
    ofstream os( "test.txt" );
 
    os << "12345";
  }
 
  // Test the test file :)
  ifstream is( "test.txt" );
  int loopCount = 0;
  char ch;
 
  while (1 ) {
    is.get( ch );
    if( is.eof() ) break ;
    ++loopCount;
    cout << ch << '\n';
  }
 
  cout << "Loop count: " << loopCount << '\n';
  getchar( ) ;
  return 0;
}
#include <fstream>
#include <iostream>
#include <string>

int main()
{
  using namespace std;

  // Build a test file
  {
    ofstream os( "test.txt" );

    os << "12345";
  }

  // Test the test file :)
  ifstream is( "test.txt" );
  int loopCount = 0;
  char ch;

  while (1 ) {
    is.get( ch );
    if( is.eof() ) break ;
    ++loopCount;
    cout << ch << '\n';
  }

  cout << "Loop count: " << loopCount << '\n';
  getchar( ) ;
  return 0;
}

Quote originally posted by Iamthwee ...

I'm surprised your little google groups didn't tell you that sos. Ha ha.

*sigh* Btw when are you turning 14 ?

~s.o.s~

Super Moderator

Featured Poster

Reputation Points: 3233

Solved Threads: 719

Failure as a human

Offline

8,872 posts
since Jun 2006

Permalink

Feb 4th, 2007

Re: help with an assignement please

Click to Expand / Collapse Quote originally posted by ~s.o.s~ ...

But for small fixes I normally use:
C++ Syntax (Toggle Plain Text)
  while ( 1 ) {
    is.get( ch );
    if( is.eof() ) break ;
    ++loopCount;
    cout << ch << '\n';
  }
while ( 1 ) { is.get( ch ); if( is.eof() ) break ; ++loopCount; cout << ch << '\n'; }

Why that instead of this? Seems like more for less.

C++ Syntax (Toggle Plain Text)
  while ( is.get( ch ) ) {
    ++loopCount;
    cout << ch << '\n';
  }
  while ( is.get( ch ) ) {
    ++loopCount;
    cout << ch << '\n';
  }

This will break the loop on errors too.

Last edited by Dave Sinkula; Feb 4th, 2007 at 3:43 pm.

Dave Sinkula

Team Colleague

Reputation Points: 2780

Solved Threads: 312

long time no c

Offline

4,790 posts
since Apr 2004

Permalink

Feb 4th, 2007

Re: help with an assignement please

Quote ...

Yes, I agree, feof( ) and eof( ) are not that great when compared to checking the stream state while reading files. But for small fixes I normally use:

As always, in these circumstances go for the solution that works every time. Sure you can build functionality in eof() so that it works correctly.

Hell you can even use gets() safely if you go outta your way to implement the requisite error checks.

But that's extra work for very little benefit.

See you don't learn this at the google groups.:lol:

iamthwee

Featured Poster

Reputation Points: 1536

Solved Threads: 431

Posting Expert

Offline

5,865 posts
since Aug 2005

Permalink

Feb 4th, 2007

Re: help with an assignement please

Click to Expand / Collapse Quote originally posted by iamthwee ...

As always, in these circumstances go for the solution that works every time. Sure you can build functionality in eof() so that it works correctly.

Hell you can even use gets() safely if you go outta your way to implement the requisite error checks.

But that's extra work for very little benefit.

The code snippet / my post was meant to illustrate that using eof( ) is not completely wrong or taboo if used the right way. Just ignoring a part of language just because using it in the wrong way ensues chaos is foolishness.

An use of eof( ) would be:

c Syntax (Toggle Plain Text)
 char buf[BUFSIZE];
 do {
   in.read( buf, BUFSIZE );
   std::streamsize n = in.gcount();
   out.write( buf, n );
 } while( in.good() );
 if( in.bad() || !in.eof() ) {
   // fatal error occurred
 }
 in.close();
 char buf[BUFSIZE];
 do {
   in.read( buf, BUFSIZE );
   std::streamsize n = in.gcount();
   out.write( buf, n );
 } while( in.good() );
 if( in.bad() || !in.eof() ) {
   // fatal error occurred
 }
 in.close();

Not bad, is it...

So stop considering a feature bad just because someone says so...

Quote ...

See you don't learn this at the google groups.

I guess you were badly flamed at google groups for obvious reasons, thats why you keep mentioning it.....

~s.o.s~

Super Moderator

Featured Poster

Reputation Points: 3233

Solved Threads: 719

Failure as a human

Offline

8,872 posts
since Jun 2006

Page 1
2
Next

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: problem opening CSV file

Next Thread in C++ Forum Timeline: NOOB flashback

DaniWeb Message

Cancel Changes

User Name
Password