Ad:

C++ Discussion Thread
Marked Solved
Views: 4324

Mar 10th, 2007

Problems Linking C++ Files

Expand Post »

Hi, I'm a newbie to C++. I use Windows XP Home Edition and VC++ .NET 2003.

I have just recently started creating large scale C++ projects with more than one file. I've been having troubles linking the files together.

I solved the problem by adding "/FORCE:MULTIPLE" to the command line, but the compiler still gives linker warnings. I don't feel satisfied just by cheating my way out.

The real source files are large, and I know that it is a linker error, so I created smaller files with a similar structure that give the same errors.

Here are the source files:

stdafx.cpp

(Toggle Plain Text)

#include "stdafx.h"

Untitled.cpp

(Toggle Plain Text)

#include "stdafx.h"
#include "MyClass.cpp"
#include "OtherClass.cpp"
 
usingnamespace std;
 
int main()
{
myClass Class;
otherClass Class2;
 
return 0;
}

MyClass.cpp

(Toggle Plain Text)

#include "stdafx.h"
 
usingnamespace std;
 
class myClass
{
public:
 
myClass();
 
int variable;
 
void function1();
void function2();
 
};
 
myClass::myClass()
{
variable = 0;
}
 
void myClass::function1()
{
variable = 1;
}
 
void myClass::function2()
{
variable = 2;
}

OtherClass.cpp

(Toggle Plain Text)

#include "stdafx.h"
 
class otherClass
{
public:
 
otherClass();
 
int variable;
 
void function1();
void function2();
 
};
 
otherClass::otherClass()
{
variable = 0;
}
 
void otherClass::function1()
{
variable = 1;
}
 
void otherClass::function2()
{
variable = 2;
}

And here are the errors:

MyClass.obj : error LNK2005: "public: __thiscall myClass::myClass(void)" (??0myClass@@QAE@XZ) already defined in Untitled.obj
MyClass.obj : error LNK2005: "public: void __thiscall myClass::function1(void)" (?function1@myClass@@QAEXXZ) already defined in Untitled.obj
MyClass.obj : error LNK2005: "public: void __thiscall myClass::function2(void)" (?function2@myClass@@QAEXXZ) already defined in Untitled.obj
OtherClass.obj : error LNK2005: "public: __thiscall otherClass:0therClass(void)" (??0otherClass@@QAE@XZ) already defined in Untitled.obj
OtherClass.obj : error LNK2005: "public: void __thiscall otherClass::function1(void)" (?function1@otherClass@@QAEXXZ) already defined in Untitled.obj
OtherClass.obj : error LNK2005: "public: void __thiscall otherClass::function2(void)" (?function2@otherClass@@QAEXXZ) already defined in Untitled.obj
Debug/Untitled.exe : fatal error LNK1169: one or more multiply defined symbols found

Thanks in advance! :cheesy:

btw: Do error messages need "code" tags?

Similar Threads

i_like_pi

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

9 posts
since Mar 2007

Permalink

Mar 10th, 2007

Re: Problems Linking C++ Files

A big THANK YOU for using code tags! You are one of the few newbies that actually read the rules and follow them from the first post.

2 things that caught my eye right away:

Never include cpp files. Since they are implementation files, all that should be required is that you add them to your project's workspace.

Secondly, you need to place you class definitions in header files (.h). These header files are then included by your .cpp files that use the functions, or in the case of the class method implementation cpp files, define the functions.

In case that wasn't clear, here's what I mean:

C++ Syntax (Toggle Plain Text)
// myclass.h
#ifndef MYCLASS_H   // note: these are very important!
#define MYCLASS_H
class myClass {
 
public:
    void myFunc();
    // blah blah blah
 
};
#endif
 
// myclass.cpp
#include "myclass.h"
 
void myFunc::myClass() {
   // etc
}
 
// main.cpp
 
#include "myclass.h"
 
int main() {
 
    myClass myObj;
 
}
// myclass.h
#ifndef MYCLASS_H   // note: these are very important!
#define MYCLASS_H
class myClass {

public:
    void myFunc();
    // blah blah blah

};
#endif

// myclass.cpp
#include "myclass.h"

void myFunc::myClass() {
   // etc
}

// main.cpp

#include "myclass.h"

int main() {

    myClass myObj;

}

Last edited by John A; Mar 10th, 2007 at 7:17 pm.

John A

Team Colleague

Reputation Points: 2240

Solved Threads: 338

Vampirical Lurker

Offline

5,055 posts
since Apr 2006

Permalink

Mar 10th, 2007

Re: Problems Linking C++ Files

Thanks! Your suggestion solved the errors! My only question is, why do i need the #ifndefine, #define, #endif etc. ?

i_like_pi

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

9 posts
since Mar 2007

Permalink

Mar 10th, 2007

Re: Problems Linking C++ Files

Click to Expand / Collapse Quote originally posted by i_like_pi ...

Thanks! Your suggestion solved the errors! My only question is, why do i need the #ifndefine, #define, #endif etc. ?

It's to prevent multiple inclusions. Let's take that previous example that we had before, but now you need to include this class in other files as well:

C++ Syntax (Toggle Plain Text)
// otherclass.cpp
 
#include "myclass.h"
 
// blah blah blah
 
// anotherclass.cpp
 
#include "myclass.h"
 
// blah blah blah
// otherclass.cpp

#include "myclass.h"

// blah blah blah

// anotherclass.cpp

#include "myclass.h"

// blah blah blah

Now, normally the header code would be pasted into the cpp files by the compiler's preprocessor. But this would cause errors because you are redefining the class. You are only allowed to define a class once. Using #ifndef/#define/#endif checks to see if it has already been included by another file. If so, it does nothing, and no errors happen.

John A

Team Colleague

Reputation Points: 2240

Solved Threads: 338

Vampirical Lurker

Offline

5,055 posts
since Apr 2006

Permalink

Mar 10th, 2007

Re: Problems Linking C++ Files

I see, so the commands that start with "#" are messages to the compiler. Thanks alot!

i_like_pi

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

9 posts
since Mar 2007

Permalink

Mar 10th, 2007

Re: Problems Linking C++ Files

>I see, so the commands that start with "#" are messages to the compiler.
Yup. The technical name for them is "preprocessor directives", so don't freak out if you hear that term.

>Thanks alot!
Glad I could help.

John A

Team Colleague

Reputation Points: 2240

Solved Threads: 338

Vampirical Lurker

Offline

5,055 posts
since Apr 2006

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: wireless network programming in c++

Next Thread in C++ Forum Timeline: ifstream help

DaniWeb Message

Cancel Changes

User Name
Password