Ad:

C++ Discussion Thread
Unsolved
Views: 1991

Page 1
2
Next

You are currently viewing page 1 of this multi-page discussion thread

Mar 10th, 2007

The greater number

Expand Post »

It works. I'm having a problem trying to display the greater number
to the output. For example what ever number is greater the
first or the second it still displays the first number.
Couse that is what is coded in the cout. But I dont know
what to put in it to display the greater number instead
of the fisrt number. Also I dont know how to connect the fisrt part of the code to the second. For example the void block of code is completlly independent of the main. The program will run the same with the void function in or out.

c Syntax (Toggle Plain Text)
 
#include <iostream>
using namespace std;
 
 
void Max(int& x, int& y)
{                    // start of function body
  int max; 
  int other;       // variable declaration
 
  if (x >= y) 
  {       // find the maximum number
    max = x;
  }
  else
  {
    (x <= y);
 
    max = y;
  }
 
}
 
 
int main()
{
  void Max( int& , int&);  // function declaration (prototype)
  int firstnum, secnum;
 
  cout << "\nEnter a number: ";
  cin  >> firstnum;
  cout << "Great! Please enter a second number: ";
  cin  >> secnum;
 
  cout << "\nThe maximum of these two values is "
       << firstnum << endl; // the function is 
                                             //called here
 
  system("PAUSE");
  return 0;
}
#include <iostream>
using namespace std;


void Max(int& x, int& y)
{                    // start of function body
  int max; 
  int other;       // variable declaration

  if (x >= y) 
  {       // find the maximum number
    max = x;
  }
  else
  {
    (x <= y);
    
    max = y;
  }

}


int main()
{
  void Max( int& , int&);  // function declaration (prototype)
  int firstnum, secnum;

  cout << "\nEnter a number: ";
  cin  >> firstnum;
  cout << "Great! Please enter a second number: ";
  cin  >> secnum;

  cout << "\nThe maximum of these two values is "
       << firstnum << endl; // the function is 
                                             //called here

  system("PAUSE");
  return 0;
}

Last edited by WaltP; Mar 11th, 2007 at 3:07 pm. Reason: Fixed: 'language' means the language you are using -- like C or CPP...

Similar Threads

project plz who can help me in C++
bank system problem !!!! (C++ programming) in C++
Cannot get PAIR::big to just display greater number in C++
who can help me in c++ project in C++
Please help with data file and array in C++

nottoshabi

Reputation Points: 10

Solved Threads: 1

Light Poster

Offline

44 posts
since Mar 2007

Permalink

Mar 10th, 2007

Re: The greater number

Your function's prototype should not be inside another function, as your are doing here. It should also be BEFORE the function definition.

Change the function's return type from void to int. The return the value of 'max'. All that's necessary is for you to call the function in the cout call, and the value will be printed out.

By the way, how come you declare the variable 'other' when you don't have any use for it?

John A

Team Colleague

Reputation Points: 2240

Solved Threads: 338

Vampirical Lurker

Offline

5,055 posts
since Apr 2006

Permalink

Mar 10th, 2007

Re: The greater number

you should just output the maximum of the two:

C++ Syntax (Toggle Plain Text)
cout << "the max is " << max(firstnum, secondnum)) << endl;
cout << "the max is " << max(firstnum, secondnum)) << endl;

that said, your max function is wrong. It finds the max but should return the result. Here's a cleaner version:

C++ Syntax (Toggle Plain Text)
int max(int a, int b)
{
  if(a > b)
    return a;
  else
    return b;
}
int max(int a, int b)
{
  if(a > b)
    return a;
  else
    return b;
}

Infarction

Reputation Points: 683

Solved Threads: 53

Posting Virtuoso

Offline

1,580 posts
since May 2006

Permalink

Mar 10th, 2007

Re: The greater number

Click to Expand / Collapse Quote originally posted by joeprogrammer ...

All that's necessary is for you to call the function in the cout call, and the value will be printed out.

Click to Expand / Collapse Quote originally posted by Infarction ...

you should just output the maximum of the two:
C++ Syntax (Toggle Plain Text)
cout << "the max is " << max(firstnum, secondnum)) << endl;
cout << "the max is " << max(firstnum, secondnum)) << endl;

That's what I meant to say. Really. :o

John A

Team Colleague

Reputation Points: 2240

Solved Threads: 338

Vampirical Lurker

Offline

5,055 posts
since Apr 2006

Permalink

Mar 10th, 2007

Re: The greater number

I will try to switch that around. About the other I dont know. I'm new to this. It all looks like chinese to me right now. I get the code from the professor I just need to tweek it to his specifications. If you ask me why I do certain things i dont know. thats what i'm trying to figure out.

Thanks for the help guys.

nottoshabi

Reputation Points: 10

Solved Threads: 1

Light Poster

Offline

44 posts
since Mar 2007

Permalink

Mar 11th, 2007

Re: The greater number

Click to Expand / Collapse Quote originally posted by Infarction ...

Here's a cleaner version:
C++ Syntax (Toggle Plain Text)
int max(int a, int b)
{
  if(a > b)
    return a;
  else
    return b;
}
int max(int a, int b) { if(a > b) return a; else return b; }

Except multiple returns from a single function is frowned upon. Best to keep your original function with the return changes mentioned above, and with one other minor change:

c Syntax (Toggle Plain Text)
if (x >= y) 
{       // find the maximum number
    max = x;
}
else
{
//    (x <= y);    remove this line, it does nothing
    max = y;
}
if (x >= y) 
{       // find the maximum number
    max = x;
}
else
{
//    (x <= y);    remove this line, it does nothing
    max = y;
}

Last edited by WaltP; Mar 11th, 2007 at 3:14 pm.

WaltP

Moderator

Reputation Points: 3281

Solved Threads: 895

Posting Sage

Online

7,748 posts
since May 2006

Permalink

Mar 11th, 2007

Re: The greater number

Click to Expand / Collapse Quote originally posted by WaltP ...

Except multiple returns from a single function is frowned upon.

Hmm...now that is some news

The statement is not absolute as such. It all depends on the problem under consideration.

Last edited by ~s.o.s~; Mar 11th, 2007 at 4:15 pm.

~s.o.s~

Super Moderator

Featured Poster

Reputation Points: 3241

Solved Threads: 719

Failure as a human

Offline

8,873 posts
since Jun 2006

Permalink

Mar 11th, 2007

Re: The greater number

Click to Expand / Collapse Quote originally posted by WaltP ...

Except multiple returns from a single function is frowned upon.

That's more a matter of style for ease of maintenance, AFAICT. IMHO, this function is more clear this way, though if you want a single return, it could be done as

C++ Syntax (Toggle Plain Text)
int max(int a, int b) {
  return (a > b ? a : b);
}
int max(int a, int b) {
  return (a > b ? a : b);
}

but I didn't want to post that one for clarity's sake.

Infarction

Reputation Points: 683

Solved Threads: 53

Posting Virtuoso

Offline

1,580 posts
since May 2006

Permalink

Mar 12th, 2007

Re: The greater number

Click to Expand / Collapse Quote originally posted by ~s.o.s~ ...

The statement is not absolute as such. It all depends on the problem under consideration.

Which is why I stated it as I did -- not as an absolute.

Click to Expand / Collapse Quote originally posted by Infarction ...

That's more a matter of style for ease of maintenance, AFAICT. IMHO, this function is more clear this way, though if you want a single return, it could be done as
C++ Syntax (Toggle Plain Text)
int max(int a, int b) {
  return (a > b ? a : b);
}
int max(int a, int b) { return (a > b ? a : b); }
but I didn't want to post that one for clarity's sake.

Very good choice!!

Purists frown on multiple returns. They can be harder to debug because sometimes a return gets lost in complex or long functions. IMO, you should try to use only one return point if the code to support it does not make the code overly complex. But don't make the code difficult to read to accomplish it.

For this piece of code I'd probably use:

c Syntax (Toggle Plain Text)
int max(int a, int b)
{
    int rtn = a;
    if(a < b)  rtn = b;
    return rtn;
}
int max(int a, int b)
{
    int rtn = a;
    if(a < b)  rtn = b;
    return rtn;
}

WaltP

Moderator

Reputation Points: 3281

Solved Threads: 895

Posting Sage

Online

7,748 posts
since May 2006

Permalink

Mar 12th, 2007

Re: The greater number

I guess it will depend on the coding standards of the company you are working for. Here are two implementations of the function which finds the index of an element in the array and returns -1 if not found.

c Syntax (Toggle Plain Text)
// MULTIPLE RETURNS
 
int indexOf2 (int array[], int length, int element)
{
    for (int i = 0; i < length; ++i)
    {
        if (array [i] == element)
            return i ;
    }
    return -1 ;
}
 
// SINGLE RETURN
 
int indexOf1 (int array[], int length, int element)
{
    int index = -1 ;
 
    for (int i = 0; i < length; ++i)
    {
        if (array [i] == element)
        {
            index = i ;
            break ;     // btw even break and continue are frowned upon
        }
    }
    return index ;
}
// MULTIPLE RETURNS

int indexOf2 (int array[], int length, int element)
{
    for (int i = 0; i < length; ++i)
    {
        if (array [i] == element)
            return i ;
    }
    return -1 ;
}

// SINGLE RETURN

int indexOf1 (int array[], int length, int element)
{
    int index = -1 ;

    for (int i = 0; i < length; ++i)
    {
        if (array [i] == element)
        {
            index = i ;
            break ;     // btw even break and continue are frowned upon
        }
    }
    return index ;
}

Take your pick...

Last edited by ~s.o.s~; Mar 12th, 2007 at 12:49 pm.

~s.o.s~

Super Moderator

Featured Poster

Reputation Points: 3241

Solved Threads: 719

Failure as a human

Offline

8,873 posts
since Jun 2006

Page 1
2
Next

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: shouldn't this work??

Next Thread in C++ Forum Timeline: How to controll I/O in soundcard

DaniWeb Message

Cancel Changes

User Name
Password