Ad:

C++ Discussion Thread
Unsolved
Views: 2127

Page 1
2
3
Next

You are currently viewing page 1 of this multi-page discussion thread

Jun 16th, 2007

Please help with assignment

Expand Post »

What i have to create is a program that establishes 2 structs with arrays of CD Albums and then search the arrays for album names and display the album name, Artist or group, songs and their track numbers.
My question is; have i missed something in the code?, because it does not display the first album in the array when i do the search, it allows me to enter the name to search for but does not conduct the search, i would like to know what is wrong with the code.

thank you.

C++ Syntax (Toggle Plain Text)
#include<iostream>
#include<iomanip>
#include<cstdlib>
#include<string>
 
using namespace std;
 
struct Song
{
	string title;
	int track;
};
 
struct Album
{
	string albumName;
	string artistName;
	struct Song songList[4];
};
 
int main()
{
	Album collection[5];
 
	collection[0].albumName = "Private Investigations";
	collection[0].artistName = "Dire Straits";
	collection[0].songList[0].title = "Sultans of Swing";
	collection[0].songList[0].track = 2;
	collection[0].songList[1].title = "Romeo and Juliet ";
	collection[0].songList[1].track = 4;
	collection[0].songList[2].title = "Money for Nothing ";
	collection[0].songList[2].track = 9;
	collection[0].songList[3].title = "Walk of Life ";
	collection[0].songList[3].track = 10;
#include<iostream>
#include<iomanip>
#include<cstdlib>
#include<string>

using namespace std;

struct Song
{
	string title;
	int track;
};

struct Album
{
	string albumName;
	string artistName;
	struct Song songList[4];
};

int main()
{
	Album collection[5];
		
	collection[0].albumName = "Private Investigations";
	collection[0].artistName = "Dire Straits";
	collection[0].songList[0].title = "Sultans of Swing";
	collection[0].songList[0].track = 2;
	collection[0].songList[1].title = "Romeo and Juliet ";
	collection[0].songList[1].track = 4;
	collection[0].songList[2].title = "Money for Nothing ";
	collection[0].songList[2].track = 9;
	collection[0].songList[3].title = "Walk of Life ";
	collection[0].songList[3].track = 10;

C++ Syntax (Toggle Plain Text)
string albumName;
 
	cout<<"what album to search for? ";
	cin>> albumName;
}
 
int search(Album collection[], string albumName)
{
	int location;
	for(int i = 0; i<5; i++);
    {
		if(location == -1)			
			return -1;
		else
		<code class="inlinecode">cout<<"Album name is:"<<collection[i].albumName<<" "<<collection[i].artistName<<"at"<<location<<".";</code>
string albumName;

	cout<<"what album to search for? ";
	cin>> albumName;
}
	
int search(Album collection[], string albumName)
{
	int location;
	for(int i = 0; i<5; i++);
    {
		if(location == -1)			
			return -1;
		else
		<code class="inlinecode">cout<<"Album name is:"<<collection[i].albumName<<" "<<collection[i].artistName<<"at"<<location<<".";</code>

Similar Threads

Java Assignment Help Needed!!!!!!!!!! in Java
Help needed with VB Assignment in Visual Basic 4 / 5 / 6
Many Errors while doing this assignment in C
I need help on my 'address book' assignment! in C++

kpillsb39

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

16 posts
since Jun 2007

Permalink

Jun 16th, 2007

Re: Please help with assignment

Do you know how to compare strings?

iamthwee

Featured Poster

Reputation Points: 1536

Solved Threads: 431

Posting Expert

Offline

5,865 posts
since Aug 2005

Permalink

Jun 16th, 2007

Re: Please help with assignment

>have i missed something in the code?
Probably. You don't initialize or set the location variable in your search. So basically the entire thing is hopelessly broken as posted.

Narue

Administrator

Reputation Points: 6442

Solved Threads: 1393

Bad Cop

Offline

11,807 posts
since Sep 2004

Permalink

Jun 16th, 2007

Re: Please help with assignment

the semicolon after the for statement is a really bad idea. This for will only count up to 5, becouse with the ";" you close the loop statement. On the other hand you should compare the elements of the collection with the searched string.

C++ Syntax (Toggle Plain Text)
#include<iostream>
#include<iomanip>
#include<cstdlib>
#include<string>
 
using namespace std;
 
struct Song
{
	string title;
	int track;
};
 
struct Album
{
	string albumName;
	string artistName;
	struct Song songList[4];
};
 
int main()
{
	Album collection[5];
 
	collection[0].albumName = "Private Investigations";
	collection[0].artistName = "Dire Straits";
	collection[0].songList[0].title = "Sultans of Swing";
	collection[0].songList[0].track = 2;
	collection[0].songList[1].title = "Romeo and Juliet ";
	collection[0].songList[1].track = 4;
	collection[0].songList[2].title = "Money for Nothing ";
	collection[0].songList[2].track = 9;
	collection[0].songList[3].title = "Walk of Life ";
	collection[0].songList[3].track = 10;
#include<iostream>
#include<iomanip>
#include<cstdlib>
#include<string>

using namespace std;

struct Song
{
	string title;
	int track;
};

struct Album
{
	string albumName;
	string artistName;
	struct Song songList[4];
};

int main()
{
	Album collection[5];
		
	collection[0].albumName = "Private Investigations";
	collection[0].artistName = "Dire Straits";
	collection[0].songList[0].title = "Sultans of Swing";
	collection[0].songList[0].track = 2;
	collection[0].songList[1].title = "Romeo and Juliet ";
	collection[0].songList[1].track = 4;
	collection[0].songList[2].title = "Money for Nothing ";
	collection[0].songList[2].track = 9;
	collection[0].songList[3].title = "Walk of Life ";
	collection[0].songList[3].track = 10;

C++ Syntax (Toggle Plain Text)
string albumName;
 
	cout<<"what album to search for? ";
	cin>> albumName;
}
 
int search(Album collection[], string albumName)
{
 int location = -1;
  for(int i = 0; i<5; i++)
    if(strcmp(collection[i].albumName, albumName)==0)
    {
        location = i;break;
    }
   if (location != -1)
   {
     cout<<"Album name is:"<<collection[i].albumName<<" "<<collection[i].artistName<<"at"<<location<<".";
     return location;
   }
  else return -1;
}
string albumName;

	cout<<"what album to search for? ";
	cin>> albumName;
}
	
int search(Album collection[], string albumName)
{
 int location = -1;
  for(int i = 0; i<5; i++)
    if(strcmp(collection[i].albumName, albumName)==0)
    {
        location = i;break;
    }
   if (location != -1)
   {
     cout<<"Album name is:"<<collection[i].albumName<<" "<<collection[i].artistName<<"at"<<location<<".";
     return location;
   }
  else return -1;
}

[/QUOTE]

Last edited by Chaster; Jun 16th, 2007 at 2:05 pm.

Chaster

Reputation Points: 12

Solved Threads: 3

Junior Poster in Training

Offline

68 posts
since Jun 2007

Permalink

Jun 16th, 2007

Re: Please help with assignment

C++ Syntax (Toggle Plain Text)
for(int i = 0; i<5; i++)
  if(strcmp(collection[i].albumName, albumName)==0)
  {
    location = i;break;
  }
for(int i = 0; i<5; i++)
  if(strcmp(collection[i].albumName, albumName)==0)
  {
    location = i;break;
  }

That's a good way to confuse the hell out of readers and introduce subtle scoping bugs. My general guideline for blocks with optional braces is that if there's a one line statement, you can go ahead with the omission. If the block has more than one line, including comments, use braces. So your code would be:

C++ Syntax (Toggle Plain Text)
for(int i = 0; i<5; i++)
{
  if(strcmp(collection[i].albumName, albumName)==0)
  {
    location = i;break;
  }
}
for(int i = 0; i<5; i++)
{
  if(strcmp(collection[i].albumName, albumName)==0)
  {
    location = i;break;
  }
}

Of course, that brings me to the real error, which is using strcmp with std::string objects. Not such a hot idea, especially since the string class overloads the == operator for comparison. I'm guessing you didn't compile that code.

C++ Syntax (Toggle Plain Text)
if (location != -1)
{
  cout<<"Album name is:"<<collection[i].albumName<<" "<<collection[i].artistName<<"at"<<location<<".";
  return location;
}
else return -1;
if (location != -1)
{
  cout<<"Album name is:"<<collection[i].albumName<<" "<<collection[i].artistName<<"at"<<location<<".";
  return location;
}
else return -1;

I think you fell into the trap that I described above. The second if statement isn't inside the loop. The code shouldn't compile because i isn't visible anymore.

On top of that, you've complicated the function a little too much. It could be as simple as this:

C++ Syntax (Toggle Plain Text)
int search ( Album collection[], int size, string albumName )
{
  for ( int i = 0; i < size; i++ ) {
    if ( collection[i].albumName == albumName )
      return i;
  }
 
  return -1;
}
int search ( Album collection[], int size, string albumName )
{
  for ( int i = 0; i < size; i++ ) {
    if ( collection[i].albumName == albumName )
      return i;
  }

  return -1;
}

And of course, unless you know for a fact that your code will compile and run as expected (which I do in this case), you should write a test framework. Something like so:

C++ Syntax (Toggle Plain Text)
int main()
{
  Album collection[5];
 
  collection[0].albumName = "Private Investigations1";
  collection[1].albumName = "Private Investigations2";
  collection[2].albumName = "Private Investigations3";
  collection[3].albumName = "Private Investigations4";
  collection[4].albumName = "Private Investigations5";
 
  cout<< search ( collection, 5, "Private Investigations1" ) <<'\n';
  cout<< search ( collection, 5, "Private Investigations2" ) <<'\n';
  cout<< search ( collection, 5, "Private Investigations3" ) <<'\n';
  cout<< search ( collection, 5, "Private Investigations4" ) <<'\n';
  cout<< search ( collection, 5, "Private Investigations5" ) <<'\n';
  cout<< search ( collection, 5, "Private Investigations" ) <<'\n';
}
int main()
{
  Album collection[5];

  collection[0].albumName = "Private Investigations1";
  collection[1].albumName = "Private Investigations2";
  collection[2].albumName = "Private Investigations3";
  collection[3].albumName = "Private Investigations4";
  collection[4].albumName = "Private Investigations5";

  cout<< search ( collection, 5, "Private Investigations1" ) <<'\n';
  cout<< search ( collection, 5, "Private Investigations2" ) <<'\n';
  cout<< search ( collection, 5, "Private Investigations3" ) <<'\n';
  cout<< search ( collection, 5, "Private Investigations4" ) <<'\n';
  cout<< search ( collection, 5, "Private Investigations5" ) <<'\n';
  cout<< search ( collection, 5, "Private Investigations" ) <<'\n';
}

Narue

Administrator

Reputation Points: 6442

Solved Threads: 1393

Bad Cop

Offline

11,807 posts
since Sep 2004

Permalink

Jun 16th, 2007

Re: Please help with assignment

I appreciate all who have posted to this Thread, but when i compile, i get no errors, but when i type in the name of the album to search the array for. it returns the statement

Quote ...

Press any key to continue.

With this, why is it not searching the array?
or is it and not finding the album name.

kpillsb39

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

16 posts
since Jun 2007

Permalink

Jun 16th, 2007

Re: Please help with assignment

You'll need to post your current code.

Narue

Administrator

Reputation Points: 6442

Solved Threads: 1393

Bad Cop

Offline

11,807 posts
since Sep 2004

Permalink

Jun 16th, 2007

Re: Please help with assignment

I have added additional album names, artists, songs and track numbers to the array.

I also made the changes that were submitted in this thread and compiled with no errors.

Still no results.

C++ Syntax (Toggle Plain Text)
#include<iostream>
#include<iomanip>
#include<cstdlib>
#include<string>
 
using namespace std;
 
struct Song
{
	string title;
	int track;
};
 
struct Album
{
	string albumName;
	string artistName;
	struct Song songList[4];
};
 
int main()
{
	Album collection[5];
 
	collection[0].albumName = "Private Investigations";
	collection[0].artistName = "Dire Straits";
	collection[0].songList[0].title = "Sultans of Swing";
	collection[0].songList[0].track = 2;
	collection[0].songList[1].title = "Romeo and Juliet ";
	collection[0].songList[1].track = 4;
	collection[0].songList[2].title = "Money for Nothing ";
	collection[0].songList[2].track = 9;
	collection[0].songList[3].title = "Walk of Life ";
	collection[0].songList[3].track = 10;
	collection[1].albumName = "The Millennium Collection";
	collection[1].artistName = "The Who";
	collection[1].songList[0].title = "My Generation ";
	collection[1].songList[0].track = 1;
	collection[1].songList[1].title = "Pinball Wizard ";
	collection[1].songList[1].track = 2;
	collection[1].songList[2].title = "Who are You ";
	collection[1].songList[2].track = 3;
	collection[1].songList[3].title = "Squeeze Box ";
	collection[2].songList[3].track = 4;
	collection[2].albumName = "Moving Pictures";
	collection[2].artistName = "RUSH";
	collection[2].songList[0].title = "Tom Sawyer";
	collection[2].songList[0].track = 1;
	collection[2].songList[1].title = "Rad Barchetta";
	collection[2].songList[1].track = 2;
	collection[2].songList[2].title = "YYZ";
	collection[2].songList[2].track = 3;
	collection[2].songList[3].title = "Limelight";
	collection[2].songList[3].track = 4;
	collection[3].albumName = "The Best of 3 Dog Night";
	collection[3].artistName = "3 Dog Night";
	collection[3].songList[0].title = "Joy to the World";
	collection[3].songList[0].track = 1;
	collection[3].songList[1].title = "Easy to be Hard";
	collection[3].songList[1].track = 2;
	collection[3].songList[2].title = "Family of Man";
	collection[3].songList[2].track = 3;
	collection[3].songList[3].title = "Sure as i'm sitting here";
	collection[3].songList[3].track = 4;
	collection[4].albumName = "The Best of Deep Purple";
	collection[4].artistName = "Deep Purple";
	collection[4].songList[0].title = "HUSH";
	collection[4].songList[0].track = 1;
	collection[4].songList[1].title = "Kentucky Woman";
	collection[4].songList[1].track = 2;
	collection[4].songList[2].title = "Black Night";
	collection[4].songList[2].track = 3;
	collection[4].songList[3].title = "Speed King";
	collection[4].songList[3].track = 4;
 
	string albumName;
	cout<<"What album to search for? ";
	cin>> albumName;
 
}		
int search(Album collection[], int size, string albumName)
{
	for(int i = 0; i<size; i++)
               {	
		if (collection[i].albumName == albumName)
		return i;
	}
	return -1;
}
#include<iostream>
#include<iomanip>
#include<cstdlib>
#include<string>

using namespace std;

struct Song
{
	string title;
	int track;
};

struct Album
{
	string albumName;
	string artistName;
	struct Song songList[4];
};

int main()
{
	Album collection[5];
		
	collection[0].albumName = "Private Investigations";
	collection[0].artistName = "Dire Straits";
	collection[0].songList[0].title = "Sultans of Swing";
	collection[0].songList[0].track = 2;
	collection[0].songList[1].title = "Romeo and Juliet ";
	collection[0].songList[1].track = 4;
	collection[0].songList[2].title = "Money for Nothing ";
	collection[0].songList[2].track = 9;
	collection[0].songList[3].title = "Walk of Life ";
	collection[0].songList[3].track = 10;
	collection[1].albumName = "The Millennium Collection";
	collection[1].artistName = "The Who";
	collection[1].songList[0].title = "My Generation ";
	collection[1].songList[0].track = 1;
	collection[1].songList[1].title = "Pinball Wizard ";
	collection[1].songList[1].track = 2;
	collection[1].songList[2].title = "Who are You ";
	collection[1].songList[2].track = 3;
	collection[1].songList[3].title = "Squeeze Box ";
	collection[2].songList[3].track = 4;
	collection[2].albumName = "Moving Pictures";
	collection[2].artistName = "RUSH";
	collection[2].songList[0].title = "Tom Sawyer";
	collection[2].songList[0].track = 1;
	collection[2].songList[1].title = "Rad Barchetta";
	collection[2].songList[1].track = 2;
	collection[2].songList[2].title = "YYZ";
	collection[2].songList[2].track = 3;
	collection[2].songList[3].title = "Limelight";
	collection[2].songList[3].track = 4;
	collection[3].albumName = "The Best of 3 Dog Night";
	collection[3].artistName = "3 Dog Night";
	collection[3].songList[0].title = "Joy to the World";
	collection[3].songList[0].track = 1;
	collection[3].songList[1].title = "Easy to be Hard";
	collection[3].songList[1].track = 2;
	collection[3].songList[2].title = "Family of Man";
	collection[3].songList[2].track = 3;
	collection[3].songList[3].title = "Sure as i'm sitting here";
	collection[3].songList[3].track = 4;
	collection[4].albumName = "The Best of Deep Purple";
	collection[4].artistName = "Deep Purple";
	collection[4].songList[0].title = "HUSH";
	collection[4].songList[0].track = 1;
	collection[4].songList[1].title = "Kentucky Woman";
	collection[4].songList[1].track = 2;
	collection[4].songList[2].title = "Black Night";
	collection[4].songList[2].track = 3;
	collection[4].songList[3].title = "Speed King";
	collection[4].songList[3].track = 4;

	string albumName;
	cout<<"What album to search for? ";
	cin>> albumName;

}		
int search(Album collection[], int size, string albumName)
{
	for(int i = 0; i<size; i++)
               {	
		if (collection[i].albumName == albumName)
		return i;
	}
	return -1;
}

Thank you.

kpillsb39

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

16 posts
since Jun 2007

Permalink

Jun 16th, 2007

Re: Please help with assignment

You need to call your search function. Just defining it doesn't do anything.

Narue

Administrator

Reputation Points: 6442

Solved Threads: 1393

Bad Cop

Offline

11,807 posts
since Sep 2004

Permalink

Jun 16th, 2007

Re: Please help with assignment

Narue,
Sorry but you lost me with the call the search function, i must have missed that portion of the class.

What and where in the code should it go.

Thank you.

kpillsb39

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

16 posts
since Jun 2007

Page 1
2
3
Next

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: Coressponding Linux function/library out of Win32...

Next Thread in C++ Forum Timeline: Doubts about References

DaniWeb Message

Cancel Changes

User Name
Password