Help me! C++

Expand Post »

Hey guys!

CAn u tell me if my program is right?

First, I need to get a Pkg and validate;
Second,get month and validate;
Third, determinate max hours;
*If FEB;
Fourth, get year and validate(1990-2020)
check for leap yr.
Fifth, get hours and validate against maxhours;
and calculate the bill ^^(month)

I have 3 pkg
PKG A = $12 month
PKG B = $18 " " "
PKG C = $25 " " "

Thank you!!

Thx

C++ Syntax (Toggle Plain Text)
#include <iostream>
using namespace std;
 
 
void main()
{
	int mDays;
	int maxhours;
 
    char pkg = 'Z';
		cout<<"Enter pkg A, B or C: ";
	    cin >> pkg;
 
    if( pkg == 'A'||pkg =='a' ||pkg =='b' ||pkg == 'B'|| pkg == 'C'||pkg =='c' )
    {
        int month;
        cout<<"Enter Month 1 through 12: ";
        cin>>month;
 
		if(month>=1 && month<=12)
			{
			int hrs;
			    cout<<"Enter hrs: ";
				cin>>hrs;
				if (month==1||month==3||month==5||month==7||month==8||month==10||month==12)
				{
						mDays = 31;
						maxhours = 744;
				}
				else if(month== 4 || month==6 || month==9 || month==11)
				{
						mDays = 30;
						maxhours = 720;
 
				}				
				else if(month ==2)
				{
						mDays = 28;
						maxhours = 672;
				}
				else
				{
					   mDays = 29;
					   maxhours = 696;
				}
 
				   int yr;
				   cout<<"Enter Year 1990 - 2020"<<endl;
				  cin>>yr;
 
					if(yr>=1990 && month<=2020)
					{
						if((yr%4)!=0) //leap year
						{
 
						}
 
 
 
				                }
					else
					{
				     cout<<" Year " << yr << " invalid "<<endl; 
					}
 
 
 
			}
 
		else
			{
			cout<<"Month " << month << " invalid"<<endl; 
			}
 
 
 
	}
 
	else
	{
		cout<<"Inalid pkg value"<<endl;
	}
}//end main
#include <iostream>
using namespace std;


void main()
{
	int mDays;
	int maxhours;

    char pkg = 'Z';
		cout<<"Enter pkg A, B or C: ";
	    cin >> pkg;
    
    if( pkg == 'A'||pkg =='a' ||pkg =='b' ||pkg == 'B'|| pkg == 'C'||pkg =='c' )
    {
        int month;
        cout<<"Enter Month 1 through 12: ";
        cin>>month;

		if(month>=1 && month<=12)
			{
			int hrs;
			    cout<<"Enter hrs: ";
				cin>>hrs;
				if (month==1||month==3||month==5||month==7||month==8||month==10||month==12)
				{
						mDays = 31;
						maxhours = 744;
				}
				else if(month== 4 || month==6 || month==9 || month==11)
				{
						mDays = 30;
						maxhours = 720;
						
				}				
				else if(month ==2)
				{
						mDays = 28;
						maxhours = 672;
				}
				else
				{
					   mDays = 29;
					   maxhours = 696;
				}
					
				   int yr;
				   cout<<"Enter Year 1990 - 2020"<<endl;
				  cin>>yr;

					if(yr>=1990 && month<=2020)
					{
						if((yr%4)!=0) //leap year
						{
							
						}



				                }
					else
					{
				     cout<<" Year " << yr << " invalid "<<endl; 
					}
				
					
				
			}

		else
			{
			cout<<"Month " << month << " invalid"<<endl; 
			}


		
	}
	
	else
	{
		cout<<"Inalid pkg value"<<endl;
	}
}//end main

Last edited by Ancient Dragon; Sep 15th, 2007 at 6:28 pm. Reason: add code tags

leolima

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

1 posts
since Sep 2007

Permalink

Sep 15th, 2007

Re: Help me! C++

It almost looks like you threw something out in the wind in the hopes that someone will fix it up for you. Clean up your code with indentation to begin with so it's a little more legible. Then run it to see if you get the results you expect. Right off hand without spending to much time it appears the only time leaps years will be evaluated is when the month is less than 1 or greater than 12.

Please enclose your next post in code tags.

C++ Syntax (Toggle Plain Text)
 					if(yr>=1990 && month<=2020)
 					if(yr>=1990 && month<=2020)

You see the problem here.

Tight_Coder_Ex

Reputation Points: 47

Solved Threads: 17

Posting Whiz in Training

Offline

215 posts
since Feb 2005

Permalink

Sep 15th, 2007

Re: Help me! C++

C++ Syntax (Toggle Plain Text)
 
#include <iostream>
 
using namespace std; 
 
int main()
{
  int mDays;
  int maxhours;
  char pkg = 'Z';
  cout << "Enter pkg A, B or C: ";
  cin >> pkg;
  if ( pkg == 'A' || pkg == 'a' || pkg == 'b' 
      || pkg == 'B' || pkg == 'C' || pkg == 'c' )
  {
    int month;
    cout << "Enter Month 1 through 12: ";
    cin >> month;
    if ( month >= 1 && month <= 12 )
    {
      int hrs;
      cout << "Enter hrs: ";
      cin >> hrs;
      if ( month == 1 || month == 3 || month == 5 
          || month == 7 || month == 8 || month == 10 || month == 12 )
      {
        mDays = 31;
        maxhours = 744;
      }
      else if ( month == 4 || month == 6 || month == 9 || month == 11 )
      {
        mDays = 30;
        maxhours = 720;
      }
      else if ( month == 2 )
      {
        mDays = 28;
        maxhours = 672;
      }
      else
      {
        mDays = 29;
        maxhours = 696;
      }
      int yr;
      cout << "Enter Year 1990 - 2020" << endl;
      cin >> yr;
      if ( yr >= 1990 && month <= 2020 )
      {
        if ( ( yr % 4 ) != 0 ) //leap year
        {
        } 
      }
      else
      {
        cout << " Year " << yr << " invalid " << endl;
      } 
    }
    else
    {
      cout << "Month " << month << " invalid" << endl;
    } 
  }
  else
  {
    cout << "Inalid pkg value" << endl;
  }
}
 
#include <iostream>
 
using namespace std; 
 
int main()
{
  int mDays;
  int maxhours;
  char pkg = 'Z';
  cout << "Enter pkg A, B or C: ";
  cin >> pkg;
  if ( pkg == 'A' || pkg == 'a' || pkg == 'b' 
      || pkg == 'B' || pkg == 'C' || pkg == 'c' )
  {
    int month;
    cout << "Enter Month 1 through 12: ";
    cin >> month;
    if ( month >= 1 && month <= 12 )
    {
      int hrs;
      cout << "Enter hrs: ";
      cin >> hrs;
      if ( month == 1 || month == 3 || month == 5 
          || month == 7 || month == 8 || month == 10 || month == 12 )
      {
        mDays = 31;
        maxhours = 744;
      }
      else if ( month == 4 || month == 6 || month == 9 || month == 11 )
      {
        mDays = 30;
        maxhours = 720;
      }
      else if ( month == 2 )
      {
        mDays = 28;
        maxhours = 672;
      }
      else
      {
        mDays = 29;
        maxhours = 696;
      }
      int yr;
      cout << "Enter Year 1990 - 2020" << endl;
      cin >> yr;
      if ( yr >= 1990 && month <= 2020 )
      {
        if ( ( yr % 4 ) != 0 ) //leap year
        {
        } 
      }
      else
      {
        cout << " Year " << yr << " invalid " << endl;
      } 
    }
    else
    {
      cout << "Month " << month << " invalid" << endl;
    } 
  }
  else
  {
    cout << "Inalid pkg value" << endl;
  }
}

Your if else statements look rather odd at first glance? Maybe?

iamthwee

Featured Poster

Reputation Points: 1536

Solved Threads: 431

Posting Expert

Offline

5,865 posts
since Aug 2005

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: coin toss problem

Next Thread in C++ Forum Timeline: windows api help

DaniWeb Message

Cancel Changes

User Name
Password