Ad:

C++ Discussion Thread
Unsolved
Views: 5326

Oct 28th, 2007

Program that finds prime numbers

Expand Post »

So after a day or two of trying i finally found out how to do this, my question is, is there any way to do this that is more efficient without using the prime function?

C++ Syntax (Toggle Plain Text)
#include <iostream>
using namespace std;
 
 
      int main()
{
 std::string line;
 
 int i, p, x;
 
 for(i = 3; i <=100; i++) {
 
       for(p=2; p<i; p++)
       {
                if((i%p) == 0) x = 0;
                }
                if(x != 0) cout << i << " is prime\n";
                x = 1;
                }
 
 
 
 
 getline(cin,line);
 cin.get();
 
 return 0;
}
#include <iostream>
using namespace std;


      int main()
{
 std::string line;
 
 int i, p, x;
 
 for(i = 3; i <=100; i++) {
       
       for(p=2; p<i; p++)
       {
                if((i%p) == 0) x = 0;
                }
                if(x != 0) cout << i << " is prime\n";
                x = 1;
                }
       
       
        
    
 getline(cin,line);
 cin.get();
 
 return 0;
}

Similar Threads

Print Prime Numbers(using for loop) in C
Program to output all prime numbers between 3 and 100 in C++
My prime Number generator in Python
Finding Prime numbers without using Boolean in C++
how do u find prime numbers in an array in C

people123

Reputation Points: 10

Solved Threads: 1

Newbie Poster

Offline

22 posts
since Oct 2007

Permalink

Oct 28th, 2007

Re: Program that finds prime numbers

The formatting is terrible, maybe you have a mixture of tabs and spaces. I think you have a couple misplaced braces.

Last edited by Ancient Dragon; Oct 28th, 2007 at 8:48 pm.

Ancient Dragon

Sponsor

Team Colleague

Featured Poster

Reputation Points: 5608

Solved Threads: 2282

Retired and Enjoying Life

Offline

21,953 posts
since Aug 2005

Permalink

Oct 28th, 2007

Re: Program that finds prime numbers

how should i improve my formatting, can you please give me an example... i just get lost of what has to be where when im writing

people123

Reputation Points: 10

Solved Threads: 1

Newbie Poster

Offline

22 posts
since Oct 2007

Permalink

Oct 28th, 2007

Re: Program that finds prime numbers

example. Note placement of braces and spacing. For more information read this by the author of the c++ language.

C++ Syntax (Toggle Plain Text)
#include <iostream>
using namespace std;
 
 
int main()
{
    std::string line;
 
    int i, p, x;
 
    for(i = 3; i <=100; i++) 
    {     
       for(p=2; p<i; p++)
       {
            if((i%p) == 0) 
                x = 0;
       }
       if(x != 0) 
             cout << i << " is prime\n";
       x = 1;
    }
    getline(cin,line);
    cin.get();
    return 0;
}
#include <iostream>
using namespace std;


int main()
{
    std::string line;
 
    int i, p, x;
 
    for(i = 3; i <=100; i++) 
    {     
       for(p=2; p<i; p++)
       {
            if((i%p) == 0) 
                x = 0;
       }
       if(x != 0) 
             cout << i << " is prime\n";
       x = 1;
    }
    getline(cin,line);
    cin.get();
    return 0;
}

Last edited by Ancient Dragon; Oct 28th, 2007 at 9:27 pm.

Ancient Dragon

Sponsor

Team Colleague

Featured Poster

Reputation Points: 5608

Solved Threads: 2282

Retired and Enjoying Life

Offline

21,953 posts
since Aug 2005

Permalink

Oct 29th, 2007

Re: Program that finds prime numbers

Click to Expand / Collapse Quote originally posted by people123 ...

how should i improve my formatting, can you please give me an example... i just get lost of what has to be where when im writing

Here's a turotial on Formatting C / C++ code

WaltP

Moderator

Reputation Points: 3278

Solved Threads: 894

Posting Sage

Offline

7,744 posts
since May 2006

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in C++ Forum Timeline: constructor arguments with new

Next Thread in C++ Forum Timeline: string to non const char?

DaniWeb Message

Cancel Changes

User Name
Password