Ad:

C# Discussion Thread
Unsolved
Views: 22475

Sep 29th, 2005

random number display the same

Expand Post »

im having problems with the following code
it works fine when i have the sleep in
but without the sleep it writes the same number twice
does this have something to do with the way the computer generates the random number? like based on the computers time?

C# Syntax (Toggle Plain Text)
 
 
using System;
using System.Threading;
 
 
namespace RandomNumber
{
   class RandNum
   {
      [STAThread]
      static void Main(string[] args)
      {
         Console.WriteLine("Random number pairs from 1-6 - type \"q\" to quit");
 
         Console.WriteLine("{0}, {1}", GetRandNum(1,6), GetRandNum(1,6));
         string p = "";
         while(p != "q")
         {
            p = Console.ReadLine();
            if(p == "")
            {
 
               Console.WriteLine("{0}, {1}", GetRandNum(1,6), GetRandNum(1,6));
            }
 
 
      }
      static int GetRandNum(int iStart, int iEnd)
      {
 
 
         Random r = new Random();
 
//         //sleeping helps generate random number
         Thread.Sleep(r.Next(100));
 
         int i = r.Next(iStart, iEnd * iEnd);
         i = i/iEnd + 1;
         return i;
 
      }
 
   }
}
 

using System;
using System.Threading;


namespace RandomNumber
{
   class RandNum
   {
      [STAThread]
      static void Main(string[] args)
      {
         Console.WriteLine("Random number pairs from 1-6 - type \"q\" to quit");

         Console.WriteLine("{0}, {1}", GetRandNum(1,6), GetRandNum(1,6));
         string p = "";
         while(p != "q")
         {
            p = Console.ReadLine();
            if(p == "")
            {

               Console.WriteLine("{0}, {1}", GetRandNum(1,6), GetRandNum(1,6));
            }
         

      }
      static int GetRandNum(int iStart, int iEnd)
      {
         

         Random r = new Random();

//         //sleeping helps generate random number
         Thread.Sleep(r.Next(100));

         int i = r.Next(iStart, iEnd * iEnd);
         i = i/iEnd + 1;
         return i;

      }

   }
}

Similar Threads

plazmo

Reputation Points: 23

Solved Threads: 16

Posting Whiz in Training

Offline

206 posts
since Aug 2005

Permalink

Sep 29th, 2005

Re: random number display the same

Greeting:
That a usual problem with random number, the best way to minimize this to use a seed for the random based on the actual time, something like this:

C# Syntax (Toggle Plain Text)
DateTime x=DateTime.Now();
float mins=x.Minute;
float secs=x.Second;
float hour=x.Hour;
Random r=new Random((secs*mins)+hour);
DateTime x=DateTime.Now();
float mins=x.Minute;
float secs=x.Second;
float hour=x.Hour;
Random r=new Random((secs*mins)+hour);

This way unless you run your program at the exact same hour every time, you`ll have different random numbers each time.

ROGENATOR

Reputation Points: 11

Solved Threads: 0

Newbie Poster

Offline

17 posts
since Sep 2005

Permalink

Sep 29th, 2005

Re: random number display the same

i fixed it, it was because i was creating 2 new randoms at the same time which gave them both the same seed.
so i just made outside the method

C# Syntax (Toggle Plain Text)
using System;
using System.Threading;
 
 
namespace RandomNumber
{
	class RandNum
	{
		private static Random rNum = new Random();
		[STAThread]
		static void Main(string[] args)
		{
			int iMin = 1;
			int iMax = 6;
			Console.WriteLine("Random number pairs from 1-6 - type \"q\" to quit");
			string p = "";
			while(p != "q")
			{
				if(p == "")
				{
					Console.WriteLine("{0}, {1}", rNum.Next(iMin, iMax), rNum.Next(iMin, iMax));
				}
 
				p = Console.ReadLine();
			}
 
		}
 
	}
}
using System;
using System.Threading;


namespace RandomNumber
{
	class RandNum
	{
		private static Random rNum = new Random();
		[STAThread]
		static void Main(string[] args)
		{
			int iMin = 1;
			int iMax = 6;
			Console.WriteLine("Random number pairs from 1-6 - type \"q\" to quit");
			string p = "";
			while(p != "q")
			{
				if(p == "")
				{
					Console.WriteLine("{0}, {1}", rNum.Next(iMin, iMax), rNum.Next(iMin, iMax));
				}

				p = Console.ReadLine();
			}

		}

	}
}

plazmo

Reputation Points: 23

Solved Threads: 16

Posting Whiz in Training

Offline

206 posts
since Aug 2005

Permalink

Nov 5th, 2008

Re: random number display the same

Standard way to create random numbers is to create a Random object in class wide or global scope and use object's Next() method to get next random number.

This article explains this in detail.

h2c357

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

8 posts
since Oct 2006

Permalink

Nov 5th, 2008

Re: random number display the same

way to dredge up a 3 yr old post.

LizR

Reputation Points: 196

Solved Threads: 190

Posting Virtuoso

Offline

1,735 posts
since Aug 2008

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

This thread is currently closed and is not accepting any new replies.

Previous Thread in C# Forum Timeline: Project Hangs

Next Thread in C# Forum Timeline: HttpWebRequest on port 8000

DaniWeb Message

Cancel Changes

User Name
Password