Ad:

Java Discussion Thread
Marked Solved
Views: 1076

Feb 23rd, 2009

Moving Files

Expand Post »

Hi Folks,
I am having difficult with a program. I have a program that downloads a file to the directory it is being run from and I need to move it to another one after its done downloading.

I found code that should do it but it keeps failing, and driving me up the wall.

java Syntax (Toggle Plain Text)
import java.io.File;
 
public class main{
	public static void main(String[] args){
	// File (or directory) to be moved
	    File file = new File("test.txt");
 
	    // Destination directory
	    File dir = new File("C:\\Program Files\\WOOT_IT_WORKED.txt");
 
	    // Move file to new directory
	    boolean success = file.renameTo(new File(dir, file.getName()));
	    if (!success) {
	        System.out.println("Move Failed");
	    }
	}
}
import java.io.File;

public class main{
	public static void main(String[] args){
	// File (or directory) to be moved
	    File file = new File("test.txt");
	    
	    // Destination directory
	    File dir = new File("C:\\Program Files\\WOOT_IT_WORKED.txt");
	    
	    // Move file to new directory
	    boolean success = file.renameTo(new File(dir, file.getName()));
	    if (!success) {
	        System.out.println("Move Failed");
	    }
	}
}

Last edited by PhiberOptik; Feb 23rd, 2009 at 4:31 pm.

Similar Threads

Moving files in c and c++ in C++
Moving Files with Dreamweaver in IT Professionals' Lounge
Files won't move or delete! in Storage
can't link to included files... y? in C++
Downloading music files to MP3 player in Windows 95 / 98 / Me

PhiberOptik

Reputation Points: 10

Solved Threads: 4

Junior Poster

Offline

164 posts
since May 2008

Permalink

Feb 23rd, 2009

Re: Moving Files

If the file you want to copy is already used by an another process (if this is it), you cannot have access to it (except if you have special permissions).

This is very useful program for spotting file handles for every process: Process Explorer. Google it if you have a chance.

GDICommander

Reputation Points: 72

Solved Threads: 26

Posting Whiz in Training

Offline

209 posts
since Jun 2008

Permalink

Feb 23rd, 2009

Re: Moving Files

Okay, I checked out the Process Explorer program. Also, those files are just text files that I are not being used at all. I'm just testing the program right now...

PhiberOptik

Reputation Points: 10

Solved Threads: 4

Junior Poster

Offline

164 posts
since May 2008

Permalink

Feb 23rd, 2009

Re: Moving Files

On which OS are you using?. It may not do a difference, but the "slash-backslash" complexity can cause this.

Otherwise, look at the renameTo method. Look for special permissions or existence of the source file.

Last edited by GDICommander; Feb 23rd, 2009 at 4:49 pm.

GDICommander

Reputation Points: 72

Solved Threads: 26

Posting Whiz in Training

Offline

209 posts
since Jun 2008

Permalink

Apr 18th, 2009

Re: Moving Files

This thread is marked "solved" but there is no solution posted. I will add that I believe it is the case that the issue lies with the location of the original file, which is not specified when the File object is created. Therefore, whether the move works or not will depend entirely on where the application expects the file to be when no absolute path is provided.

The code being used was probably picked up from one of a couple of places on the web that demonstrate this technique, and employ this same mistaken approach. Specify the absolute path to the original file and the code will work as expected. It's never a good idea to depend on the application's ability to figure out where the file is. Execution context will often make hash of your expectations.

Thanks.

mp

naugiedoggie

Reputation Points: 10

Solved Threads: 1

Newbie Poster

Offline

12 posts
since Apr 2009

Permalink

Apr 19th, 2009

Re: Moving Files

Would you be kind enough to post some code that moves file the correct way?

PhiberOptik

Reputation Points: 10

Solved Threads: 4

Junior Poster

Offline

164 posts
since May 2008

Permalink

Apr 19th, 2009

Re: Moving Files

Click to Expand / Collapse Quote originally posted by PhiberOptik ...

Would you be kind enough to post some code that moves file the correct way?

Hello,

Here you go. This example is extracted from an application that moves log files around. It works.

Thanks.

mp

Java Syntax (Toggle Plain Text)
 
 
import java.io.File;
 
public class LogMover{
 
	private String fileOrigin = null;
	private String fileDestination = null;
 
 
    public LogMover(String origin, String dest){
        this.setFileOrigin(origin);
        this.setFileDestination(dest);
    }
 
    public static void main(String[] args) {
 
        String origin = "\\\\ctpowem01\\origin\\";
        String dest = "\\\\ctpowem01\\dest\\";
 
        LogMover lm = new LogMover(origin,dest);
        lm.moveFiles();
 
        System.out.println("move completed.");
    } // end main
 
    public void moveFiles(){
        boolean moved = false;
        File origin = new File(this.getFileOrigin());
 
        File [] files = origin.listFiles();
 
        for (int i=0; i<files.length; i++){
            File dir = new File(this.getFileDestination());
 
            moved = files[i].renameTo(new File(dir,files[i].getName()));
            if(moved != true){
                System.out.println("file " + files[i].getName() + " not moved.");
            }
        }
	} // end moveFiles
 
    public String getFileOrigin(){
        return fileOrigin;
    }
 
    public void setFileOrigin(String newPath){
        fileOrigin = newPath;
    }
 
    public String getFileDestination() {
        return fileDestination;
    }
 
    public void setFileDestination(String fileDestination) {
        this.fileDestination = fileDestination;
    }
 
} // end class
 

import java.io.File;

public class LogMover{
	
	private String fileOrigin = null;
	private String fileDestination = null;
	

    public LogMover(String origin, String dest){
        this.setFileOrigin(origin);
        this.setFileDestination(dest);
    }

    public static void main(String[] args) {

        String origin = "\\\\ctpowem01\\origin\\";
        String dest = "\\\\ctpowem01\\dest\\";
        
        LogMover lm = new LogMover(origin,dest);
        lm.moveFiles();

        System.out.println("move completed.");
    } // end main
	
    public void moveFiles(){
        boolean moved = false;
        File origin = new File(this.getFileOrigin());

        File [] files = origin.listFiles();

        for (int i=0; i<files.length; i++){
            File dir = new File(this.getFileDestination());
            
            moved = files[i].renameTo(new File(dir,files[i].getName()));
            if(moved != true){
                System.out.println("file " + files[i].getName() + " not moved.");
            }
        }
	} // end moveFiles
	
    public String getFileOrigin(){
        return fileOrigin;
    }

    public void setFileOrigin(String newPath){
        fileOrigin = newPath;
    }
	
    public String getFileDestination() {
        return fileDestination;
    }

    public void setFileDestination(String fileDestination) {
        this.fileDestination = fileDestination;
    }
	
} // end class

naugiedoggie

Reputation Points: 10

Solved Threads: 1

Newbie Poster

Offline

12 posts
since Apr 2009

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in Java Forum Timeline: ArrayIndexOutOfBoundsException: 1

Next Thread in Java Forum Timeline: Create & start threads with loop

DaniWeb Message

Cancel Changes

User Name
Password