Ad:

Java Discussion Thread
Marked Solved
Views: 1199

Sep 25th, 2009

Java Appointment Book

Expand Post »

Good evening, all!

My current assignment is a small Appointment Book written in Java. It should scroll through the times of the day, and display the appointment (if any) for that particular time of day.

I can scroll through the different times with no issue, but I can't seem to get the appointment(s) to display correctly. Any appointment I put in is displayed for EVERY hour, not just the one it is intended for.

This is a portion from my main.java file:

The saveButton saves the appointment
nameField is the name of the text field holding the appointment

Java Syntax (Toggle Plain Text)
if (e.getSource()==this.saveButton){
            String temptext = (nameField.getText());
            appointments.setName(temptext);
            nameField.setText(appointments.getName());
}
if (e.getSource()==this.saveButton){
            String temptext = (nameField.getText());
            appointments.setName(temptext);
            nameField.setText(appointments.getName());
}

And this portion is the part of my constructor file that is giving me the issue:

Java Syntax (Toggle Plain Text)
    public void setName(String appt){
        setName(appt);
    }
    public String getName(){
        return appt;
    }
    public void setName(String appt){
        setName(appt);
    }
    public String getName(){
        return appt;
    }

Any help on what I'm missing would be greatly appreciated!

Similar Threads

Beginning Programming with Java in Java
Is this book <JAVA in a netshell> good for beginners? in Java
One Month to learn Java - Pointers and book suggestions needed in Java
Learning Java in Java
Help tweaking some java in JavaScript / DHTML / AJAX

JimD C++ Newb

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

46 posts
since Oct 2008

Permalink

Sep 25th, 2009

Re: Java Appointment Book

Can you see something wrong with this code:

(Toggle Plain Text)

public void setName(String appt){
        setName(appt);
    }

You calling the same method. When you call setName it will call setName which is inside it, which will call setName which is inside it, which will call setName which is inside it, . . . .

You need to assign the property name inside the method:

Java Syntax (Toggle Plain Text)
public void setName(String appt){
        name = appt;
    }
public void setName(String appt){
        name = appt;
    }

javaAddict

Sponsor

Featured Poster

Reputation Points: 1014

Solved Threads: 446

Nearly a Senior Poster

Offline

3,258 posts
since Dec 2007

Permalink

Sep 25th, 2009

Re: Java Appointment Book

Progress! Your fix certainly eliminated the repeated error I was receiving (totally missed that - tyvm!!)

However the same appointment is still stored at every time segment throughout the book.

JimD C++ Newb

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

46 posts
since Oct 2008

Permalink

Sep 25th, 2009

Re: Java Appointment Book

Post more code. Skip the presentation code and post for start just the code with the logic.

javaAddict

Sponsor

Featured Poster

Reputation Points: 1014

Solved Threads: 446

Nearly a Senior Poster

Offline

3,258 posts
since Dec 2007

Permalink

Sep 25th, 2009

Re: Java Appointment Book

I'm hope I am correct in assuming this is what you are looking for. Again, thank you for taking the time to look at this.

This is from the constructor file:

Java Syntax (Toggle Plain Text)
package AppointmentBook;
 
import javax.swing.Icon;
import javax.swing.JOptionPane;
 
/**
 *
 * @author Jim
 */
public class AppointmentBook {
 
    private int hour[];
    private int time, position = 0;
    private int max;
    private String[] text;
    private String result;
    private String appt;
    private String temptext;
 
    public AppointmentBook(int start, int end) {
        int j = start;
        int[] timeArray;                //Array for appointment times
        String[] stringArray;           //Array for appointments
 
        int temp = end - start;         //Specified time period
        temp = temp/100;                
        temp++;
 
        timeArray = new int[temp];      //Space for arrays
        stringArray = new String[temp];
 
        for (int i=0;i<temp;i++) {      //Default values assigned
            stringArray[i] = "none";    
            timeArray[i] = j;
            j += 100;
        }
 
        time = 0;                       //Update state variables
        max = temp - 1;                 //All these are defined globally
        hour = timeArray;  
        text = stringArray;  
 
 
    }
    public String getTime(){
        time = hour[position];             //time at that spot in the array
        String result = "";                //the time we're on
        result = Integer.toString(time);   //change Int to String
        return result;                     //return value
    }
    public void advPosition(boolean b){    //Instead of void next() and void prev()
                                           //I used one function to do both
        if (b)
        {
            position++;                    //cycle through the array
            if (position > max)            //If 1500 is the time then...
            {
                position=max;              //Time stops cycling forward through the hours
            }
 
        }
        else
        {
            position--;
            if (position < 0)               //If 800 is the time then...
            {
                position=0;                 //Time stops cycling backward through the hours
            }
        }
 
 
    }
 
    public void setName(String appt){
        temptext = appt;
    }
    public String getName(){
        return appt;
    }
 
}
package AppointmentBook;

import javax.swing.Icon;
import javax.swing.JOptionPane;

/**
 *
 * @author Jim
 */
public class AppointmentBook {

    private int hour[];
    private int time, position = 0;
    private int max;
    private String[] text;
    private String result;
    private String appt;
    private String temptext;

    public AppointmentBook(int start, int end) {
        int j = start;
        int[] timeArray;                //Array for appointment times
        String[] stringArray;           //Array for appointments

        int temp = end - start;         //Specified time period
        temp = temp/100;                
        temp++;

        timeArray = new int[temp];      //Space for arrays
        stringArray = new String[temp];

        for (int i=0;i<temp;i++) {      //Default values assigned
            stringArray[i] = "none";    
            timeArray[i] = j;
            j += 100;
        }

        time = 0;                       //Update state variables
        max = temp - 1;                 //All these are defined globally
        hour = timeArray;  
        text = stringArray;  


    }
    public String getTime(){
        time = hour[position];             //time at that spot in the array
        String result = "";                //the time we're on
        result = Integer.toString(time);   //change Int to String
        return result;                     //return value
    }
    public void advPosition(boolean b){    //Instead of void next() and void prev()
                                           //I used one function to do both
        if (b)
        {
            position++;                    //cycle through the array
            if (position > max)            //If 1500 is the time then...
            {
                position=max;              //Time stops cycling forward through the hours
            }

        }
        else
        {
            position--;
            if (position < 0)               //If 800 is the time then...
            {
                position=0;                 //Time stops cycling backward through the hours
            }
        }
 
        
    }
  
    public void setName(String appt){
        temptext = appt;
    }
    public String getName(){
        return appt;
    }

}

And this is from the Main.java file:

Java Syntax (Toggle Plain Text)
 
public void actionPerformed(ActionEvent e) {
 
 
        if (e.getSource()==this.nextButton){
            appointments.advPosition(true);
            timeField.setText(appointments.getTime());
        }
        if (e.getSource()==this.prevButton){
            appointments.advPosition(false);
            timeField.setText(appointments.getTime());
        }
        if (e.getSource()==this.saveButton){
            String temptext = (nameField.getText());
            appointments.setName(temptext);
            //nameField.setText(appointments.getName());
        }
 
 
    }
public void actionPerformed(ActionEvent e) {


        if (e.getSource()==this.nextButton){
            appointments.advPosition(true);
            timeField.setText(appointments.getTime());
        }
        if (e.getSource()==this.prevButton){
            appointments.advPosition(false);
            timeField.setText(appointments.getTime());
        }
        if (e.getSource()==this.saveButton){
            String temptext = (nameField.getText());
            appointments.setName(temptext);
            //nameField.setText(appointments.getName());
        }


    }

JimD C++ Newb

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

46 posts
since Oct 2008

Permalink

Sep 25th, 2009

Re: Java Appointment Book

First of all look at this again:

Java Syntax (Toggle Plain Text)
    public void setName(String appt){
        temptext = appt;
    }
    public String getName(){
        return appt;
    }
    public void setName(String appt){
        temptext = appt;
    }
    public String getName(){
        return appt;
    }

You return the appt variable but in the code that variable never takes value. You just declare it and it always returns null. But you set the value to the temptext variable; shouldn't you return that instead?
Also these 2 appt variables are NOT the same:

Java Syntax (Toggle Plain Text)
   private Strign appt = null;
 
    public void setName(String appt){ // appt exists only inside this method
// it overrides the global
       temptext = appt;
    }
   private Strign appt = null;

    public void setName(String appt){ // appt exists only inside this method
// it overrides the global
       temptext = appt;
    }

When you call the set-method the global variable appt doesn't take value.

javaAddict

Sponsor

Featured Poster

Reputation Points: 1014

Solved Threads: 446

Nearly a Senior Poster

Offline

3,258 posts
since Dec 2007

Permalink

Sep 25th, 2009

Re: Java Appointment Book

And a new suggestion if you can't get you code to work.
I find your solution very confusing and not object oriented. I believe that you problem is that when it comes to time you return values from the array, but when it comes to name you declare an array but you use a single String variable which you set and return. Therefor all the times will have the same name from the method "getName".
Shouldn't you have a method that depending on the time or its position you set the at the appropriate position the name at the StringArray?

I don't know your whole logic but you can try this:

Java Syntax (Toggle Plain Text)
// SINGLE CLASS WITH JUST PROPERTIES
 
public class Appointment {
  private int time = 0;
  private String name = "";
 
  public Appointment() {
 
  }
 
// add get,set methods
 
}
// SINGLE CLASS WITH JUST PROPERTIES

public class Appointment {
  private int time = 0;
  private String name = "";

  public Appointment() {
 
  }

// add get,set methods

}

Then have a class like this:

Java Syntax (Toggle Plain Text)
public class AppointmentBook {
  private int position = 0;
  private int max = 0;
  private Appointment [] appointments = null;
 
  public Appointment(int max) {
     // this.max is the global
    // max is the local from the argument
     this.max = max;
 
    //appointments is the global
    appointments = new Appointment[max];
  }
 
   // create methods that add and get appointments to the array by increasing the position variable
  // also check the value of position in case you have too much appointment
  // add whatever functionality you want
}
public class AppointmentBook {
  private int position = 0;
  private int max = 0;
  private Appointment [] appointments = null;

  public Appointment(int max) {
     // this.max is the global
    // max is the local from the argument
     this.max = max;

    //appointments is the global
    appointments = new Appointment[max];
  }
  
   // create methods that add and get appointments to the array by increasing the position variable
  // also check the value of position in case you have too much appointment
  // add whatever functionality you want
}

examle:

Java Syntax (Toggle Plain Text)
Appointment ap = new Appointment();
ap.setName("Name");
ap.setTime(200);
 
Appointment [] appointS = new Appointment[5];
appointS[0] = ap;
 
// OR
 
appointS[1] = new Appointment();
appointS[1].setName("Name 2");
appointS[1].setTime(300);
Appointment ap = new Appointment();
ap.setName("Name");
ap.setTime(200);

Appointment [] appointS = new Appointment[5];
appointS[0] = ap;

// OR

appointS[1] = new Appointment();
appointS[1].setName("Name 2");
appointS[1].setTime(300);

Remember when you declare an array its elements are undeclared.
This: Appointment [] appointS = new Appointment[5]; will create an array but its elements (appointS[0], ... ) are null. You need to give them values like at the example

Last edited by javaAddict; Sep 25th, 2009 at 5:57 am.

javaAddict

Sponsor

Featured Poster

Reputation Points: 1014

Solved Threads: 446

Nearly a Senior Poster

Offline

3,258 posts
since Dec 2007

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in Java Forum Timeline: Spring bean config problem

Next Thread in Java Forum Timeline: Memory Problems

DaniWeb Message

Cancel Changes

User Name
Password