Ad:

Java Discussion Thread
Marked Solved
Views: 505

Nov 3rd, 2009

Help with Threads needed

Expand Post »

Hello,
I am having a difficulty in passing a barrier of JAVA graphics generating. I hope you could explain some things to me, cause I have noone to help me and it is hard to get help in internet, because I feel like missing something important.

The thing is I cannot find an example of JAVA application which looks like similar to the one I am showing a picture to you.

Click image for larger version

Name: application - how it looks.JPG
Views: 26
Size: 27.9 KB
ID: 12446

This is what I already managed to do and I was really happy about it. The problematic thing is, I am totally stuck with making it work in a beautiful way, which I want to be: being able to make a user of the program see step-by-step line drawing (once he clicks a button after placing points, the program should paint each line every half a second or so). That would be a demonstration of the algorithms used. Now the only thing I could do was just to painting all lines at once just after the button is clicked. I am trying to put a Thread.sleep(500) in a lines drawing loop, but it just ignores that and runs to the result. I also try to add that sleep in an algorithm and repaint() everything all the time, but it still skips all my efforts and I cannot do anything.

I put a component Graphic(my written class) called G in my Main class. That Graphic has paint() method which paints all the points and lines. On PW(stands for package wrapping) button clicked I get the result of Lines I need to draw. Here is how it looks:

Java Syntax (Toggle Plain Text)
if (arg0.getSource() == pw) 
{
	PackageWrapping PW = new PackageWrapping(G);
	Vector<Line>BE = PW.lines(POINTS);
 
	G.transfer(POINTS, BE);
	G.repaint();		
}
if (arg0.getSource() == pw) 
{
	PackageWrapping PW = new PackageWrapping(G);
	Vector<Line>BE = PW.lines(POINTS);
			
	G.transfer(POINTS, BE);
	G.repaint();		
}

I do not have anyone to turn to, who could give me a working example, explain my mistakes or just give any good advice.

I really expect you could help me. If you need any deeper information related to my code, just let me know.

Similar Threads

Reading in a *.csv file and loading the data into an Array in Java
old comp wont start windows....black screen upon boot in Troubleshooting Dead Machines
Win2000Pro Desktop Black Screen Message Virus Warning Fix? in Viruses, Spyware and other Nasties
Quad core rant. in Motherboards, CPUs and RAM

kolibrizas

Reputation Points: 22

Solved Threads: 1

Light Poster

Offline

45 posts
since May 2009

Permalink

Nov 3rd, 2009

Re: Help with Threads needed

You could use a Timer to help you draw your lines at specific intervals. You could also use Thread.sleep(), as you mentioned - if that isn't working there must be something wrong in your implementation. Can you post all of your (relevant) code, such as your repaint() method, everywhere you call repaint(), and where you attempted to put Thread.sleep()? And have you looked at this?

http://java.sun.com/docs/books/tutor...ncy/sleep.html

BestJewSinceJC

Reputation Points: 874

Solved Threads: 352

Posting Maven

Offline

2,758 posts
since Sep 2008

Permalink

Nov 4th, 2009

Re: Help with Threads needed

Here is the code in PackageWrapping class:

Java Syntax (Toggle Plain Text)
public void show(Vector<Point>POINTS)
{
	Vector<Line>LINES = this.lines(POINTS);
	Vector<Line>PWLINES = new Vector<Line>();
	for (int i = 0; i < LINES.size(); i++)
	{
		PWLINES.add(LINES.get(i));
		this.G.transfer(POINTS, PWLINES);
		this.G.repaint();
		try
		{
			Thread.sleep(500);
		}
		catch (Exception e){}
	}
}
public void show(Vector<Point>POINTS)
{
	Vector<Line>LINES = this.lines(POINTS);
	Vector<Line>PWLINES = new Vector<Line>();
	for (int i = 0; i < LINES.size(); i++)
	{
		PWLINES.add(LINES.get(i));
		this.G.transfer(POINTS, PWLINES);
		this.G.repaint();
		try
		{
			Thread.sleep(500);
		}
		catch (Exception e){}
	}
}

And here is how it looks in Graphic class:

Java Syntax (Toggle Plain Text)
public void paint(Graphics G)
{		
	G.setColor(Color.white);
	G.fillRect(0, 0, 400, 400);
 
	G.setColor(Color.red);
	for(int i = 0; i < this.LINES.size(); i++)
	{			
		Point A = this.LINES.get(i).A;
		Point B = this.LINES.get(i).B;			
 
		for (int j = 0; j < 5; j++)
		{
			G.drawLine(A.x-2+j, A.y, B.x-2+j, B.y);
			G.drawLine(A.x, A.y-2+j, B.x, B.y-2+j);
		}
	}
 
	G.setColor(Color.blue);
	for(int i = 0; i < this.POINTS.size(); i++)
	{			
		Point P = this.POINTS.get(i);
		G.fillOval(P.x-5, P.y-5, 10, 10);
	}
}
public void paint(Graphics G)
{		
	G.setColor(Color.white);
	G.fillRect(0, 0, 400, 400);
		
	G.setColor(Color.red);
	for(int i = 0; i < this.LINES.size(); i++)
	{			
		Point A = this.LINES.get(i).A;
		Point B = this.LINES.get(i).B;			
			
		for (int j = 0; j < 5; j++)
		{
			G.drawLine(A.x-2+j, A.y, B.x-2+j, B.y);
			G.drawLine(A.x, A.y-2+j, B.x, B.y-2+j);
		}
	}
		
	G.setColor(Color.blue);
	for(int i = 0; i < this.POINTS.size(); i++)
	{			
		Point P = this.POINTS.get(i);
		G.fillOval(P.x-5, P.y-5, 10, 10);
	}
}

And here is how it is in Main class:

Java Syntax (Toggle Plain Text)
Graphic G;
....
public Main()
{
....
            G = new Graphic();					
	G.setBounds(50, 35, 400, 400);
	CONTAINER.add(G);
	G.addMouseListener(this);
.....
	G.repaint();
}
.....
public void actionPerformed(ActionEvent arg0) 
{
            if (arg0.getSource() == pw) 
	{
		PackageWrapping PW = new PackageWrapping(G);
		PW.show(POINTS);
	}
}
Graphic G;
....
public Main()
{
....
            G = new Graphic();					
	G.setBounds(50, 35, 400, 400);
	CONTAINER.add(G);
	G.addMouseListener(this);
.....
	G.repaint();
}
.....
public void actionPerformed(ActionEvent arg0) 
{
            if (arg0.getSource() == pw) 
	{
		PackageWrapping PW = new PackageWrapping(G);
		PW.show(POINTS);
	}
}

Hope I was clear enough. The funny thing is, that after I click the button pw, the program gets stuck (I sometimes put some System.out.println("whatever...") just to see that it perfectly is written each 500ms!!!), the button is like it was pressed and not released... and after it makes everything it just then shows the final result(without showing the middle results that I want so much). I did not implement anything related to Threads however. Where do I have to do that?

Java Syntax (Toggle Plain Text)
public class Main extends JFrame implements ActionListener, MouseListener
public class Main extends JFrame implements ActionListener, MouseListener

Java Syntax (Toggle Plain Text)

public class PackageWrapping

Java Syntax (Toggle Plain Text)
public class Graphic extends Canvas
public class Graphic extends Canvas

Did I have to put anything more somewhere?

By the way, I've read a lot of articles related to Threads and they are working to me, but not working when I am trying to use them for my graphics!

Thank you for your help.

kolibrizas

Reputation Points: 22

Solved Threads: 1

Light Poster

Offline

45 posts
since May 2009

Permalink

Nov 4th, 2009

Re: Help with Threads needed

Another funny thing is that I found, that is: the loop(in the code below) is called the required amount of times, however that repaint() is not called here

Java Syntax (Toggle Plain Text)
for (int i = 0; i < LINES.size(); i++)
{
	PWLINES.add(LINES.get(i));
	this.G.transfer(POINTS, PWLINES);
	this.G.repaint();
	try
	{
		Thread.sleep(500);
	}
	catch (Exception e){}
}
for (int i = 0; i < LINES.size(); i++)
{
	PWLINES.add(LINES.get(i));
	this.G.transfer(POINTS, PWLINES);
	this.G.repaint();
	try
	{
		Thread.sleep(500);
	}
	catch (Exception e){}
}

I found that adding a simple System.out.println in a repaint() method and in that loop. It just completes the last repaint() and thats it. If only I knew how to solve this part...

kolibrizas

Reputation Points: 22

Solved Threads: 1

Light Poster

Offline

45 posts
since May 2009

Permalink

Nov 4th, 2009

Re: Help with Threads needed

The problem is that all of your code, including the thread.sleep() calls, are executing on the AWT event queue thread, which is the same thread that handles the repaint calls to update the display. You have to separate the animation updates from the painting. One way to do that would be to wrap the code you currently have in the show() method into a small Runnable class

Java Syntax (Toggle Plain Text)
    class LineAnimation implements Runnable{
        public void run() {
            Vector<Line> LINES = this.lines(POINTS);
            Vector<Line> PWLINES = new Vector<Line>();
            for (int i = 0; i < LINES.size(); i++) {
                PWLINES.add(LINES.get(i));
                this.G.transfer(POINTS, PWLINES);
                this.G.repaint();
                try {
                    Thread.sleep(500);
                } catch (Exception e) {
                }
            }
        }
    }
    class LineAnimation implements Runnable{
        public void run() {
            Vector<Line> LINES = this.lines(POINTS);
            Vector<Line> PWLINES = new Vector<Line>();
            for (int i = 0; i < LINES.size(); i++) {
                PWLINES.add(LINES.get(i));
                this.G.transfer(POINTS, PWLINES);
                this.G.repaint();
                try {
                    Thread.sleep(500);
                } catch (Exception e) {
                }
            }
        }
    }

and start a new thread with that Runnable in your show method

Java Syntax (Toggle Plain Text)
Thread lineAnim = new Thread(new LineAnimation());
lineAnim.start();
Thread lineAnim = new Thread(new LineAnimation());
lineAnim.start();

As BestJewSinceJC mentioned, a Swing Timer can also be used for this.

Last edited by Ezzaral; Nov 4th, 2009 at 3:44 pm.

Ezzaral

Moderator

Featured Poster

Reputation Points: 3239

Solved Threads: 839

Posting Genius

Offline

6,761 posts
since May 2007

Permalink

Nov 4th, 2009

Re: Help with Threads needed

Java Syntax (Toggle Plain Text)
public void show(Vector<Point>POINTS)
{
	Vector<Line> LINES = lines(POINTS);
	Thread lineAnim = new Thread(new LineAnimation(POINTS, LINES, this.G));
	lineAnim.start();		
}
public void show(Vector<Point>POINTS)
{
	Vector<Line> LINES = lines(POINTS);
	Thread lineAnim = new Thread(new LineAnimation(POINTS, LINES, this.G));
	lineAnim.start();		
}

and I made a class

Java Syntax (Toggle Plain Text)
import java.util.Vector;
 
class LineAnimation implements Runnable
{
	Vector<Point>POINTS;
	Vector<Line>LINES;
	Graphic G;
    public LineAnimation(Vector<Point>P, Vector<Line>L, Graphic G)
    {
    	this.LINES = L;
    	this.G = G;
    	this.POINTS = P;
    }
 
	public void run() {
 
        Vector<Line> PWLINES = new Vector<Line>();
        for (int i = 0; i < LINES.size(); i++) {
            PWLINES.add(LINES.get(i));
            this.G.transfer(POINTS, PWLINES);
            this.G.repaint();
            try {
                Thread.sleep(500);
            } catch (Exception e) {
            }
        }
    }
}
import java.util.Vector;

class LineAnimation implements Runnable
{
	Vector<Point>POINTS;
	Vector<Line>LINES;
	Graphic G;
    public LineAnimation(Vector<Point>P, Vector<Line>L, Graphic G)
    {
    	this.LINES = L;
    	this.G = G;
    	this.POINTS = P;
    }
	
	public void run() {
        
        Vector<Line> PWLINES = new Vector<Line>();
        for (int i = 0; i < LINES.size(); i++) {
            PWLINES.add(LINES.get(i));
            this.G.transfer(POINTS, PWLINES);
            this.G.repaint();
            try {
                Thread.sleep(500);
            } catch (Exception e) {
            }
        }
    }
}

And it worked!!!!!!!

Thank you soooo much for your help!!!!

kolibrizas

Reputation Points: 22

Solved Threads: 1

Light Poster

Offline

45 posts
since May 2009

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in Java Forum Timeline: Drag-and-drop GUI-testing for Windows 7

Next Thread in Java Forum Timeline: Correcting inefficiency in pseudocode

DaniWeb Message

Cancel Changes

User Name
Password