Ad:

Java Discussion Thread
Unsolved
Views: 5150

Page 1
2
Next

You are currently viewing page 1 of this multi-page discussion thread

Aug 3rd, 2005

using boolean expression on an array

Expand Post »

Hi

I have created an array of random numbers but I need to stop duplicate numbers being added to the array so I have added the boolean 'fresh'. however, I somehow need to tell my 'fresh' to only check the number of elements added to the array so far and I am embarrassed to say i can't figure this out as I am sure it is easy.

I have been searching books and the internet but just cannot figure it out. :rolleyes:

Any help in the right direction would be really appreciated

my code is:

Java Syntax (Toggle Plain Text)
int amount = 7;   // number of integers needed to generate
int[] nums = new int[amount]; 
int i;
 
// method for searching the array for duplicate numbers
boolean fresh (int [] nums, int val){
   for (int i = 0; i < amount; i++){
      if (nums[i] == val) return true;
      }
     {
         return false;
         }
}// end fresh method
 
//method to generate random numbers to insert into the tree
public void randomNumber()
   {
    do
     {
       for (int i=0; i<amount; i++) { 
       nums[i] = (int) Math.floor(Math.random() * 100);             
       nums[i] = nums[i] -50; 
       System.out.println("random is " + nums[i]);
       }
       }   
      while(!(fresh(nums,i)));
}// end of randomNumber method
int amount = 7;   // number of integers needed to generate
int[] nums = new int[amount]; 
int i;
	 
// method for searching the array for duplicate numbers
boolean fresh (int [] nums, int val){
   for (int i = 0; i < amount; i++){
      if (nums[i] == val) return true;
      }
     {
         return false;
         }
}// end fresh method
	 
//method to generate random numbers to insert into the tree
public void randomNumber()
   {
    do
     {
       for (int i=0; i<amount; i++) { 
       nums[i] = (int) Math.floor(Math.random() * 100);             
       nums[i] = nums[i] -50; 
       System.out.println("random is " + nums[i]);
       }
       }   
      while(!(fresh(nums,i)));
}// end of randomNumber method

Similar Threads

Any Boolean Expression to Sum of Minterms in C++

JavaFish

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

19 posts
since Jul 2005

Permalink

Aug 3rd, 2005

Re: using boolean expression on an array

That can be done a lot easier.

Java Syntax (Toggle Plain Text)
        List<Integer> l = new ArrayList<Integer>();
        for (int i=0;i<amount;i++) {
            int q = (int) Math.floor(Math.random() * 100);
            if (!l.contains(q)) {
                l.add(q);
            }            
        }
        Integer[] dummy = l.toArray(new Integer[] {});
        List<Integer> l = new ArrayList<Integer>();
        for (int i=0;i<amount;i++) {
            int q = (int) Math.floor(Math.random() * 100);
            if (!l.contains(q)) {
                l.add(q);
            }            
        }
        Integer[] dummy = l.toArray(new Integer[] {});

You'll end up with an array of Integer instead of int but with autounboxing that doesn't matter.

Most books won't mention tricks like this, and older books won't even mention the language features used here because they didn't exist until a few months ago.

jwenting

Team Colleague

Reputation Points: 1658

Solved Threads: 331

duckman

Offline

7,719 posts
since Nov 2004

Permalink

Aug 3rd, 2005

Re: using boolean expression on an array

Quote originally posted by JavaFish ...

Hi

I have created an array of random numbers but I need to stop duplicate numbers being added to the array so I have added the boolean 'fresh'. however, I somehow need to tell my 'fresh' to only check the number of elements added to the array so far and I am embarrassed to say i can't figure this out as I am sure it is easy.

I have been searching books and the internet but just cannot figure it out. :rolleyes:

Any help in the right direction would be really appreciated

my code is:
Java Syntax (Toggle Plain Text)
int amount = 7;   // number of integers needed to generate
int[] nums = new int[amount]; 
int i;
 
// method for searching the array for duplicate numbers
boolean fresh (int [] nums, int val){
   for (int i = 0; i < amount; i++){
      if (nums[i] == val) return true;
      }
     {
         return false;
         }
}// end fresh method
 
//method to generate random numbers to insert into the tree
public void randomNumber()
   {
    do
     {
       for (int i=0; i<amount; i++) { 
       nums[i] = (int) Math.floor(Math.random() * 100);             
       nums[i] = nums[i] -50; 
       System.out.println("random is " + nums[i]);
       }
       }   
      while(!(fresh(nums,i)));
}// end of randomNumber method
int amount = 7; // number of integers needed to generate int[] nums = new int[amount]; int i; // method for searching the array for duplicate numbers boolean fresh (int [] nums, int val){ for (int i = 0; i < amount; i++){ if (nums[i] == val) return true; } { return false; } }// end fresh method //method to generate random numbers to insert into the tree public void randomNumber() { do { for (int i=0; i<amount; i++) { nums[i] = (int) Math.floor(Math.random() * 100); nums[i] = nums[i] -50; System.out.println("random is " + nums[i]); } } while(!(fresh(nums,i))); }// end of randomNumber method

First of all, you send to the fresh method the index 'i' and not the value nums[i]. A solution I think:

Java Syntax (Toggle Plain Text)
int amount = 7;   // number of integers needed to generate
int[] nums = new int[amount]; 
int i;
 
// method for searching the array for duplicate numbers
boolean fresh (int [] nums, int val, int index){
   for (int i = 0; i < index; i++){
      if (nums[i] == val) return true;
      }
     {
         return false;
         }
}// end fresh method
 
//method to generate random numbers to insert into the tree
public void randomNumber()
   {
    do
     {
       for (int i=0; i<amount; i++) { 
       nums[i] = (int) Math.floor(Math.random() * 100);             
       nums[i] = nums[i] -50; 
       System.out.println("random is " + nums[i]);
       }
       }   
      while(!(fresh(nums, nums[i], i)));
}// end of randomNumber method
int amount = 7;   // number of integers needed to generate
int[] nums = new int[amount]; 
int i;
	 
// method for searching the array for duplicate numbers
boolean fresh (int [] nums, int val, int index){
   for (int i = 0; i < index; i++){
      if (nums[i] == val) return true;
      }
     {
         return false;
         }
}// end fresh method
	 
//method to generate random numbers to insert into the tree
public void randomNumber()
   {
    do
     {
       for (int i=0; i<amount; i++) { 
       nums[i] = (int) Math.floor(Math.random() * 100);             
       nums[i] = nums[i] -50; 
       System.out.println("random is " + nums[i]);
       }
       }   
      while(!(fresh(nums, nums[i], i)));
}// end of randomNumber method

adi1600

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

3 posts
since Aug 2005

Permalink

Aug 3rd, 2005

Re: using boolean expression on an array

Hi adi1600

I tried your suggestion, but the loop doesn't stop! I take it that's because I haven't told it what index is, so it doesn't know when to stop looping?

Any further suggestions on this greatly appreciated

JavaFish

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

19 posts
since Jul 2005

Permalink

Aug 3rd, 2005

Re: using boolean expression on an array

Hi Jwenting

thanks for the reply. I tried your code but couldn't get it to compile as i wasn't sure if you meant just replace my two methods with this new code or not?

So I tried:

Java Syntax (Toggle Plain Text)
 public void randomNumber()
	    {
		  List<Integer> l = new ArrayList<Integer>();
	      for (int i=0;i<amount;i++) {
	          int q = (int) Math.floor(Math.random() * 100);
	          if (!l.contains(q)) {
	              l.add(q);
	          }            
	      }
	      Integer[] dummy = l.toArray(new Integer[] {});
	 }// end of randomNumber method
 public void randomNumber()
	    {
		  List<Integer> l = new ArrayList<Integer>();
	      for (int i=0;i<amount;i++) {
	          int q = (int) Math.floor(Math.random() * 100);
	          if (!l.contains(q)) {
	              l.add(q);
	          }            
	      }
	      Integer[] dummy = l.toArray(new Integer[] {});
	 }// end of randomNumber method

but it says several errors, one of which is arraylist cannot be resolved to type.

Any ideas?

Thanks

JavaFish

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

19 posts
since Jul 2005

Permalink

Aug 3rd, 2005

Re: using boolean expression on an array

Yes, of course, I did not tested, you should try the following randomNumber method:

Java Syntax (Toggle Plain Text)
public void randomNumber() {
        int i;
        do {
            for (i = 0; i < amount; i++) {
                nums[i] = (int) Math.floor(Math.random() * 100);
                nums[i] = nums[i] - 50;
                System.out.println("random is " + nums[i]);
            }
        } while (i < amount && !(fresh(nums, nums[i], i)));
    }
public void randomNumber() {
        int i;
        do {
            for (i = 0; i < amount; i++) {
                nums[i] = (int) Math.floor(Math.random() * 100);
                nums[i] = nums[i] - 50;
                System.out.println("random is " + nums[i]);
            }
        } while (i < amount && !(fresh(nums, nums[i], i)));
    }

adi1600

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

3 posts
since Aug 2005

Permalink

Aug 3rd, 2005

Re: using boolean expression on an array

Hi

Thanks for keep trying with this. Just crashed that and it also crashed out.

Any further help would be appreciate - thank you for your time :mrgreen:

JavaFish

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

19 posts
since Jul 2005

Permalink

Aug 3rd, 2005

Re: using boolean expression on an array

Your solution is wrong anyway, this should work (I even tested before posting

Java Syntax (Toggle Plain Text)
package ro.csc.jccg;
 
/**
 * Created by IntelliJ IDEA.
 * User: Adrian Cioaca
 * Date: Aug 3, 2005
 * Time: 2:21:19 PM
 */
public class Test {
 
    int amount = 99;   // number of integers needed to generate
    int[] nums = new int[amount];
    int i;
 
    // method for searching the array for duplicate numbers
    boolean fresh(int[] nums, int val, int index) {
 
        for (int i = 0; i < index; i++) {
            if (nums[i] == val) return false;
        }
 
        return true;
 
    }// end fresh method
 
    //method to generate random numbers to insert into the tree
    public void randomNumber() {
        int i;
        //do {
        for (i = 0; i < amount; i++) {
            int aux = (int) Math.floor(Math.random() * 100);
            aux = aux - 50;
            if (fresh(nums, aux, i)) {
                System.out.println("random is " + aux);
                nums[i] = aux;
            } else {
                i--;
                //break;
            }
        }        
        //} while (i < amount && !(fresh(nums, nums[i], i)));
    }// end of randomNumber method
 
    public static void main(String[] args) {
 
        Test test = new Test();
 
        test.randomNumber();
    }
}
package ro.csc.jccg;

/**
 * Created by IntelliJ IDEA.
 * User: Adrian Cioaca
 * Date: Aug 3, 2005
 * Time: 2:21:19 PM
 */
public class Test {

    int amount = 99;   // number of integers needed to generate
    int[] nums = new int[amount];
    int i;

    // method for searching the array for duplicate numbers
    boolean fresh(int[] nums, int val, int index) {

        for (int i = 0; i < index; i++) {
            if (nums[i] == val) return false;
        }

        return true;

    }// end fresh method

    //method to generate random numbers to insert into the tree
    public void randomNumber() {
        int i;
        //do {
        for (i = 0; i < amount; i++) {
            int aux = (int) Math.floor(Math.random() * 100);
            aux = aux - 50;
            if (fresh(nums, aux, i)) {
                System.out.println("random is " + aux);
                nums[i] = aux;
            } else {
                i--;
                //break;
            }
        }        
        //} while (i < amount && !(fresh(nums, nums[i], i)));
    }// end of randomNumber method

    public static void main(String[] args) {

        Test test = new Test();

        test.randomNumber();
    }
}

adi1600

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

3 posts
since Aug 2005

Permalink

Aug 3rd, 2005

Re: using boolean expression on an array

Quote originally posted by JavaFish ...

Hi Jwenting

thanks for the reply. I tried your code but couldn't get it to compile as i wasn't sure if you meant just replace my two methods with this new code or not?

but it says several errors, one of which is arraylist cannot be resolved to type.

Any ideas?

Thanks

Yes, that replaces all the code you use to create the array.
I didn't bother to post the import statements you need, leaving that up to your imagination.
Code only works with the latest compiler also. While you can get it working with older compilers, it takes some work and isn't as easy to use.
Of course you will need to do something with the array once you've created it also

jwenting

Team Colleague

Reputation Points: 1658

Solved Threads: 331

duckman

Offline

7,719 posts
since Nov 2004

Permalink

Aug 3rd, 2005

Re: using boolean expression on an array

thanks very much adi1600 - have used your code and it definitely looks better than mine(well it works for starters!) :cheesy:

Appreciate your help.

JavaFish

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

19 posts
since Jul 2005

Page 1
2
Next

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in Java Forum Timeline: Objects

Next Thread in Java Forum Timeline: Communication Problems

DaniWeb Message

Cancel Changes

User Name
Password