Ad:

Java Discussion Thread
Unsolved
Views: 2574

Oct 10th, 2007

problem with ISBN checker

Expand Post »

I'm trying to get this ISBN checker to work. I've used the formula from this site and also this site and it seems to work fine except for the ISBN of my Java book. When I compute my book's ISBN (0131496980), it is apparently invalid. I have tried the other codes on both of those sites as well as other books I have at home and there is no problem. Here is my code:

Java Syntax (Toggle Plain Text)
public class DigitExtractor
{
	public DigitExtractor(String code)
	{
		isbn = code;
	}
	public int nextDigit()
	{
		// convert to int
		digit = isbn.charAt(count) - 48;
 
		count += 1;
 
		return digit;
	}
	public int getLength()
	{
		return isbn.length();
	}
	public String getISBN()
	{
		return isbn;
	}
	private String isbn;
	private int digit;
	private int count;
}
public class DigitExtractor
{
	public DigitExtractor(String code)
	{
		isbn = code;
	}
	public int nextDigit()
	{
		// convert to int
		digit = isbn.charAt(count) - 48;

		count += 1;

		return digit;
	}
	public int getLength()
	{
		return isbn.length();
	}
	public String getISBN()
	{
		return isbn;
	}
	private String isbn;
	private int digit;
	private int count;
}

Java Syntax (Toggle Plain Text)
public class ISBNChecker
{
	public static void main(String[] args)
	{
		DigitExtractor myDigit = new DigitExtractor("123456789X");
		int sum = 0;		// holds the sum
		int rem = 0;		// holds the remainder
		int checkSum = 0;	// holds the checkSum value
 
		if (myDigit.getLength() == 10)
		{
			// extract the next digit and add it to the sum
			for (int cnt = 0; cnt < myDigit.getLength() - 1; cnt++)
			{
				int temp = myDigit.nextDigit() * (myDigit.getLength() - cnt);
				sum += temp;
				System.out.println(temp);
			}
 
			System.out.println("sum: " + sum);
 
			// get the remainder of sum / 11
			rem = sum % 11;
			System.out.println("remainder: " + rem);
 
			// subtract remainder from 11 to get checkSum
			checkSum = 11 - rem;
 
			System.out.println("checksum: " + checkSum);
		}
		else if (myDigit.getLength() == 13)
		{
			// extract the next digit and add it to the sum
			for (int cnt = 0; cnt < myDigit.getLength() - 1; cnt++)
			{
				int temp = myDigit.nextDigit();
 
				if ((cnt + 1) % 2 == 0)
				{
					sum += temp * 3;
					System.out.println(temp * 3);
				}
				else
				{
					sum += temp;
					System.out.println(temp);
				}
			}
 
			System.out.println("sum: " + sum);
			// get the remainder of sum/10
			rem = sum % 10;
			System.out.println("rem: " + rem);
 
			// subtract remainder from 10 to get checkSum
			checkSum = 10 - rem;
 
			System.out.println("checksum: " + checkSum);
		}
		else
			System.out.println("Invalid ISBN");
 
		// check the sum to see if it is valid
		if (checkSum < 10 && (myDigit.getISBN().charAt(myDigit.getLength() - 1) == (checkSum + 48)))
			System.out.println("Valid ISBN - num");
		else if (checkSum >= 10 && (myDigit.getISBN().charAt(myDigit.getLength() - 1) == 'X'))
			System.out.println("Valid ISBN - X");
		else
			System.out.println("Invalid ISBN");
	}
}
public class ISBNChecker
{
	public static void main(String[] args)
	{
		DigitExtractor myDigit = new DigitExtractor("123456789X");
		int sum = 0;		// holds the sum
		int rem = 0;		// holds the remainder
		int checkSum = 0;	// holds the checkSum value

		if (myDigit.getLength() == 10)
		{
			// extract the next digit and add it to the sum
			for (int cnt = 0; cnt < myDigit.getLength() - 1; cnt++)
			{
				int temp = myDigit.nextDigit() * (myDigit.getLength() - cnt);
				sum += temp;
				System.out.println(temp);
			}

			System.out.println("sum: " + sum);

			// get the remainder of sum / 11
			rem = sum % 11;
			System.out.println("remainder: " + rem);

			// subtract remainder from 11 to get checkSum
			checkSum = 11 - rem;

			System.out.println("checksum: " + checkSum);
		}
		else if (myDigit.getLength() == 13)
		{
			// extract the next digit and add it to the sum
			for (int cnt = 0; cnt < myDigit.getLength() - 1; cnt++)
			{
				int temp = myDigit.nextDigit();

				if ((cnt + 1) % 2 == 0)
				{
					sum += temp * 3;
					System.out.println(temp * 3);
				}
				else
				{
					sum += temp;
					System.out.println(temp);
				}
			}

			System.out.println("sum: " + sum);
			// get the remainder of sum/10
			rem = sum % 10;
			System.out.println("rem: " + rem);

			// subtract remainder from 10 to get checkSum
			checkSum = 10 - rem;

			System.out.println("checksum: " + checkSum);
		}
		else
			System.out.println("Invalid ISBN");

		// check the sum to see if it is valid
		if (checkSum < 10 && (myDigit.getISBN().charAt(myDigit.getLength() - 1) == (checkSum + 48)))
			System.out.println("Valid ISBN - num");
		else if (checkSum >= 10 && (myDigit.getISBN().charAt(myDigit.getLength() - 1) == 'X'))
			System.out.println("Valid ISBN - X");
		else
			System.out.println("Invalid ISBN");
	}
}

Last edited by degamer106; Oct 10th, 2007 at 2:47 am.

Similar Threads

This or that? in Posting Games
Another Dell Inspiron 1000 problem or 2... in Troubleshooting Dead Machines
iBook G4: Airport problem? o.O in Apple Hardware and Devices
Big Problem in Viruses, Spyware and other Nasties
Windows XP Proffesional - Explorer problem in Windows NT / 2000 / XP

degamer106

Reputation Points: 10

Solved Threads: 0

Junior Poster

Offline

131 posts
since Mar 2006

Permalink

Oct 10th, 2007

Re: problem with ISBN checker

I also have a query about ISBN. Some books have one ISBN, SOME have two. Is it appropriate to use ISBN AS a primary key for a book table ( as I have seen it in one book).
What is ISBN. What can be the appropriate primary key for book & other products like laptops.

kedarkhedkar

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

5 posts
since Sep 2007

Permalink

Oct 10th, 2007

Re: problem with ISBN checker

Click to Expand / Collapse Quote originally posted by kedarkhedkar ...

I also have a query about ISBN. Some books have one ISBN, SOME have two. Is it appropriate to use ISBN AS a primary key for a book table ( as I have seen it in one book).
What is ISBN. What can be the appropriate primary key for book & other products like laptops.

Please post such questions as a new thread so the original question is not derailed.

Ezzaral

Moderator

Featured Poster

Reputation Points: 3239

Solved Threads: 839

Posting Genius

Offline

6,761 posts
since May 2007

Permalink

Oct 10th, 2007

Re: problem with ISBN checker

What you have here is proof that not everyone is going to play nice with "standards". Apparently Prentice Hall either miscalculated the ISBN for the book or simply don't care.

btw, your code is unnecessarilly long and convoluted.
The entire calculation can be handled in just a few lines of code (for ISBN10, similar code can be created for ISBN13):

Java Syntax (Toggle Plain Text)
public class Eleven {
	private static boolean elevenProof(String number) {
		if (number.length() != 10) {
			return false;
		}
		int total = 0;
		for (int i = 0; i < 9; i++) {
			char c = number.charAt(i);
			int digit = Character.digit(c, 10);
			total += (10 - i) * digit;
		}
		int checksum = Character.digit(number.charAt(9), 10);
		int modulo = total % 11;
		return modulo == 11 - checksum;
	}
 
	public static void main(String[] args) {
		String isbn = args[0];
		System.out.println(isbn + " is " + (elevenProof(isbn) ? "valid" : "invalid"));
	}
}
public class Eleven {
	private static boolean elevenProof(String number) {
		if (number.length() != 10) {
			return false;
		}
		int total = 0;
		for (int i = 0; i < 9; i++) {
			char c = number.charAt(i);
			int digit = Character.digit(c, 10);
			total += (10 - i) * digit;
		}
		int checksum = Character.digit(number.charAt(9), 10);
		int modulo = total % 11;
		return modulo == 11 - checksum;
	}

	public static void main(String[] args) {
		String isbn = args[0];
		System.out.println(isbn + " is " + (elevenProof(isbn) ? "valid" : "invalid"));
	}
}

jwenting

Team Colleague

Reputation Points: 1658

Solved Threads: 331

duckman

Offline

7,719 posts
since Nov 2004

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in Java Forum Timeline: Want to know something

Next Thread in Java Forum Timeline: code to search

DaniWeb Message

Cancel Changes

User Name
Password