Ad:

Pascal and Delphi Discussion Thread
Marked Solved
Views: 3246

Apr 12th, 2008

Generate N random different numbers

Expand Post »

Hello, guys!

I have to generate 10 different numbers.
What I do is to store the generated numbers in array.
Before that I check the array for duplicates.

It compiles, but I get some duplicates.
Thanks in advance for any help.

Pascal Syntax (Toggle Plain Text)
program rand;
 
{$APPTYPE CONSOLE}
 
uses
  SysUtils;
 
var
  j, i, a, m: integer;
  number: array[1..10] of integer;
  included: boolean;
 
begin
  j := 1;
  m := 1;
 
  while j < 11 do
  begin
    randomize;
    a := random(11);
 
    // Checking array for duplicates.
    for i := 1 to 10 do
    begin
      if (number[i] = a) or (a=0) then
      begin
        included := true;
      end
      else
      begin
        included := false;
      end; {if loop}
    end; {for loop}
 
    // Adding number to array.
    if not included then
    begin
      number[m] := a;
      m := m + 1;
      j := j + 1;
    end; {if loop}
  end; {while loop}
 
  // Printing out all numbers in array.
  for i := 1 to 10 do
  begin
    writeln(number[i]);
  end;
  readln;
end.
program rand;

{$APPTYPE CONSOLE}

uses
  SysUtils;

var
  j, i, a, m: integer;
  number: array[1..10] of integer;
  included: boolean;

begin
  j := 1;
  m := 1;

  while j < 11 do
  begin
    randomize;
    a := random(11);

    // Checking array for duplicates.
    for i := 1 to 10 do
    begin
      if (number[i] = a) or (a=0) then
      begin
        included := true;
      end
      else
      begin
        included := false;
      end; {if loop}
    end; {for loop}

    // Adding number to array.
    if not included then
    begin
      number[m] := a;
      m := m + 1;
      j := j + 1;
    end; {if loop}
  end; {while loop}

  // Printing out all numbers in array.
  for i := 1 to 10 do
  begin
    writeln(number[i]);
  end;
  readln;
end.

Last edited by simps0n; Apr 12th, 2008 at 7:50 am.

simps0n

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

7 posts
since Dec 2007

Permalink

Apr 13th, 2008

Re: Generate N random different numbers

The problem is that, apparently, what you really want is a permutation - it looks like you want only 10 random numbers between 1 and 10. There are any number of ways to do this. One is to go to jsoftware.com, download and install J, then type "1+10?10" in a session.

However, since this is a "Pascal and Delphi" forum, the answer will be substantially more complicated than this.

Here's my guess, allowing for my lack of Pascal knowledge: initialize the array of numbers 1 to 10, then loop through, say 10 times (this is probably overkill), swapping numbers randomly, something like this code fragment:

for i := 1 to 10 do
begin
number[i] = i;
end; (for loop)
for i := 1 to 10 do
begin
ix1 := 1+random(10);
ix2 := 1+random(10);
svnum := number[ix1];
number[ix1] := number[ix2];
number[ix2] := svnum;
end; (for loop)

Since you're swapping (roughly) 2 each time, you could shorten the loop to as little as 5 - somewhere between 5 and 10 would be optimal.

DevonMcC++

Reputation Points: 10

Solved Threads: 1

Newbie Poster

Offline

16 posts
since Feb 2008

Permalink

Apr 13th, 2008

Re: Generate N random different numbers

SysUtils is a turbo pascal unit?

another guest

Reputation Points: -7

Solved Threads: 4

Junior Poster in Training

Offline

66 posts
since Jan 2008

Permalink

Apr 17th, 2008

Re: Generate N random different numbers

Click to Expand / Collapse Quote originally posted by simps0n ...

It compiles, but I get some duplicates.

Hi simps0n,

Without taking in consideration any others questions, You must to call randomize procedure just an once time in Your project (take a look in help about it).

So, put the call to this procedure before while .. do scope, like this:

delphi Syntax (Toggle Plain Text)
...
m := 1;
randomize;
while j < 11 do
begin
  a := random(11);
...
...
m := 1;
randomize;
while j < 11 do
begin
  a := random(11);
...

Bye

Micheus

Reputation Points: 10

Solved Threads: 4

Junior Poster in Training

Offline

72 posts
since Jun 2006

Permalink

Apr 22nd, 2008

Re: Generate N random different numbers

What is also happening in your code, is that when you find a duplicate, you are setting included to True, but are not exiting your loop and the next number in the array is not a duplicate, so included is set back to false.
You just add an additional line to exit the loop when included is set to true.

Pascal and Delphi Syntax (Toggle Plain Text)
// Checking array for duplicates.
for i := 1 to 10 do
begin
  if (number[i] = a) or (a=0) then
  begin
     included := true;
     exit;
  end
  else
  begin
     included := false;
  end; {if loop}
end; {for loop}
// Checking array for duplicates.
for i := 1 to 10 do
begin
  if (number[i] = a) or (a=0) then
  begin
     included := true;
     exit;
  end
  else
  begin
     included := false;
  end; {if loop}
end; {for loop}

Just a bit about the begin ... end in your code -

You only need to wrap the commands in those if there is more than one command to be performed - in the above example, if the test is true you are going to perform 2 or more commands, so you need the begin ... end. If it is false, you are running only one command, so you don't need them, so the code could look like this:

Pascal and Delphi Syntax (Toggle Plain Text)
// Checking array for duplicates.
for i := 1 to 10 do
begin
  if (number[i] = a) or (a=0) then
  begin
     included := true;
     exit;
  end
  else included := false; {end if loop}
end; {for loop}
// Checking array for duplicates.
for i := 1 to 10 do
begin
  if (number[i] = a) or (a=0) then
  begin
     included := true;
     exit;
  end
  else included := false; {end if loop}
end; {for loop}

RoryGren

Reputation Points: 12

Solved Threads: 8

Junior Poster in Training

Offline

60 posts
since Oct 2007

Permalink

Apr 22nd, 2008

Re: Generate N random different numbers

Thank you all, guys!
Really appreciated.

simps0n

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

7 posts
since Dec 2007

Permalink

Apr 24th, 2008

Re: Generate N random different numbers

Click to Expand / Collapse Quote originally posted by simps0n ...

Thank you all, guys!
Really appreciated.

I hope you noticed, though no one commented on it, that the suggestion I made scales much better than the original algorithm. That is, if you're doing this for 10,000 numbers instead of 10, the original algorithm will take about a million times as long versus about a thousand times as long for what I proposed.

DevonMcC++

Reputation Points: 10

Solved Threads: 1

Newbie Poster

Offline

16 posts
since Feb 2008

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in Pascal and Delphi Forum Timeline: Convert Delphi Packed Record to C#

Next Thread in Pascal and Delphi Forum Timeline: 'Abstract Error' while closing the form

DaniWeb Message

Cancel Changes

User Name
Password