Hello there,

i've been playing around and this seems to have the right result for me:


the result with attack rolls 3, 2 vs defenders rolls 6 and 5:

i've made some other changes if you want to me to show you feel free to ask, and i'll explain, but thats an answer to the problem

happy coding

How do I put this into the code? I'm sorry I'm a noob I know

hey no probs i always find it hard understanding other peoples code.

basically, you want to work out who wins right?

well if i'm right, then all you need to do is put that if, else, if, else section of my code into yours, however you will need to change some of the stuff so it works with your code.

to simplify it:

you have a tuple called attack and a tuple called defense right? each contains two numbers, the first being the higher dice roll and the second being the lower dice roll.
To work out the results you need to compare the first number of the attacker against the first number of the defender. If the attackers number is higher than the defenders number then the attacker gains a point. (or in the case of risk, the loser loses a unit) however if not, then the defender gains the point (again in the case of risk; loser loses a unit)
In Code:
The second if, else combo does the same thing except it compares the two lower numbers.
In Code:
then at the end of it all, i simply print the results:

if your still stuck let me know, glad to help

happy coding

I actually found my own way around it while I was waiting for a reply. I know many will look at my code and laugh at how pathetic it is. Because I did it by running through every possible scenario, so my code is not as neat as it could be and is way bigger than it has to be, but meh. I did manage to make the program much more elaborate once I got pased my first problem, but now I have a much harder problem.

[php]#Risk dice simulator#

print "Risk Rolling Simulator"
attackForce = input("\nEnter the number of attacking units. ")
defenseForce = input("Enter the number of defending units. ")

import random
from time import time
loop = True

while loop:

attack = 0
defense = 0
attackW = 0
defenseW = 0
men = "men."
men2 = "men."

print "Attacker has", attackForce,". While defender has", defenseForce,"."
aR1 = random.randint(1,6)
aR2 = random.randint(1,6)
aR3 = random.randint(1,6)

dR1 = random.randint(1,6)
dR2 = random.randint(1,6)

print "Rolled:\n"
print "Attack:"
print aR1, aR2, aR3
print "\nDefense:"
print dR1, dR2

if dR1 > dR2:
defense = dR1, dR2
dH = dR1
dL = dR2
elif dR1 < dR2:
defense = dR2, dR1
dH = dR2
dL = dR1
elif dR1 == dR2:
defense = dR1, dR2
dH = dR1
dL = dR2


if aR1 > aR3 and aR2 > aR3 and aR1 > aR2:
attack = aR1, aR2
aH = aR1
aL = aR2
elif aR1 > aR3 and aR2 > aR3 and aR2 > aR1:
attack = aR2, aR1
aH = aR2
aL = aR1
elif aR1 > aR2 and aR3 > aR2 and aR1 > aR3:
attack = aR1, aR3
aH = aR1
aL = aR3
elif aR1 > aR2 and aR3 > aR2 and aR3 > aR1:
attack = aR3, aR1
aH = aR3
aL = aR1
elif aR2 > aR1 and aR3 > aR1 and aR2 > aR3:
attack = aR2, aR3
aH = aR2
aL = aR3
elif aR2 > aR1 and aR3 > aR1 and aR3 > aR2:
attack = aR3, aR2
aH = aR3
aL = aR2
elif aR1 > aR3 and aR2 == aR3:
attack = aR1, aR2
aH = aR1
aL = aR2
elif aR2 > aR3 and aR1 == aR3:
attack = aR2, aR1
aH = aR2
aL = aR1
elif aR3 > aR1 and aR2 == aR1:
attack = aR3, aR2
aH = aR3
aL = aR2
elif aR1 < aR3 and aR2 == aR3:
attack = aR3, aR2
aH = aR3
aL = aR2
elif aR2 < aR3 and aR1 == aR3:
attack = aR3, aR1
aH = aR3
aL = aR1
elif aR3 < aR1 and aR2 == aR1:
attack = aR1, aR2
aH = aR1
aL = aR2
elif aR1 == aR2 and aR2 == aR3:
attack = aR1, aR2
aH = aR1
aL = aR2

if aH > dH and aL > dL:
attackW = 2
elif aH > dH and aL < dL:
attackW = 1
defenseW = 1
elif aH > dH and aL == dL:
attackW = 1
defenseW = 1
elif aH < dH and aL > dL:
attackW = 1
defenseW = 1
elif aH == dH and aL > dL:
attackW = 1
defenseW = 1
elif aH < dH and aL < dL:
defenseW = 2
elif aH == dH and aL < dL:
defenseW = 2
elif aH == dH and aL == dL:
defenseW = 2
elif aH < dH and aL == dL:
defenseW = 2

if attackW == 1:
men = "man."
if defenseW == 1:
men2 = "man."

if attackW == 2:
defenseForce -= 2
elif defenseW == 2:
attackForce -= 2
else:
defenseForce -= 1
attackForce -= 1


print "\nResults are:"
print attack, "vs.", defense
print "\nAttacker looses", defenseW, men2
print "Defender looses", attackW, men
print "Attacker now has", attackForce,". While defender has", defenseForce,"."

if attackForce == 1:
Fmen2 = "man"
else:
Fmen2 = "men"
if defenseForce == 1:
Fmen = "man"
else:
Fmen = "men"

if attackForce == 0 or attackForce < 0:
print "The defender wins with", defenseForce, Fmen, "remaining."
break
elif defenseForce == 0 or defenseForce < 0:
print "The attacker wins with", attackForce, Fmen2, "remaining."
break

raw_input("\nPress [Enter] for a new assault\n")
execfile("Risk.py")[/php]
My new problem is that in a real game of risk, an attacker and a defender will not always role 3 dice or 2 dice, sometimes they will roll a smaller number of dice. ex. an attacker may want to use 3 dice, but a defender only has 1 man left so he has to use 1 die. I need to know how to do that.

hehe i read about that little scenario when i looked up the rules of risk myself, seems like a complicated little game although i didn't read it that indepth. i'll mess about with mine, see what i can get working or not working.

p.s by the way that bit you do to sort the numbers from highest to lowest. python has a sort function for lists:

I thank you VERY much for telling me about lists. I tinkered with them and have been able to pretty much make the same program run on alot less code.

[php]import random

print "---Risk attack simulator---"
aArmy = input("Enter the size of the attacking army: ")
dArmy = input("Enter the size of the defending army: ")

loop = True
while loop:

a1 = random.randint(1,6)
a2 = random.randint(1,6)
a3 = random.randint(1,6)
d1 = random.randint(1,6)
d2 = random.randint(1,6)

alist = [a1,a2,a3]
dlist = [d1,d2]

alist.sort(reverse = True)
dlist.sort(reverse = True)

print "\nAttacker rolls:", alist[0], alist[1], alist[2]
print "Defender rolls:", dlist[0], dlist[1]
print "\nResults:"
print alist[0],alist[1], "vs.", dlist[0],dlist[1]

roll1 = alist[0] - 1
roll2 = alist[1] - 1

aCount = 0
dCount = 0

if alist[0] > dlist[0]:
dArmy -= 1
dCount += 1
if alist [1] > dlist[1]:
dArmy -= 1
dCount += 1
if dlist[0] > roll1:
aArmy -= 1
aCount += 1
if dlist[1] > roll2:
aArmy -= 1
aCount += 1

print "\nAttacker looses:",aCount
print "Defender looses:",dCount
print "\nAttacker now has:",aArmy
print "Defender now has:",dArmy

if dArmy < 1 or aArmy < 1:
break

raw_input("")
execfile("RiskV2.py")
[/php]

One quick question: How do I make the program refuse to take "0" or no answer for when it asks about the armies? If nothing is entered, then it errors and if 0 is entered... then that just doesn't make sense.

A more foolproof way would be to loop each data entry like this:

glad you liked em, lists are wonderful things, lots of things can be done with them. Another great thing i love about lists is something called list comprehension.
List comprehension works in the following way:
First i'm telling python to put '1' in the list, then i tell python it's going to keep putting '1' inside it untill the 'for num in range(5)' stops looping.

Here's an example that fits your code:
In the example above, python understands that random.randint(1,6) is going to be placed in the list 3 times (3 times, because the for loop is looping 3 times; range(3))
list comprehension, simply 'compreses' loops eg if you wanted to do the above without using list comprehension, you would simply use a for loop:

if you need any more info on list comprehension, just ask.

happy coding

p.s in your code,
you don't need to store True in a variable, just do this:

alright I was able to finish the code, and now it changes the number of dice rolled according to the size of the armies. Again, like my orginal code, I'm sure there is way more code than needed for this. But it was the only way I could come up with a solution.

Code:
[php]import random

dashes = "======================================"
clear = "\n"*100

print "---Risk attack simulator---\n"

aArmy = 0
while aArmy < 2:
try:
aArmy = input("Enter the size of the attacking army (2 or more): ")
except NameError:
aArmy = 0

dArmy = 0
while dArmy < 1:
try:
dArmy = input("Enter the size of the defending army (1 or more): ")
except NameError:
dArmy = 0

while True:

if aArmy > 3:
aNum = 3
elif aArmy == 3:
aNum = 2
elif aArmy == 2:
aNum = 1
elif aArmy == 1:
break

if dArmy > 1:
dNum = 2
elif dArmy == 1:
dNum = 1

alist = [random.randint(1,6) for num in range(aNum)]
dlist = [random.randint(1,6) for num in range(dNum)]

alist.sort(reverse = True)
dlist.sort(reverse = True)

if aNum == 3 and dNum == 2:
print dashes
print "Attacker rolls:", alist[0], alist[1], alist[2]
print "Defender rolls:", dlist[0], dlist[1]
print "\nResults:"
print alist[0],alist[1], "vs.", dlist[0],dlist[1]

roll1 = alist[0] - 1
roll2 = alist[1] - 1

aCount = 0
dCount = 0

if alist[0] > dlist[0]:
dArmy -= 1
dCount += 1
if alist [1] > dlist[1]:
dArmy -= 1
dCount += 1
if dlist[0] > roll1:
aArmy -= 1
aCount += 1
if dlist[1] > roll2:
aArmy -= 1
aCount += 1

print "\nAttacker looses:",aCount
print "Defender looses:",dCount
print "\nAttacker now has:",aArmy
print "Defender now has:",dArmy
print dashes

if aNum == 3 and dNum == 1:
print dashes
print "Attacker rolls:", alist[0], alist[1], alist[2]
print "Defender rolls:", dlist[0]
print "\nResults:"
print alist[0], "vs.", dlist[0]

roll1 = alist[0] - 1

aCount = 0
dCount = 0

if alist[0] > dlist[0]:
dArmy -= 1
dCount += 1
if dlist[0] > roll1:
aArmy -= 1
aCount += 1

print "\nAttacker looses:",aCount
print "Defender looses:",dCount
print "\nAttacker now has:",aArmy
print "Defender now has:",dArmy
print dashes

if aNum == 2 and dNum == 2:
print dashes
print "Attacker rolls:", alist[0], alist[1]
print "Defender rolls:", dlist[0], dlist[1]
print "\nResults:"
print alist[0],alist[1], "vs.", dlist[0],dlist[1]

roll1 = alist[0] - 1
roll2 = alist[1] - 1

aCount = 0
dCount = 0

if alist[0] > dlist[0]:
dArmy -= 1
dCount += 1
if alist [1] > dlist[1]:
dArmy -= 1
dCount += 1
if dlist[0] > roll1:
aArmy -= 1
aCount += 1
if dlist[1] > roll2:
aArmy -= 1
aCount += 1

print "\nAttacker looses:",aCount
print "Defender looses:",dCount
print "\nAttacker now has:",aArmy
print "Defender now has:",dArmy
print dashes

if aNum == 2 and dNum == 1:
print dashes
print "Attacker rolls:", alist[0], alist[1]
print "Defender rolls:", dlist[0]
print "\nResults:"
print alist[0], "vs.", dlist[0]

roll1 = alist[0] - 1

aCount = 0
dCount = 0

if alist[0] > dlist[0]:
dArmy -= 1
dCount += 1
if dlist[0] > roll1:
aArmy -= 1
aCount += 1

print "\nAttacker looses:",aCount
print "Defender looses:",dCount
print "\nAttacker now has:",aArmy
print "Defender now has:",dArmy
print dashes

if aNum == 1 and dNum == 2:
print dashes
print "Attacker rolls:", alist[0]
print "Defender rolls:", dlist[0], dlist[1]
print "\nResults:"
print alist[0], "vs.", dlist[0]

roll1 = alist[0] - 1

aCount = 0
dCount = 0

if alist[0] > dlist[0]:
dArmy -= 1
dCount += 1
if dlist[0] > roll1:
aArmy -= 1
aCount += 1

print "\nAttacker looses:",aCount
print "Defender looses:",dCount
print "\nAttacker now has:",aArmy
print "Defender now has:",dArmy
print dashes

if aNum == 1 and dNum == 1:
print dashes
print "Attacker rolls:", alist[0]
print "Defender rolls:", dlist[0]
print "\nResults:"
print alist[0], "vs.", dlist[0]

roll1 = alist[0] - 1

aCount = 0
dCount = 0

if alist[0] > dlist[0]:
dArmy -= 1
dCount += 1
if dlist[0] > roll1:
aArmy -= 1
aCount += 1

print "\nAttacker looses:",aCount
print "Defender looses:",dCount
print "\nAttacker now has:",aArmy
print "Defender now has:",dArmy
print dashes

if dArmy < 1 or aArmy < 2 :
break

if aArmy == 1:
print "The defending army held off the assault with", dArmy, "left."
if dArmy == 0:
print "The attacking army won with", aArmy, "left."

raw_input("\n==Press [enter] for a new assault==")
print clear
execfile("RiskV2.py")
[/php]