Ad:

Python Discussion Thread
Marked Solved
Views: 2724

Sep 25th, 2007

What is wrong? Trying to make a simple calculator in Tkinter.

Expand Post »

Python Syntax (Toggle Plain Text)
global Num1
from Tkinter import *
Num1 = ""
def buttonNPush(n):
    global Num1
    Num1 = Num1+n
    print Num1
def clearScr():
    global Num1
    Num1 = ""
 
root = Tk()
textbox = Entry(root)
textbox.pack(side=TOP)
#Create Frame with buttons numbered 0-9
frameButtons = Frame(root)
frameButtons.pack(side=LEFT)
button1 = Button(frameButtons, text="1", command=buttonNPush("1"))
button1.grid(row=0, column=0)
button2 = Button(frameButtons, text="2", command=buttonNPush("2"))
button2.grid(row=0, column=1)
button3 = Button(frameButtons, text="3", command=buttonNPush("3"))
button3.grid(row=0, column=2)
button4 = Button(frameButtons, text="4", command=buttonNPush("4"))
button4.grid(row=1, column=0)
button5 = Button(frameButtons, text="5", command=buttonNPush("5"))
button5.grid(row=1, column=1)
button6 = Button(frameButtons, text="6", command=buttonNPush("6"))
button6.grid(row=1, column=2)
button7 = Button(frameButtons, text="7", command=buttonNPush("7"))
button7.grid(row=2, column=0)
button8 = Button(frameButtons, text="8", command=buttonNPush("8"))
button8.grid(row=2, column=1)
button9 = Button(frameButtons, text="9", command=buttonNPush("9"))
button9.grid(row=2, column=2)
button0 = Button(frameButtons, text="0", command=buttonNPush("0"))
button0.grid(row=3, column=0)
buttonClear = Button(frameButtons, text="C", command=clearScr)
buttonClear.grid(row=4, column=0)
root.mainloop()
global Num1
from Tkinter import *
Num1 = ""
def buttonNPush(n):
    global Num1
    Num1 = Num1+n
    print Num1
def clearScr():
    global Num1
    Num1 = ""
    
root = Tk()
textbox = Entry(root)
textbox.pack(side=TOP)
#Create Frame with buttons numbered 0-9
frameButtons = Frame(root)
frameButtons.pack(side=LEFT)
button1 = Button(frameButtons, text="1", command=buttonNPush("1"))
button1.grid(row=0, column=0)
button2 = Button(frameButtons, text="2", command=buttonNPush("2"))
button2.grid(row=0, column=1)
button3 = Button(frameButtons, text="3", command=buttonNPush("3"))
button3.grid(row=0, column=2)
button4 = Button(frameButtons, text="4", command=buttonNPush("4"))
button4.grid(row=1, column=0)
button5 = Button(frameButtons, text="5", command=buttonNPush("5"))
button5.grid(row=1, column=1)
button6 = Button(frameButtons, text="6", command=buttonNPush("6"))
button6.grid(row=1, column=2)
button7 = Button(frameButtons, text="7", command=buttonNPush("7"))
button7.grid(row=2, column=0)
button8 = Button(frameButtons, text="8", command=buttonNPush("8"))
button8.grid(row=2, column=1)
button9 = Button(frameButtons, text="9", command=buttonNPush("9"))
button9.grid(row=2, column=2)
button0 = Button(frameButtons, text="0", command=buttonNPush("0"))
button0.grid(row=3, column=0)
buttonClear = Button(frameButtons, text="C", command=clearScr)
buttonClear.grid(row=4, column=0)
root.mainloop()

It just prints:

Python Syntax (Toggle Plain Text)
1
12
123
1234
12345
123456
1234567
12345678
123456789
1234567890
1
12
123
1234
12345
123456
1234567
12345678
123456789
1234567890

How do I make it wait until I press the buttons to add the numbers to the string. The buttons also don't run the event that they are meant to run.

Similar Threads

multidigit binary to ascii in Assembly
determining frequency of words in text file in Python
Object Orientated C+++.net Calculator! in C++
calculator with password in C++
search word in n x n puzzle in C

chris99

Reputation Points: 10

Solved Threads: 0

Junior Poster

Offline

118 posts
since Sep 2006

Permalink

Sep 25th, 2007

Re: What is wrong? Trying to make a simple calculator in Tkinter.

You want to add buttons for the functions to add, multiply, etc and tie that to the proper event. Right now, every button you push calls buttonNPush which prints the button. You also have to issue a get() to retrieve data. See this link for an example.
http://www.uselesspython.com/calculator.py

woooee

Reputation Points: 741

Solved Threads: 692

Nearly a Posting Maven

Offline

2,307 posts
since Dec 2006

Permalink

Sep 27th, 2007

Re: What is wrong? Trying to make a simple calculator in Tkinter.

Two bad things stick out right away from your code:

1) Don't mix Tkinter geometry managers pack and grid within the same frame.

2) Command accepts a function reference not a function call. To pass an argument use lambda, a closure, or the new partial function (Python25).

Take a look at:
http://www.daniweb.com/code/snippet610.html

That snippet uses a lambda function to pass the argument (button value).

Last edited by vegaseat; Sep 27th, 2007 at 1:28 am. Reason: snippet

vegaseat

Moderator

Reputation Points: 1333

Solved Threads: 1403

DaniWeb's Hypocrite

Offline

5,792 posts
since Oct 2004

Permalink

Dec 14th, 2009

Re: What is wrong? Trying to make a simple calculator in Tkinter.

Click to Expand / Collapse Quote originally posted by chris99 ...

Python Syntax (Toggle Plain Text)
global Num1
from Tkinter import *
Num1 = ""
def buttonNPush(n):
    global Num1
    Num1 = Num1+n
    print Num1
def clearScr():
    global Num1
    Num1 = ""
 
root = Tk()
textbox = Entry(root)
textbox.pack(side=TOP)
#Create Frame with buttons numbered 0-9
frameButtons = Frame(root)
frameButtons.pack(side=LEFT)
button1 = Button(frameButtons, text="1", command=buttonNPush("1"))
button1.grid(row=0, column=0)
button2 = Button(frameButtons, text="2", command=buttonNPush("2"))
button2.grid(row=0, column=1)
button3 = Button(frameButtons, text="3", command=buttonNPush("3"))
button3.grid(row=0, column=2)
button4 = Button(frameButtons, text="4", command=buttonNPush("4"))
button4.grid(row=1, column=0)
button5 = Button(frameButtons, text="5", command=buttonNPush("5"))
button5.grid(row=1, column=1)
button6 = Button(frameButtons, text="6", command=buttonNPush("6"))
button6.grid(row=1, column=2)
button7 = Button(frameButtons, text="7", command=buttonNPush("7"))
button7.grid(row=2, column=0)
button8 = Button(frameButtons, text="8", command=buttonNPush("8"))
button8.grid(row=2, column=1)
button9 = Button(frameButtons, text="9", command=buttonNPush("9"))
button9.grid(row=2, column=2)
button0 = Button(frameButtons, text="0", command=buttonNPush("0"))
button0.grid(row=3, column=0)
buttonClear = Button(frameButtons, text="C", command=clearScr)
buttonClear.grid(row=4, column=0)
root.mainloop()
global Num1 from Tkinter import * Num1 = "" def buttonNPush(n): global Num1 Num1 = Num1+n print Num1 def clearScr(): global Num1 Num1 = "" root = Tk() textbox = Entry(root) textbox.pack(side=TOP) #Create Frame with buttons numbered 0-9 frameButtons = Frame(root) frameButtons.pack(side=LEFT) button1 = Button(frameButtons, text="1", command=buttonNPush("1")) button1.grid(row=0, column=0) button2 = Button(frameButtons, text="2", command=buttonNPush("2")) button2.grid(row=0, column=1) button3 = Button(frameButtons, text="3", command=buttonNPush("3")) button3.grid(row=0, column=2) button4 = Button(frameButtons, text="4", command=buttonNPush("4")) button4.grid(row=1, column=0) button5 = Button(frameButtons, text="5", command=buttonNPush("5")) button5.grid(row=1, column=1) button6 = Button(frameButtons, text="6", command=buttonNPush("6")) button6.grid(row=1, column=2) button7 = Button(frameButtons, text="7", command=buttonNPush("7")) button7.grid(row=2, column=0) button8 = Button(frameButtons, text="8", command=buttonNPush("8")) button8.grid(row=2, column=1) button9 = Button(frameButtons, text="9", command=buttonNPush("9")) button9.grid(row=2, column=2) button0 = Button(frameButtons, text="0", command=buttonNPush("0")) button0.grid(row=3, column=0) buttonClear = Button(frameButtons, text="C", command=clearScr) buttonClear.grid(row=4, column=0) root.mainloop()
It just prints:
Python Syntax (Toggle Plain Text)
1
12
123
1234
12345
123456
1234567
12345678
123456789
1234567890
1 12 123 1234 12345 123456 1234567 12345678 123456789 1234567890
How do I make it wait until I press the buttons to add the numbers to the string. The buttons also don't run the event that they are meant to run.

Python Syntax (Toggle Plain Text)
from Tkinter import *
 
def frame(root, side): 
    w = Frame(root)
    w.pack(side=side, expand=YES, fill=BOTH)
    return w
 
def button(root, side, text, command=None): 
    w = Button(root, text=text, command=command) 
    w.pack(side=side, expand=YES, fill=BOTH)
    return w
 
class Calculator(Frame):
    def __init__(self):
        Frame.__init__(self)
        self.option_add('*Font', 'Verdana 12 bold')
        self.pack(expand=YES, fill=BOTH)
        self.master.title('Simple Calculator')
        self.master.iconname("calc1")
 
        display = StringVar()
        Entry(self, relief=SUNKEN, textvariable=display).pack(side=TOP, expand=YES, fill=BOTH)
 
        for key in ("123", "456", "789", "-0."):
            keyF = frame(self, TOP)
            for char in key:
                button(keyF, LEFT, char,
                       lambda w=display, c=char: w.set(w.get() + c))
 
        opsF = frame(self, TOP)
        for char in "+-*/=":
            if char == '=':
                btn = button(opsF, LEFT, char)
                btn.bind('<ButtonRelease-1>',
                         lambda e, s=self, w=display: s.calc(w), '+')
            else:
                btn = button(opsF, LEFT, char,
                   lambda w=display, s=' %s '%char: w.set(w.get()+s))
 
        clearF = frame(self, BOTTOM)
        button(clearF, LEFT, 'Clr', lambda w=display: w.set(''))
 
    def calc(self, display):
        try:
            display.set(eval(display.get()))
        except:
            display.set("ERROR")
 
if __name__ == '__main__':
    Calculator().mainloop()
from Tkinter import *

def frame(root, side): 
    w = Frame(root)
    w.pack(side=side, expand=YES, fill=BOTH)
    return w

def button(root, side, text, command=None): 
    w = Button(root, text=text, command=command) 
    w.pack(side=side, expand=YES, fill=BOTH)
    return w

class Calculator(Frame):
    def __init__(self):
        Frame.__init__(self)
        self.option_add('*Font', 'Verdana 12 bold')
        self.pack(expand=YES, fill=BOTH)
        self.master.title('Simple Calculator')
        self.master.iconname("calc1")

        display = StringVar()
        Entry(self, relief=SUNKEN, textvariable=display).pack(side=TOP, expand=YES, fill=BOTH)

        for key in ("123", "456", "789", "-0."):
            keyF = frame(self, TOP)
            for char in key:
                button(keyF, LEFT, char,
                       lambda w=display, c=char: w.set(w.get() + c))

        opsF = frame(self, TOP)
        for char in "+-*/=":
            if char == '=':
                btn = button(opsF, LEFT, char)
                btn.bind('<ButtonRelease-1>',
                         lambda e, s=self, w=display: s.calc(w), '+')
            else:
                btn = button(opsF, LEFT, char,
                   lambda w=display, s=' %s '%char: w.set(w.get()+s))

        clearF = frame(self, BOTTOM)
        button(clearF, LEFT, 'Clr', lambda w=display: w.set(''))

    def calc(self, display):
        try:
            display.set(eval(display.get()))
        except:
            display.set("ERROR")

if __name__ == '__main__':
    Calculator().mainloop()

Last edited by Nick Evan; Dec 16th, 2009 at 8:45 am. Reason: Added code-tags

aditri

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

3 posts
since Dec 2009

Permalink

Dec 14th, 2009

Re: What is wrong? Trying to make a simple calculator in Tkinter.

Please don't bump up an old thread that has already been solved. It is confusing for the rest of us. Start your own thread if you need help!

vegaseat

Moderator

Reputation Points: 1333

Solved Threads: 1403

DaniWeb's Hypocrite

Offline

5,792 posts
since Oct 2004

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in Python Forum Timeline: What is wrong? Please help! Python game

Next Thread in Python Forum Timeline: Range and Lists

DaniWeb Message

Cancel Changes

User Name
Password