Ad:

Shell Scripting Discussion Thread
Marked Solved
Views: 1769

Apr 14th, 2008

Issue with echo $list not working in variable

Expand Post »

HI All

I have a script which counts how many times a job has failed.
For some reason my echo $list wont work in a variable, it works if i dont put it in a variable, but i need this in a variable so i can do a grep -c against another file.

Any help would be appreciated.

#!/usr/bin/ksh

set -x

cat /apps/tech/testruniquefailures | while read list ; do
JOBNAME=`echo $list`
Num=`grep -c $JOBNAME /apps/tech/testfailures1`
if [ $Num -gt 0 ] ; then
print $JOBNAME has failed $Num times >> /apps/tech/jinfo.txt
fi
done

This is the output with debug

+cat /apps/tech/testruniquefailures
+read list
+JOBNAME=echo
++ grep -c /apps/tech/testfailures1
Num=0
+ [ - -gt 0 ]
+read list

skelly16

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

34 posts
since Aug 2007

Permalink

Apr 14th, 2008

Re: Issue with echo $list not working in variable

Ok the issue i have worked out is when there seems to be a space on the new line on the file.

i.e.

cat apps/tech/testruniquefailures
<space is here>
batchjob1
batchjob2

How do i make sure the above file does not have a space on the top of it.

skelly16

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

34 posts
since Aug 2007

Permalink

Apr 14th, 2008

Re: Issue with echo $list not working in variable

Click to Expand / Collapse Quote originally posted by skelly16 ...

Ok the issue i have worked out is when there seems to be a space on the new line on the file.

i.e.

cat apps/tech/testruniquefailures
<space is here>
batchjob1
batchjob2

How do i make sure the above file does not have a space on the top of it.

don't use useless cat with while loop

Shell Scripting Syntax (Toggle Plain Text)
while read -r line
do
 #processing
done < "file"
while read -r line
do
 #processing
done < "file"

'

anyway, here's another way to solve your problem

Shell Scripting Syntax (Toggle Plain Text)
# more file
C
D
# more file1
A
B
C
D
E
C
D
C
D
A
 
# grep -f file file1 | sort | uniq -c
      3 C
      3 D
# more file
C
D
# more file1
A
B
C
D
E
C
D
C
D
A

# grep -f file file1 | sort | uniq -c
      3 C
      3 D

ghostdog74

Reputation Points: 75

Solved Threads: 44

Junior Poster

Offline

156 posts
since Apr 2006

Permalink

Apr 14th, 2008

Re: Issue with echo $list not working in variable

Grepping and sorting should do it for your script.

It looks like the file you have a blank space in is already assumed to exist in this script (doesn't get created in it).

Do you know what other script (or program) creates the file? That might be the easiest way to prevent the blank line from appearing at the top if you don't want it there.

It's probably a good idea, if that happens enough, to include some functionality in your code to strip blank lines before you parse the file.

Otherwise, the above posted answers are both good ways to deal with your issue.

, Mike

eggi

Reputation Points: 102

Solved Threads: 47

Posting Whiz

Offline

399 posts
since Oct 2007

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in Shell Scripting Forum Timeline: Finding the processor temp

Next Thread in Shell Scripting Forum Timeline: Adding version number to builds

DaniWeb Message

Cancel Changes

User Name
Password