Ad:

Shell Scripting Discussion Thread
Unsolved
Views: 980

Nov 9th, 2009

file replacement not working!

Expand Post »

Hi Team,

I am stuck in a very tight situation.. need your help

The below script does not work even please let me know where is the problem and rectify me.
Script as below:
replace.sh

Shell Scripting Syntax (Toggle Plain Text)
#!/bin/bash
file_name=$1
old_templet=$2
new_templet=$3
 
for file in file_name
do
cat $file | sed "s/old_templet/new_templet/g" > $file.new
done
#!/bin/bash
file_name=$1
old_templet=$2
new_templet=$3

for file in file_name
do
cat $file | sed "s/old_templet/new_templet/g" > $file.new
done

1)Here the file_name stands for file name
2)old_templet stands for old word to change
3)new_templet stands for new word

But when the script it gives me the below error:
./replace.sh one single oracle
cat: file_name: No such file or directory

Thanks for your patience..
hope 4 a speedy reply

cheers!
Whizkidash

Last edited by peter_budo; Nov 9th, 2009 at 5:34 am. Reason: Keep It Organized - For easy readability, always wrap programming code within posts in [code] (code blocks)

Similar Threads

HP Pavilion ze5155 BIOS problem... in Troubleshooting Dead Machines
Binary file I/O using fstreams - why not working? in C++
ASP: Deleting a file in ASP
File input. in C++
Python and the JPEG Image File, Part 2, The Image in Python

whizkidash

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

20 posts
since Nov 2009

Permalink

Nov 9th, 2009

Re: file replacement not working!

$file_name, not file_name
ditto for the other variables
use "sed -e" not just "sed"
and change $file.new to ${file}.new just to be safe

Edit: So many problems, so little text. ;-)

Last edited by masijade; Nov 9th, 2009 at 3:20 am.

masijade

Moderator

Reputation Points: 1471

Solved Threads: 490

Industrious Poster

Offline

4,043 posts
since Feb 2006

Permalink

Nov 9th, 2009

Re: file replacement not working!

Masijade answered your question but i'd like to throw something else in there. You should add checks for your arguments on the command line and verify the file exists:

Shell Scripting Syntax (Toggle Plain Text)
#!/bin/bash
file_name=$1
old_templet=$2
new_templet=$3
 
if [ "$3" = "" ]; then
  echo "usage:  ${0} <file_name> <new_templet> <old_templet>"
  exit 1
fi
 
if ! test -f ./${file_name}; then
  echo "file not found"
  exit 1
fi
 
if test -f ./${file_name}.new; then
  rm ./${file_name}.new
fi
 
sed "s/${old_templet}/${new_templet}/g" ${file_name} >> ${file_name}.new
#!/bin/bash
file_name=$1
old_templet=$2
new_templet=$3

if [ "$3" = "" ]; then
  echo "usage:  ${0} <file_name> <new_templet> <old_templet>"
  exit 1
fi

if ! test -f ./${file_name}; then
  echo "file not found"
  exit 1
fi

if test -f ./${file_name}.new; then
  rm ./${file_name}.new
fi

sed "s/${old_templet}/${new_templet}/g" ${file_name} >> ${file_name}.new

Last edited by sknake; Nov 9th, 2009 at 5:17 am.

sknake

Featured Poster

Reputation Points: 1749

Solved Threads: 735

Senior Poster

Offline

3,948 posts
since Feb 2009

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in Shell Scripting Forum Timeline: Shell script to append text file with today's date.

Next Thread in Shell Scripting Forum Timeline: OMG... simple question driving me nuts

DaniWeb Message

Cancel Changes

User Name
Password