what's wrong with this ?

Expand Post »

Hi.

I need to write a short script that's looking for a C files in a directory (based on whether it has a semicolon in it and a comment // or /*), check if the file ends with .c and rename it if it doesn't.
I'm pretty much new at this. i wrote this script but it doesn't seem to create the new file with the .c extension.

any input on why would be greatly apreciated.

#!/bin/bash
listOfFiles=`ls $1`
for file in $listOfFiles
do
semi=`grep ";" "$1/$file"`
slash=`grep "//" "$1/$file"`
if [ "$semi" != "" ]
then
if [ "$slash" != "" ]
then
extension=`echo $file | grep ".c$|.h$"`
if [ "extension" == "" ]
then
mv $1/$file $1/$file.c
fi
fi
fi
done

Similar Threads

My CD-RW plays but won't burn. What could be wrong?? Help Please? in Storage
Retrieve email I sent to the wrong person in Web Browsers
Ram voltage wrong?? in Motherboards, CPUs and RAM
Am I going about this the wrong way in IT Professionals' Lounge
wats wrong with imesh??? in Windows NT / 2000 / XP

yaeli_17

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

4 posts
since Aug 2006

Permalink

Feb 13th, 2007

Re: what's wrong with this ?

try:

Shell Scripting Syntax (Toggle Plain Text)
#
find $1 -type f -exec grep -l -e '/*' -e '//' {} \; |
while read file 
do
           grep -q ';' $file
           if [[ $? -ne 0 ]] ; then
	   echo $file | grep -q -e '\.c$' -e '\.h$'
	   if [[ $? -ne 0 ]] ; then
	          mv $file  "$file".c
	   fi   
           fi 
done
#
find $1 -type f -exec grep -l -e '/*' -e '//' {} \; |
while read file 
do
           grep -q ';' $file
           if [[ $? -ne 0 ]] ; then
	   echo $file | grep -q -e '\.c$' -e '\.h$'
	   if [[ $? -ne 0 ]] ; then
	          mv $file  "$file".c
	   fi   
           fi 
done

jim mcnamara

Reputation Points: 62

Solved Threads: 10

Junior Poster

Offline

179 posts
since May 2004

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in Shell Scripting Forum Timeline: Big Favour!!!

Next Thread in Shell Scripting Forum Timeline: Script to download file using wget

DaniWeb Message

Cancel Changes

User Name
Password