Ad:

Visual Basic 4 / 5 / 6 Discussion Thread
Marked Solved
Views: 5043

Jun 7th, 2006

End if statements

Expand Post »

hi guys, i know this might look like a n00b's homework assignment - but it aint, im studying VB for myself.

Im trying to do this tutorial over here, cuz everybody said it's good
http://www.profsr.com/vb/vbless04.htm

Prob is when i try to press the confirm button, error message pops up saying "end if without block if"? I've tried organizing my code but that doesn't seem to work... I don't get it, am I using incorrect syntax?

Here's the code for the confirm button below

Visual Basic 4 / 5 / 6 Syntax (Toggle Plain Text)
Private Sub confirm_Click()
 Dim hoursbox As Integer
 Dim deductbox As Integer
 Dim rate As Integer
 Dim grosalary As String
 Dim netsalary As String
 
If op1.Value = False _
   And op2.Value = False _
   And op3.Value = False Then
  grosalary = "invalid" And netsalary = "invalid"
End If
 
If op1.Value = True Then rate = 10
End If
 
If op2.Value = True Then rate = 20
End If
 
If op3.Value = True Then rate = 30
End If
 
grosalary = rate * hoursbox
netsalary = grosalary - deductbox
 
End Sub
Private Sub confirm_Click()
 Dim hoursbox As Integer
 Dim deductbox As Integer
 Dim rate As Integer
 Dim grosalary As String
 Dim netsalary As String
 
If op1.Value = False _
   And op2.Value = False _
   And op3.Value = False Then
  grosalary = "invalid" And netsalary = "invalid"
End If
 
If op1.Value = True Then rate = 10
End If
 
If op2.Value = True Then rate = 20
End If
 
If op3.Value = True Then rate = 30
End If
 
grosalary = rate * hoursbox
netsalary = grosalary - deductbox
 
End Sub

Thanks ^^

Last edited by Comatose; Jun 7th, 2006 at 6:31 am.

Similar Threads

switch statement on String in Java in Java
getting the text field value in HTML and CSS
Odd string concatenation behavior? in Perl
Linear search in C++
Serious help needed ASAP error message!!!! in Pascal and Delphi

nobody2ph

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

15 posts
since Mar 2004

Permalink

Jun 7th, 2006

Re: End if statements

try this,,,

Visual Basic 4 / 5 / 6 Syntax (Toggle Plain Text)
Private Sub Command1_Click()
 
    Dim hoursbox As Integer
    Dim deductbox As Integer
    Dim rate As Integer
    Dim grosalary As String
    Dim netsalary As String
 
    If op1.Value = False _
    And op2.Value = False _
    And op3.Value = False Then
 
        grosalary = "invalid"
        netsalary = "invalid"
 
    End If
 
    If op1.Value = True Then rate = 10
 
    If op2.Value = True Then rate = 20
 
    If op3.Value = True Then rate = 30
 
    grosalary = rate * hoursbox
    netsalary = grosalary - deductbox
 
End Sub
Private Sub Command1_Click()
    
    Dim hoursbox As Integer
    Dim deductbox As Integer
    Dim rate As Integer
    Dim grosalary As String
    Dim netsalary As String
    
    If op1.Value = False _
    And op2.Value = False _
    And op3.Value = False Then
    
        grosalary = "invalid"
        netsalary = "invalid"
    
    End If
    
    If op1.Value = True Then rate = 10
    
    If op2.Value = True Then rate = 20
 
    If op3.Value = True Then rate = 30
    
    grosalary = rate * hoursbox
    netsalary = grosalary - deductbox

End Sub

Last edited by Comatose; Jun 7th, 2006 at 6:31 am.

ramiljoaquin

Reputation Points: 10

Solved Threads: 2

Light Poster

Offline

37 posts
since Jun 2006

Permalink

Jun 7th, 2006

Re: End if statements

One problem that a lot of people don't understand is that an if statement has 2 different syntax. The only time you have to "end if" an if statement, is when the if statement is on more than 1 line (or if it does more than one thing). So for example, if I want to make this program change the value of a variable, display a msgbox and leave the sub, I would do this:

Visual Basic 4 / 5 / 6 Syntax (Toggle Plain Text)
somevariable = 1
if x = 5 then
     somevariable = 10
     msgbox "changed somevariable to 10"
     exit sub
end if
somevariable = 1
if x = 5 then
     somevariable = 10
     msgbox "changed somevariable to 10"
     exit sub
end if

However, let's say all I want to do is change the variable, and that's it.... just change the variable and move on, if x = 5:

Visual Basic 4 / 5 / 6 Syntax (Toggle Plain Text)
somevariable = 1
if x = 5 then somevariable = 10
somevariable = 1
if x = 5 then somevariable = 10

And that will work just fine..... in fact, it will give an error if you put a end if..... without have a "block" of code.

Another thing to keep in mind, is that it really isn't a good practice to put code that should be on 1 line, in more than 1 line. For example, the underscores used in your first if block. While VB allows you to do this (and it's supposed to be for readability) you shouldn't. Each line should represent a different purpose..... it keeps things in order. If you are comfortable programmang with the _, then keep doing it, but be aware on team projects and larger scale apps, you will kick yourself in the rump for it.

Comatose

Team Colleague

Reputation Points: 361

Solved Threads: 214

Taboo Programmer

Offline

2,413 posts
since Dec 2004

Permalink

Jun 7th, 2006

Re: End if statements

thanks guys , i understand a lot better now ^^

nobody2ph

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

15 posts
since Mar 2004

Permalink

Jun 8th, 2006

Re: End if statements

your welcome

ramiljoaquin

Reputation Points: 10

Solved Threads: 2

Light Poster

Offline

37 posts
since Jun 2006

Permalink

Sep 14th, 2007

Re: End if statements

sorry wrong post

Last edited by Dell XPS; Sep 14th, 2007 at 12:42 pm.

Dell XPS

Reputation Points: 10

Solved Threads: 0

Junior Poster in Training

Offline

85 posts
since Sep 2007

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in Visual Basic 4 / 5 / 6 Forum Timeline: Draw text on JPEG

Next Thread in Visual Basic 4 / 5 / 6 Forum Timeline: WaitForEvent if then argument

DaniWeb Message

Cancel Changes

User Name
Password