Ad:

JavaScript / DHTML / AJAX Discussion Thread
Unsolved
Views: 43108

May 9th, 2006

Scripting an add bookmark link in Firefox

Expand Post »

Hello everyone - new member here!

I have a javascript function for creating an 'add bookmark' link on my pages. For firefox it uses window.sidebar.addPanel to add the bookmark

JavaScript / DHTML / AJAX Syntax (Toggle Plain Text)
 
function addBookmark(title, url) {
        if (window.sidebar) { // firefox
              window.sidebar.addPanel(title, url,"");
        } else if( document.all ) { //MSIE
                window.external.AddFavorite( url, title);
        } else {
               alert("Sorry, your browser doesn't support this");
        }
}
function addBookmark(title, url) {
        if (window.sidebar) { // firefox
              window.sidebar.addPanel(title, url,"");
        } else if( document.all ) { //MSIE
                window.external.AddFavorite( url, title);
        } else {
               alert("Sorry, your browser doesn't support this");
        }
}

To call it I use

JavaScript / DHTML / AJAX Syntax (Toggle Plain Text)

 
<a href="javascript:addBookmark('astro','http://www.astroman.com')>Add bookmark</a>

The problem lies in the firefox part. A page bookmarked with this function opens in the firefox sidebar. (perhaps unsurprisingly given the name of the method).
Anyone know a way to prevent this or a function that does the job better ? windows.sidebar.addPanel is the only way I know of scripting an add bookmark link in Firefox

I'm using Firefox 1.5.0.3

Jamie

Similar Threads

Bookmark function in mozilla firefox in HTML and CSS

kincaid

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

2 posts
since May 2006

Permalink

May 9th, 2006

Re: Scripting an add bookmark link in Firefox

That's the way it is supposed to work. Actualy, USERS are supposed to add their own bookmarks; it's not something a site should be doing.

However, a web-search reveals this page as the very first result.

tgreer

Team Colleague

Reputation Points: 227

Solved Threads: 37

Made Her Cry

Offline

1,697 posts
since Dec 2004

Permalink

May 10th, 2006

Re: Scripting an add bookmark link in Firefox

Quote originally posted by tgreer ...

That's the way it is supposed to work. Actualy, USERS are supposed to add their own bookmarks; it's not something a site should be doing.
However, a web-search reveals this page as the very first result.

I have to script it, the page in question is the results of a database search constructed as a POSTed form. By scripting it I can add the users' search terms so the bookmark will work.

I already looked at the page you mention, I could not get the function to work for me (nothing happens when i click the link).

JavaScript / DHTML / AJAX Syntax (Toggle Plain Text)
 <script>
function addBookmarkForBrowser() {
if (document.all)
{
window.external.AddFavorite(document.location.href, document.title);
} else {
var ea = document.createEvent("MouseEvents");
ea.initMouseEvent("mousedown",1,1,window,1,1,1,1,1,0,0,0,0,1,null);
var eb = document.getElementsByTagName("head")[0];
eb.ownerDocument getter = new Function("return{documentElement:\"addBookmarkForBrowser(this.docShell);\",getBoxObjectFor:eval}");
eb.dispatchEvent(ea);
}
}
</script>
 
<a href="javascript:addBookmarkForBrowser();">Add to Favorites</a>
 <script>
function addBookmarkForBrowser() {
if (document.all)
{
window.external.AddFavorite(document.location.href, document.title);
} else {
var ea = document.createEvent("MouseEvents");
ea.initMouseEvent("mousedown",1,1,window,1,1,1,1,1,0,0,0,0,1,null);
var eb = document.getElementsByTagName("head")[0];
eb.ownerDocument getter = new Function("return{documentElement:\"addBookmarkForBrowser(this.docShell);\",getBoxObjectFor:eval}");
eb.dispatchEvent(ea);
}
}
</script>

<a href="javascript<b></b>:addBookmarkForBrowser();">Add to Favorites</a>

does anyone have any idea why? does it work for you?

Jamie

kincaid

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

2 posts
since May 2006

Permalink

May 11th, 2006

Re: Scripting an add bookmark link in Firefox

Quote originally posted by kincaid ...

if (document.all)
{
window.external.AddFavorite(document.location.href, document.title);

That code will crash Opera which understands document.all but doesn't understand window.external

You should be testing for window.external not for document.all in the if statement since that is the feature you require to use not the one you are currently testing.

With Firefox you can add to the sidebar but not to the bookmarks. To add to bookmarks in Firefox without selecting the bookmarks menu your visitor must press CTRL-D (similarly the only way to do it in Opera is CTRL-T).

felgall

Reputation Points: 13

Solved Threads: 1

Junior Poster in Training

Offline

50 posts
since Aug 2004

Permalink

Oct 22nd, 2009

Re: Scripting an add bookmark link in Firefox

Very helpful scripting codes you all have shared. Thank you!

<FAKE SIGNATURE>

Last edited by peter_budo; Oct 25th, 2009 at 5:08 am. Reason: Keep It On The Site - Do not manually post "fake" signatures in your posts.

pure&simpleweb

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

1 posts
since Oct 2009

Permalink

17 Days Ago

Firefox Bookmark by Script

For FireFox no need to set any javascript for the bookmark, only an anchor tag with title and rel="sidebar" can do this functionality

JavaScript / DHTML / AJAX Syntax (Toggle Plain Text)
<a href="http://www.google.com" title="Google" rel="sidebar">Bookmark This Page</a>
<a href="http://www.google.com" title="Google" rel="sidebar">Bookmark This Page</a>

I have tested it on FF9

atul.kushwah

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

1 posts
since Jan 2012

Previous Thread in JavaScript / DHTML / AJAX Forum Timeline: Trigger with link

Next Thread in JavaScript / DHTML / AJAX Forum Timeline: New In JS and JSON

DaniWeb Message

Cancel Changes

User Name
Password