Ad:

JSP Discussion Thread
Marked Solved
Views: 2683

Jan 28th, 2010

Javascript/JSP Error

Expand Post »

Hi,

I have pasted my code below, please paste it into a JSP and tell me why it gives the error "Unterminated String Constant"

JSP Syntax (Toggle Plain Text)
<html>
    <head>
        <title>Debugging</title>
        <script language="javascript">
            function changeOn(object, objectId) {
                alert('in function');
                if (object == 'bookingsButton') {
                    alert('first if');
                    document.getElementById(objectId).src = 'Images/BookingsOn.png';
                } else if (object == 'detailsButton') {
                    alert('2nd if');
                    document.getElementById(objectId).src = 'Images/DetailsOn.png';
                }
            }
            function changeOff(object, objectId) {
                if (object == 'bookingsButton') {
                    document.getElementById(objectId).src = 'Images/Bookings.png';
                } else if (object == 'detailsButton'){
                    document.getElementById(objectId).src = 'Images/Details.png';
                }
            }
        </script>
    </head>
    <body>
        <%
                    for (int i = 0; i < 2; i++) {
        %>
        <table>
            <tr>
                <td>
                    <a href="Bookings.jsp"><img src="Images/Bookings.png" id="bookings<%out.println("" + i);%>" onmouseover="changeOn('bookingsButton','bookings<%out.println("" + i);%>')" onmouseout="changeOff('bookingsButton','bookings<%out.println("" + i);%>')"/></a>
                </td>
                <td>
                    <a href="Details.jsp"><img src="Images/Details.png" id="details<%out.println("" + i);%>"/></a>
                </td>
            </tr>
        </table>
        <% }%>
    </body>
</html>
<html>
    <head>
        <title>Debugging</title>
        <script language="javascript">
            function changeOn(object, objectId) {
                alert('in function');
                if (object == 'bookingsButton') {
                    alert('first if');
                    document.getElementById(objectId).src = 'Images/BookingsOn.png';
                } else if (object == 'detailsButton') {
                    alert('2nd if');
                    document.getElementById(objectId).src = 'Images/DetailsOn.png';
                }
            }
            function changeOff(object, objectId) {
                if (object == 'bookingsButton') {
                    document.getElementById(objectId).src = 'Images/Bookings.png';
                } else if (object == 'detailsButton'){
                    document.getElementById(objectId).src = 'Images/Details.png';
                }
            }
        </script>
    </head>
    <body>
        <%
                    for (int i = 0; i < 2; i++) {
        %>
        <table>
            <tr>
                <td>
                    <a href="Bookings.jsp"><img src="Images/Bookings.png" id="bookings<%out.println("" + i);%>" onmouseover="changeOn('bookingsButton','bookings<%out.println("" + i);%>')" onmouseout="changeOff('bookingsButton','bookings<%out.println("" + i);%>')"/></a>
                </td>
                <td>
                    <a href="Details.jsp"><img src="Images/Details.png" id="details<%out.println("" + i);%>"/></a>
                </td>
            </tr>
        </table>
        <% }%>
    </body>
</html>

Thanks,
-Ashton

Last edited by AshtonHogan; Jan 28th, 2010 at 7:01 am.

Similar Threads

Passing variable value from javascript to jsp page at run time in JSP
Javascript Dynamic Object ID's in JavaScript / DHTML / AJAX
Javascript shows an error when no error was returned in JavaScript / DHTML / AJAX
javascript inserting between jsp in JSP
How can i Import contact using javascript in jsp in JSP

AshtonHogan

Reputation Points: 7

Solved Threads: 1

Posting Whiz in Training

Offline

209 posts
since Jul 2009

Permalink

Jan 28th, 2010

Re: Javascript/JSP Error

The use of out.println() adds a newline character causing erroneous syntax of the generated output.
The generated html is,

JSP Syntax (Toggle Plain Text)
<img src="Images/Bookings.png" id="bookings0
" onmouseover="changeOn('bookingsButton','bookings0
')" onmouseout="changeOff('bookingsButton','bookings0
')"/>
<img src="Images/Bookings.png" id="bookings0
" onmouseover="changeOn('bookingsButton','bookings0
')" onmouseout="changeOff('bookingsButton','bookings0
')"/>

There is a newline character after bookings0

Use out.print() instead. Which will generate html like,

JSP Syntax (Toggle Plain Text)
<img src="Images/Bookings.png" id="bookings0" onmouseover="changeOn('bookingsButton','bookings0')" onmouseout="changeOff('bookingsButton','bookings0')"/>
<img src="Images/Bookings.png" id="bookings0" onmouseover="changeOn('bookingsButton','bookings0')" onmouseout="changeOff('bookingsButton','bookings0')"/>

parry_kulk

Sponsor

Reputation Points: 26

Solved Threads: 41

Junior Poster

Offline

166 posts
since Jan 2007

Permalink

Jan 28th, 2010

Re: Javascript/JSP Error

You're a genius. Thanks a lot man.

AshtonHogan

Reputation Points: 7

Solved Threads: 1

Posting Whiz in Training

Offline

209 posts
since Jul 2009

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in JSP Forum Timeline: calling a class from a JSP page

Next Thread in JSP Forum Timeline: Improving Security

DaniWeb Message

Cancel Changes

User Name
Password