Ad:

PHP Discussion Thread
Unsolved
Views: 646

Jun 7th, 2008

Could a switch statement be used here?

Expand Post »

I've got some code using a lot of complex if statements that I'm using for a VIN decoder. I finally got it working and I'm hesitant to alter it but these if statements are huge! If a switch statement could be used to accomplish what the if statements are doing, could someone give me an example using my data? Here's a snippet of code:

php Syntax (Toggle Plain Text)
$ModelYear=substr($decode,5,1);
$AssemblyPlant=strtoupper(substr($decode,6,1));
          if ($AssemblyPlant == "2" && ($ModelYear >= 5 && $ModelYear <= 7)){
		echo "$AssemblyPlant = St. Therese, Canada<br />";
	} elseif ($AssemblyPlant == "7" && $ModelYear == "9"){
		echo "$AssemblyPlant = Lordstown, OH<br />";
	} elseif ($AssemblyPlant == "B" && $ModelYear == "7"){
		echo "$AssemblyPlant = Baltimore, MD<br />";
	} elseif ($AssemblyPlant == "C"){
		echo "$AssemblyPlant = Southgate, California<br />";
	} elseif ($AssemblyPlant == "E" && ($ModelYear >= 6 && $ModelYear <= 9)){
		echo "$AssemblyPlant = Linden, NJ<br />";
        } elseif ($AssemblyPlant == "G"){
		echo "$AssemblyPlant = Framingham, Massachusetts<br />";
        } elseif ($AssemblyPlant == "H"){
		echo "$AssemblyPlant = Flint, Michigan<br />";
	} elseif ($AssemblyPlant == "K" && ($ModelYear >= 5 && $ModelYear <= 7)){
		echo "$AssemblyPlant = Leeds, MO<br />";
	} elseif ($AssemblyPlant == "L" && ($ModelYear >= 3 && $ModelYear <= 7)){
		echo "$AssemblyPlant = Van Nuys, CA<br />";
	} elseif ($AssemblyPlant == "N" && $ModelYear == "4"){
		echo "$AssemblyPlant = Norwood, OH<br />";
	} elseif ($AssemblyPlant == "T" && ($ModelYear >= 6 && $ModelYear <= 9)){
		echo "$AssemblyPlant = Tarrytown, NY<br />";
	} elseif ($AssemblyPlant == "U" && $ModelYear == "8"){
		echo "$AssemblyPlant = Lordstown, OH<br />";
	} elseif ($AssemblyPlant == "W" && ($ModelYear >= 8 && $ModelYear <= 9)){
		echo "$AssemblyPlant = Willow Run, MI<br />";
        } elseif ($AssemblyPlant == "X"){
		echo "$AssemblyPlant = Fairfax, Kansas<br />";
        } elseif ($AssemblyPlant == "Y" && ($ModelYear >= 2 && $ModelYear <= 5)){
		echo "$AssemblyPlant = Wilmington, Delaware<br />";
        } elseif ($AssemblyPlant == "Z"){
		echo "$AssemblyPlant = Fremont, California<br />";
} else {
		echo "Buick's weren't built at this plant in 197$ModelYear. Please check your VIN and try again.<br />";
}
$ModelYear=substr($decode,5,1);
$AssemblyPlant=strtoupper(substr($decode,6,1));
          if ($AssemblyPlant == "2" && ($ModelYear >= 5 && $ModelYear <= 7)){
		echo "$AssemblyPlant = St. Therese, Canada<br />";
	} elseif ($AssemblyPlant == "7" && $ModelYear == "9"){
		echo "$AssemblyPlant = Lordstown, OH<br />";
	} elseif ($AssemblyPlant == "B" && $ModelYear == "7"){
		echo "$AssemblyPlant = Baltimore, MD<br />";
	} elseif ($AssemblyPlant == "C"){
		echo "$AssemblyPlant = Southgate, California<br />";
	} elseif ($AssemblyPlant == "E" && ($ModelYear >= 6 && $ModelYear <= 9)){
		echo "$AssemblyPlant = Linden, NJ<br />";
        } elseif ($AssemblyPlant == "G"){
		echo "$AssemblyPlant = Framingham, Massachusetts<br />";
        } elseif ($AssemblyPlant == "H"){
		echo "$AssemblyPlant = Flint, Michigan<br />";
	} elseif ($AssemblyPlant == "K" && ($ModelYear >= 5 && $ModelYear <= 7)){
		echo "$AssemblyPlant = Leeds, MO<br />";
	} elseif ($AssemblyPlant == "L" && ($ModelYear >= 3 && $ModelYear <= 7)){
		echo "$AssemblyPlant = Van Nuys, CA<br />";
	} elseif ($AssemblyPlant == "N" && $ModelYear == "4"){
		echo "$AssemblyPlant = Norwood, OH<br />";
	} elseif ($AssemblyPlant == "T" && ($ModelYear >= 6 && $ModelYear <= 9)){
		echo "$AssemblyPlant = Tarrytown, NY<br />";
	} elseif ($AssemblyPlant == "U" && $ModelYear == "8"){
		echo "$AssemblyPlant = Lordstown, OH<br />";
	} elseif ($AssemblyPlant == "W" && ($ModelYear >= 8 && $ModelYear <= 9)){
		echo "$AssemblyPlant = Willow Run, MI<br />";
        } elseif ($AssemblyPlant == "X"){
		echo "$AssemblyPlant = Fairfax, Kansas<br />";
        } elseif ($AssemblyPlant == "Y" && ($ModelYear >= 2 && $ModelYear <= 5)){
		echo "$AssemblyPlant = Wilmington, Delaware<br />";
        } elseif ($AssemblyPlant == "Z"){
		echo "$AssemblyPlant = Fremont, California<br />";
} else {
		echo "Buick's weren't built at this plant in 197$ModelYear. Please check your VIN and try again.<br />";
}

Thanks!

Last edited by peter_budo; Jun 10th, 2008 at 7:47 am. Reason: Keep It Organized - please use [code] tags

Similar Threads

switch statement on String in Java in Java
C# beginner switch statement in C#
switch statement in C
Switch Statement, Fall-Through. in C
Problems with switch statement in C++

forwardlookguy

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

23 posts
since Jun 2008

Permalink

Jun 8th, 2008

Re: Could a switch statement be used here?

Hy, As i read your description I think if you are using switch statements the coding line should be same no difference only thing is that code looking is good but not code line

Thanks

patelamitbe

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

3 posts
since Jun 2008

Permalink

Jun 9th, 2008

Re: Could a switch statement be used here?

Hi. I don't think a switch statement will make your code better or easier to read.

In my (humble) opoinion you're better off creating a lookup table containing: plant, modelyearfrom, modelyearto, description.

pritaeas

Sponsor

Featured Poster

Reputation Points: 550

Solved Threads: 728

Bite my shiny metal ass!

Offline

4,166 posts
since Jul 2006

Permalink

Jun 10th, 2008

Re: Could a switch statement be used here?

You can use a switch statament, but you must also use "default" case

silviuks

Reputation Points: 10

Solved Threads: 15

Junior Poster in Training

Offline

95 posts
since Apr 2006

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in PHP Forum Timeline: PHP questions - % of web + finding a developer / host

Next Thread in PHP Forum Timeline: pagination within image - IF problem

DaniWeb Message

Cancel Changes

User Name
Password