Ad:

PHP Discussion Thread
Unsolved
Views: 443

May 5th, 2009

Delete function acts unexpectedly

Expand Post »

Hello!

I have a small problem with a MySQL query inside a PHP site. If a user clicks "Yes" to delete a record, the record should be deleted (which works great)

However, when the user clicks "No", it should redirect the user to another location, leaving the record intact...but it redirects the user AND deletes the record anyway.

What am I overlooking?

Thank you in advance for any assistance!!

- Jim

PHP Syntax (Toggle Plain Text)
require_once('mysql_connect.php');
if(isset($_POST['submitted'])){
if($_POST['sure'] == "Yes") {
	echo $_POST['submitted'];
	$query = "delete from movie_users where movie_users_id = '$id'";
	$result = @mysql_query ($query);
	header("Location: current_users.php");
	echo "User deleted successfully";
} elseif($_POST['sure'] == "No") {
        header("Location: not_deleted.php");
}
}
 
	?>
	<body>
	<form action="delete_user.php" method ="post">
	<div id="main">
	<p><?PHP echo "Are you sure you want to delete user $fl_name"; ?>	
	</p>
	<input type = "radio" name = "sure" value = "Yes" /> Yes
	<input type = "radio" name = "sure" value = "No" /> No</p>
	<p><input type = "submit" name = "submit" value = "submit" /> </p>
	<input type = "hidden" name = "submitted" value = "TRUE" />
	<input type = "hidden" name = "id" value = "<?php echo $id; ?>" />
	</form>
	</body>
	</div>
 
mysql_close();
<?php
include('footer.php');
 
?>
require_once('mysql_connect.php');
if(isset($_POST['submitted'])){
if($_POST['sure'] == "Yes") {
	echo $_POST['submitted'];
	$query = "delete from movie_users where movie_users_id = '$id'";
	$result = @mysql_query ($query);
	header("Location: current_users.php");
	echo "User deleted successfully";
} elseif($_POST['sure'] == "No") {
        header("Location: not_deleted.php");
}
}
		
	?>
	<body>
	<form action="delete_user.php" method ="post">
	<div id="main">
	<p><?PHP echo "Are you sure you want to delete user $fl_name"; ?>	
	</p>
	<input type = "radio" name = "sure" value = "Yes" /> Yes
	<input type = "radio" name = "sure" value = "No" /> No</p>
	<p><input type = "submit" name = "submit" value = "submit" /> </p>
	<input type = "hidden" name = "submitted" value = "TRUE" />
	<input type = "hidden" name = "id" value = "<?php echo $id; ?>" />
	</form>
	</body>
	</div>
 
mysql_close();
<?php
include('footer.php');

?>

JimD C++ Newb

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

46 posts
since Oct 2008

Permalink

May 5th, 2009

Re: Delete function acts unexpectedly

what you have written in delete_user.php file...
And your div tag is not closed properly..
Post delete_user.php file data..

Shanti C

Reputation Points: 137

Solved Threads: 162

Posting Virtuoso

Offline

1,641 posts
since Jul 2008

Permalink

May 5th, 2009

Re: Delete function acts unexpectedly

Oh! I found the error myself! /smackhead

<form action="delete_user.php" method ="post">

needed to be

<form action="delete_user1.php" method ="post">

I forgot that I had changed the name of the file to do some other work on it while keeping the integrity of the first file incase the changes didn't work.

Thank you!

But what is wrong with my close tag?

JimD C++ Newb

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

46 posts
since Oct 2008

Permalink

May 5th, 2009

Re: Delete function acts unexpectedly

see here , you have started a div like this :

PHP Syntax (Toggle Plain Text)
<body>
	<form action="delete_user.php" method ="post">
	<div id="main">
<body>
	<form action="delete_user.php" method ="post">
	<div id="main">

But You have to Ends it like

PHP Syntax (Toggle Plain Text)

</div></form></body>

Instead of

PHP Syntax (Toggle Plain Text)

</form>
	</body>
	</div>

Shanti C

Reputation Points: 137

Solved Threads: 162

Posting Virtuoso

Offline

1,641 posts
since Jul 2008

Permalink

May 5th, 2009

Re: Delete function acts unexpectedly

Thank you for pointing out the error I didn't even see.

Everything seemed to work properly the way that I had it before, so I guess my question is...is it just good practice to close them in the reverse order you opened them, or does it really make a difference that just didn't happen to appear in this particular instance?

Thank you again

- Jim

JimD C++ Newb

Reputation Points: 10

Solved Threads: 0

Light Poster

Offline

46 posts
since Oct 2008

Permalink

May 5th, 2009

Re: Delete function acts unexpectedly

Click to Expand / Collapse Quote originally posted by JimD C++ Newb ...

Thank you for pointing out the error I didn't even see.

Everything seemed to work properly the way that I had it before, so I guess my question is...is it just good practice to close them in the reverse order you opened them, or does it really make a difference that just didn't happen to appear in this particular instance?

Thank you again

- Jim

It's not that it's "good practice." That's the right way to do it, it's like asking if you should put semicolons at the end of your line. It's how HTML/XML works.

<tagopen><innertag>blah blah</innertag></tagopen> = TagOpen CONTAINS innertag CONTAINS text

NOT

<tagopen><innertag>blah blah</tagopen></innertag> = TagOpen CONTAINS START innertag CONTAINS text, END TagOpen

Last edited by ShawnCplus; May 5th, 2009 at 12:02 pm.

ShawnCplus

Sponsor

Reputation Points: 520

Solved Threads: 268

Code Monkey

Offline

1,564 posts
since Apr 2005

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in PHP Forum Timeline: MySQL Question ...

Next Thread in PHP Forum Timeline: Wanted Help ,urgently with PHP and Ajax

DaniWeb Message

Cancel Changes

User Name
Password