Ad:

PHP Discussion Thread
Marked Solved
Views: 478

Sep 16th, 2009

Small syntax error

Expand Post »

Hi all,

Just wondering if anybody can spot the syntax error with the below.

PHP Syntax (Toggle Plain Text)
'<button type="button" onclick="window.location=\'bookview.php?id='. $row['bookingref'].'&hn'. $row['hotelname'].'\'">Book Now</button>'
'<button type="button" onclick="window.location=\'bookview.php?id='. $row['bookingref'].'&hn'. $row['hotelname'].'\'">Book Now</button>'

It works fine when I just append one row to the URL like this

PHP Syntax (Toggle Plain Text)
'<button type="button" onclick="window.location=\'results.php?id='. $row['proposalid'] . '\'">Book Now</button>'
'<button type="button" onclick="window.location=\'results.php?id='. $row['proposalid'] . '\'">Book Now</button>'

The button only stops workin when I append the second 'hotelname' row.

Think its just a syntax error but I cant manage to spot it.

Any suggestions would be much appreciated.

Similar Threads

Parse error: syntax error, unexpected $end in PHP
Homework - error C2059: syntax error : ']' in C++
Syntax error ? in PHP
Homework due tonight, can't figure it out! "error C2143: syntax error : missing ';' in C++
Help Needed Parse error: syntax error in PHP

debuitls

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

12 posts
since Sep 2009

Permalink

Sep 16th, 2009

Re: Small syntax error

what is the error ?

pritaeas

Sponsor

Featured Poster

Reputation Points: 549

Solved Threads: 722

Bite my shiny metal ass!

Offline

4,156 posts
since Jul 2006

Permalink

Sep 16th, 2009

Re: Small syntax error

Hi pritaeas

Oh sorry I should have said in my post.

When I click on the button it doesnt call bookview.php, it doesnt call any page!

Thanks

Sorry can I also just mention that I made a mistake there in my original post both examples of code I gave should be pointed towards bookview.php and not results.php as I have in my second example.

Last edited by debuitls; Sep 16th, 2009 at 9:27 am. Reason: mistake in original post

debuitls

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

12 posts
since Sep 2009

Permalink

Sep 16th, 2009

Re: Small syntax error

Not sure, if I put this:

html Syntax (Toggle Plain Text)
<button type="button" onclick="window.location='bookview.php?id=1&hn'">Book Now</button>
<button type="button" onclick="window.location='bookview.php?id=1&hn'">Book Now</button>

in a test.html file it tries to open bookview.php

Are you missing something else ? Or do you have javascript disabled ?

Last edited by pritaeas; Sep 16th, 2009 at 9:30 am.

pritaeas

Sponsor

Featured Poster

Reputation Points: 549

Solved Threads: 722

Bite my shiny metal ass!

Offline

4,156 posts
since Jul 2006

Permalink

Sep 16th, 2009

Re: Small syntax error

This works for me, this sent me to:
http://localhost/bookview.php?id=4&hn=victory

php Syntax (Toggle Plain Text)
<?php 
$row['bookingref'] = "4";
$row['hotelname'] = "victory";
echo '<button type="button" onclick="window.location=\'bookview.php?id='. $row['bookingref'].'&amp;hn='. $row['hotelname'].'\'">Book Now</button>'
 
?>
<?php 
$row['bookingref'] = "4";
$row['hotelname'] = "victory";
echo '<button type="button" onclick="window.location=\'bookview.php?id='. $row['bookingref'].'&amp;hn='. $row['hotelname'].'\'">Book Now</button>'
	  
?>

Last edited by smartness; Sep 16th, 2009 at 9:52 am.

smartness

Reputation Points: 7

Solved Threads: 14

Junior Poster

Offline

103 posts
since Aug 2007

Permalink

Sep 16th, 2009

Re: Small syntax error

Not a window.location. It's wrong ))
window.location.href = '' or window.location.reload(URL);

Last edited by SAMAEL; Sep 16th, 2009 at 11:10 am.

SAMAEL

Reputation Points: 10

Solved Threads: 3

Newbie Poster

Offline

20 posts
since Sep 2009

Permalink

Sep 16th, 2009

Re: Small syntax error

Thanks for your suggestions guys.

Just resolved this.

The syntax

PHP Syntax (Toggle Plain Text)
'<button type="button" onclick="window.location=\'bookview.php?id='. $row['bookingref'].'&hn'. $row['hotelname'].'\'">Book Now</button>'
'<button type="button" onclick="window.location=\'bookview.php?id='. $row['bookingref'].'&hn'. $row['hotelname'].'\'">Book Now</button>'

was fine as was suggested.

The problem was that the value I was appending to the URL had a comma in it.

silly mistake

Thanks again

debuitls

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

12 posts
since Sep 2009

Permalink

Sep 16th, 2009

Re: Small syntax error

also, don't forget hn=

smartness

Reputation Points: 7

Solved Threads: 14

Junior Poster

Offline

103 posts
since Aug 2007

This thread is solved

Either the thread starter or a moderator has marked this thread as solved. You can most likely trust the responses and answers given. There is most likely no reason for any further responses to be posted here. If you have a related question, please start a new thread in this forum instead.

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in PHP Forum Timeline: UML Check

Next Thread in PHP Forum Timeline: How do i echo a variable in a php mysql query ?

DaniWeb Message

Cancel Changes

User Name
Password