Ad:

PHP Discussion Thread
Unsolved
Views: 730

Page 1
2
Next

You are currently viewing page 1 of this multi-page discussion thread

Sep 18th, 2009

ReGRRtion!

Expand Post »

Can someone please help me with this recursive function! It's messing up the incrementing of $x. I don't know what's wrong and I've been looking at it for so long now.

php Syntax (Toggle Plain Text)
function list_dir($handle, $path) {
	// Loop over the directory and don\"t display certain files
	global $x;
	$x = 0;
	echo "<ul>";
	//running the while loop
	while (false !== ($file = readdir($handle))) {
		$extension = strtolower(substr(strrchr($file, '.'), 1)); 
		$dir =$path.'/'.$file;
		global $file_path;
		$file_path[$x] = $path;
		if(is_dir($dir) && $file != '.' && $file !='..' ) {
			$handle = opendir($dir) or die("unable to open file $file");
			echo "<li><b>$file</b></li>";
			list_dir($handle, $dir);
		}
 
		elseif($extension == "zip") {
			unlink($file);
		}
 
		elseif($extension == "mp3" || $extension == "mpa" && $file != '.' && $file !='..') {
			echo "<li><input type = \"checkbox\" name = \"file$x\" value = \"$file\" /><input type = \"hidden\" name = \"file".$x."_path\" value = 				\"".$file_path[$x]."\" /><a href=\"".$file_path[$x]."/$file\">$file</a></li>";
		}
		$x++;
	}
 
    echo "</ul>";
}
function list_dir($handle, $path) {
	// Loop over the directory and don\"t display certain files
	global $x;
	$x = 0;
	echo "<ul>";
	//running the while loop
	while (false !== ($file = readdir($handle))) {
		$extension = strtolower(substr(strrchr($file, '.'), 1)); 
		$dir =$path.'/'.$file;
		global $file_path;
		$file_path[$x] = $path;
		if(is_dir($dir) && $file != '.' && $file !='..' ) {
			$handle = opendir($dir) or die("unable to open file $file");
			echo "<li><b>$file</b></li>";
			list_dir($handle, $dir);
		}
		
		elseif($extension == "zip") {
			unlink($file);
		}
		
		elseif($extension == "mp3" || $extension == "mpa" && $file != '.' && $file !='..') {
			echo "<li><input type = \"checkbox\" name = \"file$x\" value = \"$file\" /><input type = \"hidden\" name = \"file".$x."_path\" value = 				\"".$file_path[$x]."\" /><a href=\"".$file_path[$x]."/$file\">$file</a></li>";
		}
		$x++;
	}

    echo "</ul>";
}

baudday

Reputation Points: 10

Solved Threads: 1

Junior Poster in Training

Offline

99 posts
since Oct 2008

Permalink

Sep 18th, 2009

Re: ReGRRtion!

I don't think there is a need to use $x. In general it is not a good idea to use globals in recursive functions. I have no possibility to test my code, but you could try this:

php Syntax (Toggle Plain Text)
function list_dir($handle, $path, $x = 0) {
	// Loop over the directory and don\"t display certain files
	echo "<ul>";
	//running the while loop
	while (false !== ($file = readdir($handle))) {
		$extension = strtolower(substr(strrchr($file, '.'), 1)); 
		$dir =$path.'/'.$file;
		if(is_dir($dir) && $file != '.' && $file !='..' ) {
			$handle = opendir($dir) or die("unable to open file $file");
			echo "<li><b>$file</b></li>";
			$x = list_dir($handle, $dir, $x);
		}
 
		elseif($extension == "zip") {
			unlink($file);
		}
 
		elseif($extension == "mp3" || $extension == "mpa" && $file != '.' && $file !='..') {
			echo "<li><input type = \"checkbox\" name = \"file$x\" value = \"$file\" /><input type = \"hidden\" name = \"file".$x."_path\" value = 				\"".$path."\" /><a href=\"".$path."/$file\">$file</a></li>";
		}
		$x++;
	}
    echo "</ul>";
  return $x;
}
function list_dir($handle, $path, $x = 0) {
	// Loop over the directory and don\"t display certain files
	echo "<ul>";
	//running the while loop
	while (false !== ($file = readdir($handle))) {
		$extension = strtolower(substr(strrchr($file, '.'), 1)); 
		$dir =$path.'/'.$file;
		if(is_dir($dir) && $file != '.' && $file !='..' ) {
			$handle = opendir($dir) or die("unable to open file $file");
			echo "<li><b>$file</b></li>";
			$x = list_dir($handle, $dir, $x);
		}
 
		elseif($extension == "zip") {
			unlink($file);
		}
 
		elseif($extension == "mp3" || $extension == "mpa" && $file != '.' && $file !='..') {
			echo "<li><input type = \"checkbox\" name = \"file$x\" value = \"$file\" /><input type = \"hidden\" name = \"file".$x."_path\" value = 				\"".$path."\" /><a href=\"".$path."/$file\">$file</a></li>";
		}
		$x++;
	}
    echo "</ul>";
  return $x;
}

Last edited by pritaeas; Sep 18th, 2009 at 9:26 am.

pritaeas

Sponsor

Featured Poster

Reputation Points: 549

Solved Threads: 722

Bite my shiny metal ass!

Offline

4,156 posts
since Jul 2006

Permalink

Sep 18th, 2009

Re: ReGRRtion!

I am not sure what the point of $x is in that function besides being a counter. But this should solve your recursion issue.

PHP Syntax (Toggle Plain Text)
<?php 
 
//Path to starting point
$path = '/your/path/goes/here';
 
//Create a recursive directory iterator
$iterator = new RecursiveDirectoryIterator($path);
 
echo "<ul>\n";
$x=0;
 
//Foreach iteration do something.
foreach (new RecursiveIteratorIterator($iterator, RecursiveIteratorIterator::SELF_FIRST) as $file)
{
 
	$extension = strtolower(end(explode('.',$file->getBasename())));
 
	if( $file->isDir() )
	{
		echo "<li><b>{$file->getBasename()}</b></li>\n";
 
	}
	else if( $file->isFile() && $extension == 'zip' )
	{
		//unlink($file->getPathname());
	}
	else if( $file->isFile() && ($extension == 'mp3' || $extension == 'mpa') )
	{
		echo "<li>
		      <input type = \"checkbox\" name = \"file$x\" value = \"{$file->getBasename()}\" />
		      <input type = \"hidden\" name = \"file".$x."_path\" value = \"{$file->getPathname()}\" />
		      <a href=\"{$file->getPathname()}\">{$file->getBasename()}</a>
		      </li>\n";
	}
	++$x;
}
echo "</ul>";
<?php 

//Path to starting point
$path = '/your/path/goes/here';

//Create a recursive directory iterator
$iterator = new RecursiveDirectoryIterator($path);

echo "<ul>\n";
$x=0;

//Foreach iteration do something.
foreach (new RecursiveIteratorIterator($iterator, RecursiveIteratorIterator::SELF_FIRST) as $file)
{
	
	$extension = strtolower(end(explode('.',$file->getBasename())));
	
	if( $file->isDir() )
	{
		echo "<li><b>{$file->getBasename()}</b></li>\n";

	}
	else if( $file->isFile() && $extension == 'zip' )
	{
		//unlink($file->getPathname());
	}
	else if( $file->isFile() && ($extension == 'mp3' || $extension == 'mpa') )
	{
		echo "<li>
		      <input type = \"checkbox\" name = \"file$x\" value = \"{$file->getBasename()}\" />
		      <input type = \"hidden\" name = \"file".$x."_path\" value = \"{$file->getPathname()}\" />
		      <a href=\"{$file->getPathname()}\">{$file->getBasename()}</a>
		      </li>\n";
	}
	++$x;
}
echo "</ul>";

It appears $x is just being used so there is a unique number to put into the checkboxes. However with php if you are using this to build a form that you can select music files to delete or move or whatever, using a checkbox name of `anything[]` will create a php array of checkbox values on submit.

Then your checkbox value can be the actual path to the file including the filename. No need to have the hidden input then.

mschroeder

Sponsor

Reputation Points: 265

Solved Threads: 126

Practically a Master Poster

Offline

624 posts
since Jul 2008

Permalink

Sep 18th, 2009

Re: ReGRRtion!

Awesome! Thanks for the help. That wasn't the exact solution, but it helped tremendously and pointed out a fatal flaw in my code. Every time list_dir was called it would reset $x to 0. So I defined $x outside the function, and passed it in as a variable. My code for that portion now looks like this.

php Syntax (Toggle Plain Text)
$x = 0;
function list_dir($handle, $path,$x) {
	// Loop over the directory and don\"t display certain files
	echo "<ul>";
	//running the while loop
	while (false !== ($file = readdir($handle))) {
		$extension = strtolower(substr(strrchr($file, '.'), 1)); 
		$dir =$path.'/'.$file;
		global $file_path;
		$file_path[$x] = $path;
		if(is_dir($dir) && $file != '.' && $file !='..' ) {
			$handle = opendir($dir) or die("unable to open file $file");
			echo "<li><b>$file</b></li>";
			list_dir($handle, $dir,$x);
		}
 
		elseif($extension == "zip") {
			unlink($file);
		}
 
		elseif($extension == "mp3" || $extension == "mpa" && $file != '.' && $file !='..') {
			echo "<li><input type = \"checkbox\" name = \"file$x\" value = \"$file\" /><input type = \"hidden\" name = \"file".$x."_path\" value = 				\"".$file_path[$x]."\" /><a href=\"".$file_path[$x]."/$file\">$file</a></li>";
		}
		$x++;
	}
 
    echo "</ul>";
    return $x;
}
$x = 0;
function list_dir($handle, $path,$x) {
	// Loop over the directory and don\"t display certain files
	echo "<ul>";
	//running the while loop
	while (false !== ($file = readdir($handle))) {
		$extension = strtolower(substr(strrchr($file, '.'), 1)); 
		$dir =$path.'/'.$file;
		global $file_path;
		$file_path[$x] = $path;
		if(is_dir($dir) && $file != '.' && $file !='..' ) {
			$handle = opendir($dir) or die("unable to open file $file");
			echo "<li><b>$file</b></li>";
			list_dir($handle, $dir,$x);
		}
		
		elseif($extension == "zip") {
			unlink($file);
		}
		
		elseif($extension == "mp3" || $extension == "mpa" && $file != '.' && $file !='..') {
			echo "<li><input type = \"checkbox\" name = \"file$x\" value = \"$file\" /><input type = \"hidden\" name = \"file".$x."_path\" value = 				\"".$file_path[$x]."\" /><a href=\"".$file_path[$x]."/$file\">$file</a></li>";
		}
		$x++;
	}

    echo "</ul>";
    return $x;
}

baudday

Reputation Points: 10

Solved Threads: 1

Junior Poster in Training

Offline

99 posts
since Oct 2008

Permalink

Sep 18th, 2009

Re: ReGRRtion!

I was writing my reply as you were adding your last reply. Thank you. I will try this simpler method out. I did not know it automatically saved them in an array.

baudday

Reputation Points: 10

Solved Threads: 1

Junior Poster in Training

Offline

99 posts
since Oct 2008

Permalink

Sep 18th, 2009

Re: ReGRRtion!

I'm trying mschroeder's method, and it's coming up with this error for each list item.

PHP Syntax (Toggle Plain Text)

Strict Standards: Only variables should be passed by reference in /opt/lampp/htdocs/Music/index.php on line 97

Last edited by baudday; Sep 18th, 2009 at 10:45 am.

baudday

Reputation Points: 10

Solved Threads: 1

Junior Poster in Training

Offline

99 posts
since Oct 2008

Permalink

Sep 18th, 2009

Re: ReGRRtion!

Also, it is no longer indenting the filenames as appropriate. For instance Dir, subdir indented from that, filenames indented from that.

baudday

Reputation Points: 10

Solved Threads: 1

Junior Poster in Training

Offline

99 posts
since Oct 2008

Permalink

Sep 18th, 2009

Re: ReGRRtion!

post what is on line 97 of your file. There is nothing in my code that is passed by reference.

The indentation will be a little more tricky but i'll see what i can do.

mschroeder

Sponsor

Reputation Points: 265

Solved Threads: 126

Practically a Master Poster

Offline

624 posts
since Jul 2008

Permalink

Sep 18th, 2009

Re: ReGRRtion!

This would be line 97

php Syntax (Toggle Plain Text)
$extension = strtolower(end(explode('.',$file->getBasename())));
$extension = strtolower(end(explode('.',$file->getBasename())));

I suppressed the error for now. And thanks, I really appreciate the help.

baudday

Reputation Points: 10

Solved Threads: 1

Junior Poster in Training

Offline

99 posts
since Oct 2008

Permalink

Sep 18th, 2009

Re: ReGRRtion!

If at all possible, could you help me remove . and .. from the list of files shown? Thought I knew how, but I couldn't figure it out.

baudday

Reputation Points: 10

Solved Threads: 1

Junior Poster in Training

Offline

99 posts
since Oct 2008

Page 1
2
Next

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in PHP Forum Timeline: Best compression

Next Thread in PHP Forum Timeline: Quick foreach question

DaniWeb Message

Cancel Changes

User Name
Password