Ad:

PHP Discussion Thread
Unsolved
Views: 378

Page 1
2
Next

You are currently viewing page 1 of this multi-page discussion thread

Feb 8th, 2010

PHP form

Expand Post »

Just trying to get a very simple form working
Getting a
Parse error: syntax error, unexpected T_IS_EQUAL on line 10

PHP Syntax (Toggle Plain Text)
<?php
$to = "";
$subject = "Contact Us";
$name = $_REQUEST['name'] ;
$email = $_REQUEST['email'] ;
$message = $_REQUEST['message'] ;
$headers = "From: $email";
$embody = "Name: $name\nEmail: $email\nSuggestion: $message" ;
$sent = mail($to, $subject, $embody, $headers) ;
if($name || $email || $message) == "" {
	echo "You seem to have left something out. Please fill in all the fields and try again.<br /><br /><a href=\"javascript:closeWindow();\">Close</a>"; }
else
if($sent)
	{echo "Thank you $name, your mail has been sent successfully with the message of:<br /><br /><i>$message</i><br /><br /><a href=\"javascript:closeWindow();\">Close</a>"; }
else
	{echo "We encountered an error sending your mail<br /><br /><a href=\"javascript:closeWindow();\">Close</a>"; }
?>
<?php
$to = "";
$subject = "Contact Us";
$name = $_REQUEST['name'] ;
$email = $_REQUEST['email'] ;
$message = $_REQUEST['message'] ;
$headers = "From: $email";
$embody = "Name: $name\nEmail: $email\nSuggestion: $message" ;
$sent = mail($to, $subject, $embody, $headers) ;
if($name || $email || $message) == "" {
	echo "You seem to have left something out. Please fill in all the fields and try again.<br /><br /><a href=\"javascript<b></b>:closeWindow();\">Close</a>"; }
else
if($sent)
	{echo "Thank you $name, your mail has been sent successfully with the message of:<br /><br /><i>$message</i><br /><br /><a href=\"javascript<b></b>:closeWindow();\">Close</a>"; }
else
	{echo "We encountered an error sending your mail<br /><br /><a href=\"javascript<b></b>:closeWindow();\">Close</a>"; }
?>

I know its something with the checking if the fields are blank, but I can't find what
Thanks

Last edited by Mouse1989; Feb 8th, 2010 at 8:28 am.

Similar Threads

Sending an image to email via PHP form? in PHP
PHP Form submit to email in PHP
Insert some code in php form in PHP
PHP Form Validation ??? in PHP
php form - pop-up window possible? in PHP

Mouse1989

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

12 posts
since Apr 2009

Permalink

Feb 8th, 2010

Re: PHP form

Click to Expand / Collapse Quote originally posted by Mouse1989 ...

Just trying to get a very simple form working
Getting a
Parse error: syntax error, unexpected T_IS_EQUAL on line 10
PHP Syntax (Toggle Plain Text)
<?php
$to = "";
$subject = "Contact Us";
$name = $_REQUEST['name'] ;
$email = $_REQUEST['email'] ;
$message = $_REQUEST['message'] ;
$headers = "From: $email";
$embody = "Name: $name\nEmail: $email\nSuggestion: $message" ;
$sent = mail($to, $subject, $embody, $headers) ;
if($name || $email || $message) == "" {
	echo "You seem to have left something out. Please fill in all the fields and try again. <a href=\"javascript:closeWindow();\">Close</a>"; }
else
if($sent)
	{echo "Thank you $name, your mail has been sent successfully with the message of: $message <a href=\"javascript:closeWindow();\">Close</a>"; }
else
	{echo "We encountered an error sending your mail <a href=\"javascript:closeWindow();\">Close</a>"; }
?>
<?php $to = ""; $subject = "Contact Us"; $name = $_REQUEST['name'] ; $email = $_REQUEST['email'] ; $message = $_REQUEST['message'] ; $headers = "From: $email"; $embody = "Name: $name\nEmail: $email\nSuggestion: $message" ; $sent = mail($to, $subject, $embody, $headers) ; if($name || $email || $message) == "" { echo "You seem to have left something out. Please fill in all the fields and try again. <a href=\"javascript:closeWindow();\">Close</a>"; } else if($sent) {echo "Thank you $name, your mail has been sent successfully with the message of: $message <a href=\"javascript:closeWindow();\">Close</a>"; } else {echo "We encountered an error sending your mail <a href=\"javascript:closeWindow();\">Close</a>"; } ?>
I know its something with the checking if the fields are blank, but I can't find what
Thanks

In the above code you forgot to put

braces for the if statement, try the following

if(($name || $email || $message) == "")

Thanks & Regards
Sai Prem
<snipped>

Last edited by nav33n; Feb 8th, 2010 at 9:46 am. Reason: Fake signature snipped. Use Control Panel -> Edit Signature to add a signature.

saiprem

Reputation Points: 16

Solved Threads: 28

Posting Whiz in Training

Offline

209 posts
since Feb 2010

Permalink

Feb 8th, 2010

Re: PHP form

Quote ...

In the above code you forgot to put

braces for the if statement, try the following

if(($name || $email || $message) == "")

That fixed the error, but now I am getting the "You seem to have left something out. P..." all the time even when everything is filled in.

Mouse1989

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

12 posts
since Apr 2009

Permalink

Feb 8th, 2010

Re: PHP form

If you are doing it from local environment, the mail sending will not works for you. You need to set the smtp address and port number in the php.ini file

Last edited by saiprem; Feb 8th, 2010 at 9:51 am. Reason: Fake signature snipped.

saiprem

Reputation Points: 16

Solved Threads: 28

Posting Whiz in Training

Offline

209 posts
since Feb 2010

Permalink

Feb 8th, 2010

Re: PHP form

It all works fine and I get the form mail through to my email inbox. Everything is ok, I just wish to check the boxes are not blank

Mouse1989

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

12 posts
since Apr 2009

Permalink

Feb 8th, 2010

Re: PHP form

Try changing if($name || $email || $message) == "" to if(empty($name)||empty($mail)||empty($message)) { }
The preferred method of checking whether or not a variable is empty is with the empty() function ( bool empty ( mixed $var ) ).
The OR operator (||) doesn't work quite the way you used it above.
You also left out a closing bracket.

Last edited by Jerail; Feb 8th, 2010 at 10:11 am.

Jerail

Reputation Points: 11

Solved Threads: 5

Light Poster

Offline

39 posts
since Feb 2010

Permalink

Feb 8th, 2010

Re: PHP form

PHP Syntax (Toggle Plain Text)
<form method="post" action="contact.php" onsubmit="window.open('contact.php','popup','width=200,height=200,scrollbars=no,resizable=no,toolbar=no,directories=no,location=no,menubar=no,status=no,left=0,top=0'); return false">
        Name: <input name="name" type="text" maxlength="15" value="">
        <br />
Email:&nbsp;&nbsp;<input name="email" type="text" maxlength="50"  value="">
<br />
Suggestion:<br />
<textarea name="message" rows="5" cols="40"  value=""></textarea>
<br>
<input type="submit" value="Submit"><input type="reset" value="Reset">
	    </form>
<form method="post" action="contact.php" onsubmit="window.open('contact.php','popup','width=200,height=200,scrollbars=no,resizable=no,toolbar=no,directories=no,location=no,menubar=no,status=no,left=0,top=0'); return false">
        Name: <input name="name" type="text" maxlength="15" value="">
        <br />
Email:&nbsp;&nbsp;<input name="email" type="text" maxlength="50"  value="">
<br />
Suggestion:<br />
<textarea name="message" rows="5" cols="40"  value=""></textarea>
<br>
<input type="submit" value="Submit"><input type="reset" value="Reset">
	    </form>

PHP Syntax (Toggle Plain Text)
$to = "email ommitted";
$subject = "Contact Us";
$name = $_REQUEST['name'] ;
$email = $_REQUEST['email'] ;
$message = $_REQUEST['message'] ;
$headers = "From: $email";
$embody = "Name: $name\nEmail: $email\nSuggestion: $message" ;
$sent = mail($to, $subject, $embody, $headers) ;
if(empty($name)||empty($mail)||empty($message))  {
	echo "You seem to have left something out. Please fill in all the fields and try again.<br /><br /><a href=\"javascript:closeWindow();\">Close</a>"; }
else 
if($sent)
	{echo "Thank you $name, your mail has been sent successfully with the message of:<br /><br /><i>$message</i><br /><br /><a href=\"javascript:closeWindow();\">Close</a>"; }
else
	{echo "We encountered an error sending your mail<br /><br /><a href=\"javascript:closeWindow();\">Close</a>"; }
?>
$to = "email ommitted";
$subject = "Contact Us";
$name = $_REQUEST['name'] ;
$email = $_REQUEST['email'] ;
$message = $_REQUEST['message'] ;
$headers = "From: $email";
$embody = "Name: $name\nEmail: $email\nSuggestion: $message" ;
$sent = mail($to, $subject, $embody, $headers) ;
if(empty($name)||empty($mail)||empty($message))  {
	echo "You seem to have left something out. Please fill in all the fields and try again.<br /><br /><a href=\"javascript<b></b>:closeWindow();\">Close</a>"; }
else 
if($sent)
	{echo "Thank you $name, your mail has been sent successfully with the message of:<br /><br /><i>$message</i><br /><br /><a href=\"javascript<b></b>:closeWindow();\">Close</a>"; }
else
	{echo "We encountered an error sending your mail<br /><br /><a href=\"javascript<b></b>:closeWindow();\">Close</a>"; }
?>

Still same problem :/ get blank error even when all boxes are filled, forgot to add the HTML form before. Possible conflict with value=""?

Last edited by Mouse1989; Feb 8th, 2010 at 10:25 am.

Mouse1989

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

12 posts
since Apr 2009

Permalink

Feb 8th, 2010

Re: PHP form

Yes you should not use value="" in your source, and more over the default will be null, it is not necessary to put that, remove that and retry again

saiprem

Reputation Points: 16

Solved Threads: 28

Posting Whiz in Training

Offline

209 posts
since Feb 2010

Permalink

Feb 8th, 2010

Re: PHP form

Change empty($mail) to empty($email)
There's a discrepancy between your variables. $mail does not exist.
Also, you should really do your validation before sending the e-mail with mail(). This would avoid a lot of unnecessary blank e-mails being sent.

Also, do what saiprem said and remove the value = "" attributes from your HTML form. value isn't even a valid attribute of <textarea> .

Last edited by Jerail; Feb 8th, 2010 at 10:33 am.

Jerail

Reputation Points: 11

Solved Threads: 5

Light Poster

Offline

39 posts
since Feb 2010

Permalink

Feb 8th, 2010

Re: PHP form

Thanks for the discrepancy note

How would I go about doing validation beforehand?

Last edited by Mouse1989; Feb 8th, 2010 at 11:23 am.

Mouse1989

Reputation Points: 10

Solved Threads: 0

Newbie Poster

Offline

12 posts
since Apr 2009

Page 1
2
Next

This thread is more than three months old

No one has posted to this discussion for at least three months. Please let old threads die and do not reply to them unless you feel you have something new and valuable to contribute that absolutely must be added to make the discussion complete. Otherwise, please start a new thread in this forum instead.

Previous Thread in PHP Forum Timeline: switch case function

Next Thread in PHP Forum Timeline: plz help to display multidimensional array in html table

DaniWeb Message

Cancel Changes

User Name
Password