Image Upload to Folder on Server

[ebanbury]

Hi
I have the following script to upload an image to the server.
Instead of the script producing a unique name for the image, I actually want to just replace one image with another..ie. overwrite an image which is already there, with another of the same name.

I'm getting a 'File Upload Sucessful' message - but the new image is not overwriting the old one.

Any help would be great.

I think the problem is around the whole tmp_file naming, as I've been trying to remove that and just stick with image_name throughout...but I've got a bit mixed up.

`

`<?php
//define a maxim size for the uploaded images in Kb
 define ("MAX_SIZE","1000"); 

//This function reads the extension of the file. It is used to determine if the
// file  is an image by checking the extension.
 function getExtension($str) {
         $i = strrpos($str,".");
         if (!$i) { return ""; }
         $l = strlen($str) - $i;
         $ext = substr($str,$i+1,$l);
         return $ext;
 }

//This variable is used as a flag. The value is initialized with 0 (meaning no 
// error  found)  
//and it will be changed to 1 if an errro occures.  
//If the error occures the file will not be uploaded.
 $errors=0;
//checks if the form has been submitted
 if(isset($_POST['Submit'])) 
 {
    //reads the name of the file the user submitted for uploading
    $image_name=$_FILES['image']['name'];
    //if it is not empty
    if ($image_name) 
    {
    //get the original name of the file from the clients machine
        $filename = stripslashes($_FILES['image']['name']);
    //get the extension of the file in a lower case format
        $extension = getExtension($filename);
        $extension = strtolower($extension);
    //if it is not a known extension, we will suppose it is an error and 
        // will not  upload the file,  
    //otherwise we will do more tests
 if (($extension != "jpg") && ($extension != "jpeg") && ($extension !=
 "png") && ($extension != "gif")) 
        {
        //print error message
            echo '<h1>Unknown extension!</h1>';
            $errors=1;
        }
        else
        {
//get the size of the image in bytes
 //$_FILES['image']['tmp_name'] is the temporary filename of the file
 //in which the uploaded file was stored on the server
 $size=filesize($_FILES['image']['tmp_name']);

//compare the size with the maxim size we defined and print error if bigger
if ($size > MAX_SIZE*1024)
{
    echo '<h1>You have exceeded the size limit!</h1>';
    $errors=1;
}

//we will give an unique name, for example the time in unix time format
//$image_name=time().'.'.$extension;
//the new name will be containing the full path where will be stored (images 
//folder)
$newname="images/Grounds/".$image_name;
//we verify if the image has been uploaded, and print error instead
$copied = move_uploaded_file($_FILES['image']['tmp_name'], $newname);
if (!$copied) 
{
    echo '<h1>Copy unsuccessfull!</h1>';
    $errors=1;
}}}}

//If no errors registred, print the success message
 if(isset($_POST['Submit']) && !$errors) 
 {
    echo "<h1>File Uploaded Successfully! Try again!</h1>";
 }

 ?>

 <!--next comes the form, you must set the enctype to "multipart/frm-data" 
and use an input type "file" -->
 <form name="newad" method="post" enctype="multipart/form-data"  
action="">
 <table>
    <tr><td><input type="file" name="image"></td></tr>
    <tr><td><input name="Submit" type="submit" value="Upload image">
       </td></tr>
 </table>    
 </form>`

`

[LastMitch]

@ebanbury

You been on Daniweb for 2 years now that's a long time. The issue I'm having is that I can't read your code because it's all green. Why can't you post your code correctly meaning presentable and readable.

Look at this thread that you post close to a year ago:

http://www.daniweb.com/web-development/php/threads/424503/prepared-statements-with-update-query

Does that look nice and more presentable?

I feel like you didn't take time to post the code instead you just came on Daniweb and copy and paste your code and leave it the way it is and expect someone to read what you post?

[ebanbury]

Hi Sorry
Yes I do try and post it correctly. I thought I just click on 'code' in the navbar above?
Many apologies.