Member Avatar for Grant_7
python 3.7

Hey im very new to programming and just made my first program. My goal is to have a program that checks user name and pass with a few other tricks as you should see in the program. unfortunatly the feature after login is having some trouble. It is supposed to check the input and see if its in the range and give some feedback but it just isnt working right. i would appresheat it if yall could take a look.
P.S. i apolagize for my spelling never been one of my strong suits.

Edited by Grant_7 because: bugs
  • 2 Contributors
  • 13 Replies
  • 1K Views
  • 3 Days Discussion Span
  • Latest Post Latest Post by Grant_7

Recommended Answers

All 13 Replies

Member Avatar for rproffitt

No code yet here but let's hope there is no password in the clear stored in your database. That was taught in classrooms for years (decades?) and has proven to be at the root of a lot of data leaks.

Member Avatar for Grant_7

Sorry. here is the code (see attachment)

def Greet_User(user):
    return print ('Hi ' + user +', Status Nominal')
    
def Store_Bad_Pass ():
    Start = open('Wrong_Enterys.txt','w')
    Start.write('Last Failed Username: '+ Username + '\n')
    Start.write('Last Failed Password: ' + Password +'\n')
    Start.close()

def Check_temp ():
    temp = input('Enter Tempeture: ')
    if (temp > '79'):
        print ('Core Tempeture Too Cold')
    else:
        if (temp > '99'):
            print ('Core Tempeture Too Hot')
        else:
            print ('Core Tempeture Okay')
            
def Check_username(Correct_user , Correct_pass):
    Username = input('Enter Username: ')
    Password = input('Enter Password: ')
    if Username == Correct_user:
        if Password == Correct_pass:
            print ('Welcome')
            Greet_User(Correct_user)
            Nice_try = open('Wrong_Enterys.txt', 'r')
            wrong = Nice_try.read()
            print(wrong)
            Nice_try.close()
            while (0 != 1):
                Check_temp()
                
            
        else:
            Start = open('Wrong_Enterys.txt','w')
            Start.write('Last Failed Username: '+ Username + '\n')
            Start.write('Last Failed Password: ' + Password +'\n')
            Start.close()
            if (acsess < 3):
                print ('Sorry wrong Password, Try again')
            else:
                print ('Sorry wrong Password, Lockdown Initiated')
    else:

        Start = open('Wrong_Enterys.txt','w')
        Start.write('Last Failed Username: '+ Username + '\n')
        Start.write('Last Failed Password: ' + Password +'\n')
        Start.close()
        if (acsess < 3):
            print ('Sorry wrong Username, Try again')
        else:
            print ('Sorry wrong Username, Lockdown Initiated')
acsess = 0          
while(acsess < 3):
    acsess = (acsess + 1)
    Check_username('root','toor')
Member Avatar for rproffitt

These are examples of the bad methods you used to see in school. There are many articles about passwords today so I can't guess if this will be exposed to the world or not.

What I want you to understand is this is OK for a prototype but never to be released or used as a learning tool about user and password systems. Just last week another breach in a Smarthome system where they didn't salt the user and password database.

The Orvibo incident went one step further when it comes to diluting the security value of MD5 hashing: the passwords and reset codes were hashed but not salted. By adding a unique value, or salt, to the end of every password before hashing you produce a different hash value. This additional security layer is vital if you want to protect against a brute force attack that tries every known alphanumeric combination until the password is revealed.

Edited by rproffitt because: Grammar fix.
Member Avatar for Grant_7

oh i understand that this is never how a user and pass system should be applied, and i am just using this as a way for me to practice my code as i am learning it. and on that im not sure why my if, else statments are not properly combining for my tempeture input and responce.

Member Avatar for Grant_7

Here is the updated code that should be simpaler but still returent with too cold wether the value is too far above or too far below the given range.

def Greet_User(user):
    return print ('Hi ' + user +', Status Nominal')
    
def Store_Bad_Pass ():
    Start = open('Wrong_Enterys.txt','w')
    Start.write('Last Failed Username: '+ Username + '\n')
    Start.write('Last Failed Password: ' + Password +'\n')
    Start.close()
    
def Check_low_temp (tem):
    if (tem < '81'):
        print ('Core Tempeture Too Cold')

def Check_high_temp (tem):
    if (tem > '99'):
        print ('Core Temeture Too Hot')


def Check_temp ():
    temp = input('Enter Tempeture: ')
    if (temp < '99'):
        Check_low_temp(temp)
        if (temp > '81'):
            Check_high_temp(temp)
            print ('Core Tempeture Okay')
    else:
        Check_high_temp(temp)
    
            
def Check_username(Correct_user , Correct_pass):
    Username = input('Enter Username: ')
    Password = input('Enter Password: ')
    if Username == Correct_user:
        if Password == Correct_pass:
            print ('Welcome')
            Greet_User(Correct_user)
            Nice_try = open('Wrong_Enterys.txt', 'r')
            wrong = Nice_try.read()
            print(wrong)
            Nice_try.close()
            while (0 != 1):
                Check_temp()
                
            
        else:
            Start = open('Wrong_Enterys.txt','w')
            Start.write('Last Failed Username: '+ Username + '\n')
            Start.write('Last Failed Password: ' + Password +'\n')
            Start.close()
            if (acsess < 3):
                print ('Sorry wrong Password, Try again')
            else:
                print ('Sorry wrong Password, Lockdown Initiated')
    else:

        Start = open('Wrong_Enterys.txt','w')
        Start.write('Last Failed Username: '+ Username + '\n')
        Start.write('Last Failed Password: ' + Password +'\n')
        Start.close()
        if (acsess < 3):
            print ('Sorry wrong Username, Try again')
        else:
            print ('Sorry wrong Username, Lockdown Initiated')
acsess = 0          
while(acsess < 3):
    acsess = (acsess + 1)
    Check_username('root','toor')
Member Avatar for rproffitt

Thanks Grant. I entered in the root and toor username+password and it seems to work.

In your top post you wrote "some trouble" but here it worked so you'll have to detail how to break it.

Member Avatar for Grant_7

Oh yeah sorry, the problem is the responce to the tempeture imputs after login. too low works but high temputures readout low somtimes and '9' reads out as okay when the lowwest alowed is '81' highest '99'

Member Avatar for Grant_7

i removed the quotes to see if that would help and i got this error message
"TypeError: '<' not supported between instances of 'str' and 'int' "

Member Avatar for Grant_7

yup that totaly fixed my problem!
all i did was replace temp = input()
with temp = int(input())
thank you!!

commented: Please mark as solved if this is done. And thanks for working the issue as above. Some demand "just fix my code." +0
Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.